From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Liu Date: Fri, 24 Jun 2016 13:12:25 +0000 Subject: Re: [patch] xfs: don't allow negative error tags Message-Id: <576D31B9.8010908@easystack.cn> List-Id: References: <20160624122234.GA23169@mwanda> In-Reply-To: <20160624122234.GA23169@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: kernel-janitors@vger.kernel.org Hi Dan, xfs_errortag_add() is called by xfs_file_ioctl(), which accept the 1st argument as signed, i.e, typedef struct xfs_error_injection { __s32 fd; __s32 errtag; } xfs_error_injection_t; Should we make it happy as well? Also, the typedef can be converted to to struct xfs_error_injection by removing the depreciated xfs_error_injection_t syntax if so. On 2016年06月24日 20:22, Dan Carpenter wrote: Errors go from zero which means no error to XFS_ERRTAG_MAX (22). My static checker complains that xfs_errortag_add() puts an upper bound on this but not a lower bound. Let's fix it by making it unsigned. Signed-off-by: Dan Carpenter diff --git a/fs/xfs/xfs_error.h b/fs/xfs/xfs_error.h index 4ed3042..2e4f67f 100644 --- a/fs/xfs/xfs_error.h +++ b/fs/xfs/xfs_error.h @@ -128,7 +128,7 @@ extern int xfs_error_test(int, int *, char *, int, char *, unsigned long); xfs_error_test((tag), (mp)->m_fixedfsid, "expr", __LINE__, __FILE__, \ (rf)))) -extern int xfs_errortag_add(int error_tag, struct xfs_mount *mp); +extern int xfs_errortag_add(unsigned int error_tag, struct xfs_mount *mp); extern int xfs_errortag_clearall(struct xfs_mount *mp, int loud); #else #define XFS_TEST_ERROR(expr, mp, tag, rf) (expr) diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c index 355619a..ed7ee4e 100644 --- a/fs/xfs/xfs_error.c +++ b/fs/xfs/xfs_error.c @@ -55,7 +55,7 @@ xfs_error_test(int error_tag, int *fsidp, char *expression, } int -xfs_errortag_add(int error_tag, xfs_mount_t *mp) +xfs_errortag_add(unsigned int error_tag, xfs_mount_t *mp) { int i; int len; _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs -- Cheers, Jeff Liu