All of
 help / color / mirror / Atom feed
From: Jeff Liu <>
Subject: Re: [patch] xfs: don't allow negative error tags
Date: Fri, 24 Jun 2016 13:20:37 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20160624122234.GA23169@mwanda>

Hi Dan,

xfs_errortag_add() is called by xfs_file_ioctl(), which accept the 1st
argument as signed, i.e,

typedef struct xfs_error_injection {
__s32 fd;
__s32 errtag;
} xfs_error_injection_t;

Should we make it happy as well? Also, the typedef can be converted to
to struct xfs_error_injection by removing the depreciated
syntax if so.

On 2016年06月24日 20:22, Dan Carpenter wrote:

Errors go from zero which means no error to XFS_ERRTAG_MAX (22).  My
static checker complains that xfs_errortag_add() puts an upper bound on
this but not a lower bound.  Let's fix it by making it unsigned.

Signed-off-by: Dan Carpenter <>

diff --git a/fs/xfs/xfs_error.h b/fs/xfs/xfs_error.h
index 4ed3042..2e4f67f 100644
--- a/fs/xfs/xfs_error.h
+++ b/fs/xfs/xfs_error.h
@@ -128,7 +128,7 @@ extern int xfs_error_test(int, int *, char *, int, char *, unsigned long);
 	 xfs_error_test((tag), (mp)->m_fixedfsid, "expr", __LINE__, __FILE__, \
-extern int xfs_errortag_add(int error_tag, struct xfs_mount *mp);
+extern int xfs_errortag_add(unsigned int error_tag, struct xfs_mount *mp);
 extern int xfs_errortag_clearall(struct xfs_mount *mp, int loud);
 #define XFS_TEST_ERROR(expr, mp, tag, rf)	(expr)
diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
index 355619a..ed7ee4e 100644
--- a/fs/xfs/xfs_error.c
+++ b/fs/xfs/xfs_error.c
@@ -55,7 +55,7 @@ xfs_error_test(int error_tag, int *fsidp, char *expression,
-xfs_errortag_add(int error_tag, xfs_mount_t *mp)
+xfs_errortag_add(unsigned int error_tag, xfs_mount_t *mp)
 	int i;
 	int len;

xfs mailing list


Jeff Liu

      parent reply	other threads:[~2016-06-24 13:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 12:22 Dan Carpenter
2016-06-24 12:22 ` Dan Carpenter
2016-06-24 13:12 ` Jeff Liu
2016-06-24 13:27   ` Dan Carpenter
2016-06-24 13:27     ` Dan Carpenter
2016-06-24 13:20 ` Jeff Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \
    --subject='Re: [patch] xfs: don'\''t allow negative error tags' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.