From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGRvM-0007kn-W6 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:17:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGRvK-0004b1-KZ for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:17:35 -0400 References: <1466721446-27737-1-git-send-email-eblake@redhat.com> <1466721446-27737-21-git-send-email-eblake@redhat.com> <20160624134548.GC5422@noname.redhat.com> From: Eric Blake Message-ID: <576D40F7.2040504@redhat.com> Date: Fri, 24 Jun 2016 08:17:27 -0600 MIME-Version: 1.0 In-Reply-To: <20160624134548.GC5422@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EvXmfNKTHLbEujSlBDMvWHseKm0Dmh4EG" Subject: Re: [Qemu-devel] [PATCH v3 20/22] block: Move request_alignment into BlockLimit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, famz@redhat.com, stefanha@redhat.com, Max Reitz , Ronnie Sahlberg , Paolo Bonzini , Peter Lieven This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EvXmfNKTHLbEujSlBDMvWHseKm0Dmh4EG From: Eric Blake To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, famz@redhat.com, stefanha@redhat.com, Max Reitz , Ronnie Sahlberg , Paolo Bonzini , Peter Lieven Message-ID: <576D40F7.2040504@redhat.com> Subject: Re: [PATCH v3 20/22] block: Move request_alignment into BlockLimit References: <1466721446-27737-1-git-send-email-eblake@redhat.com> <1466721446-27737-21-git-send-email-eblake@redhat.com> <20160624134548.GC5422@noname.redhat.com> In-Reply-To: <20160624134548.GC5422@noname.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/24/2016 07:45 AM, Kevin Wolf wrote: > Am 24.06.2016 um 00:37 hat Eric Blake geschrieben: >> It makes more sense to have ALL block size limit constraints >> in the same struct. Improve the documentation while at it. >> >> Simplify a couple of conditionals, now that we have audited and >> documented that request_alignment is always non-zero. >=20 > Now you mention in the commit message that request_alignment is always > non-zero and this is supposedly documented... >=20 >> Signed-off-by: Eric Blake >> >=20 >> @@ -324,6 +324,12 @@ struct BlockDriver { >> }; >> >> typedef struct BlockLimits { >> + /* Alignment requirement, in bytes, for offset/length of I/O >> + * requests. Must be a power of 2 less than INT_MAX. A value of 0= >> + * defaults to 1 for drivers with modern byte interfaces, and to >> + * 512 otherwise. */ >> + uint32_t request_alignment; >=20 > ...but you didn't actually change the documentation. Oops. Blame late night patch editing :) >=20 > This is the only problem I saw in this series, so if you post a new > version of the comment, I can change it while applying the series. /* Alignment requirement, in bytes, for offset/length of I/O * requests. Must be a power of 2 less than INT_MAX; defaults to * 1 for drivers with modern byte interfaces, and to 512 * otherwise. */ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EvXmfNKTHLbEujSlBDMvWHseKm0Dmh4EG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbUD3AAoJEKeha0olJ0Nq3IMH/3aK7qlSrBKtxDs/k9Au/llv QKu3Ir4FZsebO9UPgHL+Pp+AUAhB9bYH5RyW7dehWyEphzPo6AAhQ4aFgL0shU8J yQLkjxvhtj7crfZHjTa+3xW9lADEmkIH5gdiO45W6WEFYYjF+jun2k6APPVzIeQx tCIRD4tETGoAt8OZiCPOH+rk0xzw2PrlRzzJER9ujmsB3fx90lNwRMT3CfM75NbD glzxiWKDbe9deSfmgCQN297HiN2nzKBjWAqCZpgDmwfIBZyFFsJfRA2kLZtOBWx0 7jW4LcES511bllHuMBNWr8tbu5vCzLz3Wgzuk3VK8OgfO6wMmVtRxxmMa4mHU4M= =v36H -----END PGP SIGNATURE----- --EvXmfNKTHLbEujSlBDMvWHseKm0Dmh4EG--