From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGSVF-0007ox-5e for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:54:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGSVA-0006XR-5K for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:54:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGSV9-0006XN-T7 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:54:36 -0400 References: <1466777957-5126-1-git-send-email-armbru@redhat.com> <1466777957-5126-2-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <576D49AA.30906@redhat.com> Date: Fri, 24 Jun 2016 08:54:34 -0600 MIME-Version: 1.0 In-Reply-To: <1466777957-5126-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f0GFhCkgcQV3PQUULM3qSqteH9G7SveCP" Subject: Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --f0GFhCkgcQV3PQUULM3qSqteH9G7SveCP From: Eric Blake To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, pbonzini@redhat.com Message-ID: <576D49AA.30906@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers References: <1466777957-5126-1-git-send-email-armbru@redhat.com> <1466777957-5126-2-git-send-email-armbru@redhat.com> In-Reply-To: <1466777957-5126-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/24/2016 08:19 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > Reviewed-by: Peter Maydell Worth mentioning how you found the culprits in the commit message, so that someone could repeat the task when backporting this patch or dealing with future cruft that inevitably creeps back in without an automated checkin validation tool? > +++ b/crypto/pbkdf-nettle.c > @@ -19,9 +19,9 @@ > */ > =20 > #include "qemu/osdep.h" > +#include > #include "qapi/error.h" > #include "crypto/pbkdf.h" > -#include "nettle/pbkdf2.h" You're not just converting <> to "" (when the header is internal) or "" to <> (when the header is 3rd-party), but also rearranging things to put <> before "" (except for osdep.h which must be first). I like that paradigm, but again, might be worth a mention in the commit message as being intentional. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --f0GFhCkgcQV3PQUULM3qSqteH9G7SveCP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbUmqAAoJEKeha0olJ0NqfH0H/17gJr6r22s1IFDgSgThTvB+ EfbXuC8EKBnACJ8T8UqXM/aditltYFcTl3A4j8KLwiQl55p4y0x7jEZV21XvH0mP Z5iXjX9xgYB0e+2N7OeEtzgJYtscnsQv1rnSGBpJa3IdExSCoWRuL5AIujG0sRWz frCacJ2jD/u+KhmEReUvabYc9EPLd3mJn+ufkELrl+Us8D/x6L9uIEF3qJBzuqo9 Swe5tLvd7DDo5/Z383nrLyKJjg+MDgX9yzh2S70tlkzdDpIMWGsnMea3Gncn7r1C L4DQf8pA/fE88Vl7v5lIFhhUUyUr0MbyF+/ZzJUbZDzwRUWVVK3OhWvxelLScb0= =IDiX -----END PGP SIGNATURE----- --f0GFhCkgcQV3PQUULM3qSqteH9G7SveCP--