On 06/24/2016 08:14 AM, Marc-André Lureau wrote: > Hi > > On Fri, Jun 24, 2016 at 6:23 AM, Eric Blake wrote: >>> >>> -static bool invalid_qmp_mode(const Monitor *mon, const mon_cmd_t *cmd, >>> +static bool invalid_qmp_mode(const Monitor *mon, const gchar *cmd, >> >> Why 'gchar'? What's wrong with 'char'? (Some of glib's typedefs make >> sense, but gchar is not one of them) > > just some old habit, fixed. > > ack otherwise? Yes, you can add: Reviewed-by: Eric Blake -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org