From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGSea-0000Pe-7g for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:04:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGSeV-0000iF-Ro for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:04:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGSeV-0000i9-JM for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:04:15 -0400 References: <20160623000809.4522-1-marcandre.lureau@redhat.com> <20160623000809.4522-7-marcandre.lureau@redhat.com> <576CB991.60800@redhat.com> From: Eric Blake Message-ID: <576D4BEE.8040403@redhat.com> Date: Fri, 24 Jun 2016 09:04:14 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NG8OfGRTvaj5EBtGbSRwSH67KkwaQS8t7" Subject: Re: [Qemu-devel] [PATCH 06/12] monitor: remove mhandler.cmd_new List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: QEMU , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NG8OfGRTvaj5EBtGbSRwSH67KkwaQS8t7 From: Eric Blake To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: QEMU , Markus Armbruster Message-ID: <576D4BEE.8040403@redhat.com> Subject: Re: [Qemu-devel] [PATCH 06/12] monitor: remove mhandler.cmd_new References: <20160623000809.4522-1-marcandre.lureau@redhat.com> <20160623000809.4522-7-marcandre.lureau@redhat.com> <576CB991.60800@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/24/2016 08:20 AM, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Fri, Jun 24, 2016 at 6:39 AM, Eric Blake wrote: >> On 06/22/2016 06:08 PM, marcandre.lureau@redhat.com wrote: >>> From: Marc-Andr=C3=A9 Lureau >>> >>> This is no longer necessary, now that middle mode has been removed. >>> >>> Signed-off-by: Marc-Andr=C3=A9 Lureau >>> --- >>> docs/writing-qmp-commands.txt | 8 +- >>> hmp-commands-info.hx | 118 ++++++++++++------------ >>> hmp-commands.hx | 206 +++++++++++++++++++++-----------= ---------- >>> monitor.c | 11 +-- >>> 4 files changed, 168 insertions(+), 175 deletions(-) >> >> The changes to hmp-commands*.hx are mechanical; you may want to set up= >> git to order the diff so that more relevant files like monitor.c are >> listed first. Do that by 'git config diff.orderFile /path/to/file', >> then in that file, listing globs in the order that you want to priorit= ize. >> >=20 > Nice tip, didn't know about it. I wonder if it would be worth to have > one in qemu source tree.. Maybe not: it still requires a local setting to be useful (the file existing in-tree doesn't mean that 'git diff' will automatically know to use it without users editing .git/config); having it version-controlled means that the diff you list now may depend on the version of the file in your tree now rather than the version at the time the patch was first generated for some confusing results; and there are still cases where I personally find that I don't necessarily want the same order as last time (so I'm frequently tweaking my own order file according to the series I'm currently posting). Hmm - maybe it should get a mention on the SubmitAPatch wiki page, though= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NG8OfGRTvaj5EBtGbSRwSH67KkwaQS8t7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbUvuAAoJEKeha0olJ0NqvHQH/0Ltv4/+uGdWROwABn6TR5Xx 2QeKTdaRxf4xiwYF7lsXYjdXxEbgHTIfWH8C9x/7n0MhVt12myT8zfqhmD981uRp fxFw+h9PERkZdUrcMcx+nrzpGd2VTfYEN1UAqcRWailM5K/udWwZfSBESo8hBMrM Rp5+dnQldKh2Xb9ot2gTtMdF2Kij5/3SJJAy98yRLBaVwDSSxJaJS84CULSGP/d6 vUqliE+xdfOjZBZyehxUOxWrNwpaMr7adIAFqsgwP0LX91f1EglKUf7w3B8mtw60 t0Aqavygq+pe2mRRyBnq4ikgQ26PfWOfjfhzJkSS26oBKVz1Jx4ReXWC6a6rdOw= =YCfi -----END PGP SIGNATURE----- --NG8OfGRTvaj5EBtGbSRwSH67KkwaQS8t7--