From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGTD9-0007Z5-45 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGTD3-000246-Tl for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:40:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGTD3-00023u-M2 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:39:57 -0400 References: <1464686130-12265-1-git-send-email-den@openvz.org> <1464686130-12265-9-git-send-email-den@openvz.org> <575F151E.6080608@redhat.com> <576BA89E.3020501@virtuozzo.com> From: Eric Blake Message-ID: <576D544C.9080804@redhat.com> Date: Fri, 24 Jun 2016 09:39:56 -0600 MIME-Version: 1.0 In-Reply-To: <576BA89E.3020501@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d5UKtXT9F6H7XPcdAW8DmqlEGNV7pHdVs" Subject: Re: [Qemu-devel] [PATCH 08/11] drive-backup: added support for data compression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Butsykin , "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Jeff Cody , Markus Armbruster , John Snow , Stefan Hajnoczi , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d5UKtXT9F6H7XPcdAW8DmqlEGNV7pHdVs From: Eric Blake To: Pavel Butsykin , "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Jeff Cody , Markus Armbruster , John Snow , Stefan Hajnoczi , Kevin Wolf Message-ID: <576D544C.9080804@redhat.com> Subject: Re: [PATCH 08/11] drive-backup: added support for data compression References: <1464686130-12265-1-git-send-email-den@openvz.org> <1464686130-12265-9-git-send-email-den@openvz.org> <575F151E.6080608@redhat.com> <576BA89E.3020501@virtuozzo.com> In-Reply-To: <576BA89E.3020501@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/23/2016 03:15 AM, Pavel Butsykin wrote: >>> @@ -3309,6 +3315,7 @@ void qmp_drive_backup(const char *device, const= >>> char *target, >>> bool has_mode, enum NewImageMode mode, >>> bool has_speed, int64_t speed, >>> bool has_bitmap, const char *bitmap, >>> + bool has_compress, bool compress, >>> bool has_on_source_error, BlockdevOnError >>> on_source_error, >>> bool has_on_target_error, BlockdevOnError >>> on_target_error, >>> Error **errp) >> >> Might be nice to simplify this signature once my qapi 'box' patches la= nd. >> >=20 > Yes, it would certainly be better. But your patches are not applied on > the current, maybe you have your own branch? http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi (still undergoing rebases, and I need to address some of Markus' review comments, but it's getting closer and still targetted for inclusion in 2.= 7) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --d5UKtXT9F6H7XPcdAW8DmqlEGNV7pHdVs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXbVRMAAoJEKeha0olJ0NqD/kH+wRy939Nm7zFotI9A29GBmsP 8V0auJA/TtIUoYZtyRMv/ec+yoVS20XEPoOdtr5w0D8wa9o34EIyqjvEO68xcaqs Y1FsA7nEsHXy7Rdf7t/BeTbPz0It4I2rj59RUiqFx7+ez4Aj2eYpP2utZ2K5azo1 712A5qniIZpOEIQjdlOnD6lAze07IDlESyw1J0Y10krOcenWy3rxZylZQE9E8pqa D7rjInCKt5JrClo6YiMsBH9Y7IOTVex2zE34t8cWfX/C5FScqlF9kr7SjN1IfM4b 2FzZDmE6bLELQeDO1ZkPYymgGAibG5f2tvBmpVtIe+H1BeS3kJAX6PXfA1DVDqU= =NXUx -----END PGP SIGNATURE----- --d5UKtXT9F6H7XPcdAW8DmqlEGNV7pHdVs--