From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57076)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbutsykin@virtuozzo.com>) id 1bGTNz-0002ft-3M
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:51:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbutsykin@virtuozzo.com>) id 1bGTNv-0004Sr-Nw
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:51:15 -0400
Received: from mail-am1on0129.outbound.protection.outlook.com
	([157.56.112.129]:46918
	helo=emea01-am1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbutsykin@virtuozzo.com>) id 1bGTNv-0004Sb-3P
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:51:11 -0400
References: <1464686130-12265-1-git-send-email-den@openvz.org>
	<1464686130-12265-9-git-send-email-den@openvz.org>
	<575F151E.6080608@redhat.com> <576BA89E.3020501@virtuozzo.com>
	<576D544C.9080804@redhat.com>
From: Pavel Butsykin <pbutsykin@virtuozzo.com>
Message-ID: <576D56E2.5060101@virtuozzo.com>
Date: Fri, 24 Jun 2016 18:50:58 +0300
MIME-Version: 1.0
In-Reply-To: <576D544C.9080804@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/11] drive-backup: added support for data
 compression
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org
Cc: Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, John Snow <jsnow@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>

On 24.06.2016 18:39, Eric Blake wrote:
> On 06/23/2016 03:15 AM, Pavel Butsykin wrote:
>
>>>> @@ -3309,6 +3315,7 @@ void qmp_drive_backup(const char *device, const
>>>> char *target,
>>>>                          bool has_mode, enum NewImageMode mode,
>>>>                          bool has_speed, int64_t speed,
>>>>                          bool has_bitmap, const char *bitmap,
>>>> +                      bool has_compress, bool compress,
>>>>                          bool has_on_source_error, BlockdevOnError
>>>> on_source_error,
>>>>                          bool has_on_target_error, BlockdevOnError
>>>> on_target_error,
>>>>                          Error **errp)
>>>
>>> Might be nice to simplify this signature once my qapi 'box' patches land.
>>>
>>
>> Yes, it would certainly be better. But your patches are not applied on
>> the current, maybe you have your own branch?
>
> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi (still
> undergoing rebases, and I need to address some of Markus' review
> comments, but it's getting closer and still targetted for inclusion in 2.7)
>
Thank you very much!