From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Date: Thu, 30 Jun 2016 21:48:02 +0800 Message-ID: <57714bed-3f9c-90c2-ac30-2d462d8a06d4@linaro.org> References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> <5351858.jEb0qfTvrF@vostro.rjw.lan> <2f0e60e1-f429-2bd3-5f26-fd6199e64f34@linaro.org> <2435381.sM3CFAEXNR@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2435381.sM3CFAEXNR@vostro.rjw.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "Rafael J. Wysocki" , Catalin Marinas , Will Deacon Cc: "Rafael J. Wysocki" , rruigrok@codeaurora.org, Wim Van Sebroeck , Fu Wei , wei@redhat.com, Al Stone , Timur Tabi , Daniel Lezcano , "linaro-acpi@lists.linaro.org" , ACPI Devel Maling List , Len Brown , harba@codeaurora.org, Arnd Bergmann , Marc Zyngier , Jon Masters , Christopher Covington , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , G Gregory , Linux Kernel Mailing List , Leo Duran , Suravee Suthikulanit List-Id: linux-acpi@vger.kernel.org On 2016/6/30 21:27, Rafael J. Wysocki wrote: > On Thursday, June 30, 2016 10:10:02 AM Hanjun Guo wrote: >> Hi Rafael, >> >> On 2016/6/30 9:37, Rafael J. Wysocki wrote: >>> On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote: >>>> Hi Rafael, >>>> >>>> On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: >>>>> On Wed, Jun 29, 2016 at 8:15 PM, wrote: >>>>>> From: Fu Wei >>>>>> >>>>>> This patchset: >>>>>> (1)Preparation for adding GTDT support in arm_arch_timer >>>>>> 1. Move some enums and marcos to header file >>>>>> 2. Add a new enum for spi type. >>>>>> 3. Improve printk relevant code >>>>>> >>>>>> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c >>>>>> Parse all kinds of timer in GTDT table of ACPI:arch timer, >>>>>> memory-mapped timer and SBSA Generic Watchdog timer. >>>>>> This driver can help to simplify all the relevant timer drivers, >>>>>> and separate all the ACPI GTDT knowledge from them. >>>>>> >>>>>> (3)Simplify ACPI code for arm_arch_timer >>>>>> >>>>>> (4)Add GTDT support for ARM memory-mapped timer >>>>> >>>>> GTDT is ARM-specific AFAICS. >>>> >>>> yes, you are right, it is. >>>> >>>>> >>>>> If so, why do we need that code to reside in drivers/acpi/ ? >>>> >>>> Although the GTDT is just for ARM64, but this driver is parsing one >>>> of ACPI table, >>>> I think that could be treated as ACPI driver. Do I miss something? :-) >>> >>> Yes, you are. Nobody except for ARM64 will ever need it. >> >> GTDT is part of ACPI spec, drivers/acpi/ is for driver code of >> ACPI spec, I think it can stay in drivers/acpi/ from this point >> of view, am I right? > > The question is not "Can it?", but "Does it need to?". > > It is in the spec, but still there's only one architecture needing it. > > There is no way to test it on any other architecture and no reason to build it > for any other architecture, so why does it need to be located in drivers/acpi/ ? I'm fine to move it to other places such as arch/arm64/kernel/, but I would like to ask ARM64 maintainer's suggestion for this. Will, Catalin, what's your opinion on this? Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932283AbcF3N7u (ORCPT ); Thu, 30 Jun 2016 09:59:50 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:35553 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbcF3N4S (ORCPT ); Thu, 30 Jun 2016 09:56:18 -0400 Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer To: "Rafael J. Wysocki" , Catalin Marinas , Will Deacon References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> <5351858.jEb0qfTvrF@vostro.rjw.lan> <2f0e60e1-f429-2bd3-5f26-fd6199e64f34@linaro.org> <2435381.sM3CFAEXNR@vostro.rjw.lan> Cc: Fu Wei , "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , "linux-arm-kernel@lists.infradead.org" , "linaro-acpi@lists.linaro.org" , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, harba@codeaurora.org, Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , wei@redhat.com, Arnd Bergmann , Wim Van Sebroeck , Suravee Suthikulanit , Leo Duran From: Hanjun Guo Message-ID: <57714bed-3f9c-90c2-ac30-2d462d8a06d4@linaro.org> Date: Thu, 30 Jun 2016 21:48:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <2435381.sM3CFAEXNR@vostro.rjw.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/6/30 21:27, Rafael J. Wysocki wrote: > On Thursday, June 30, 2016 10:10:02 AM Hanjun Guo wrote: >> Hi Rafael, >> >> On 2016/6/30 9:37, Rafael J. Wysocki wrote: >>> On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote: >>>> Hi Rafael, >>>> >>>> On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: >>>>> On Wed, Jun 29, 2016 at 8:15 PM, wrote: >>>>>> From: Fu Wei >>>>>> >>>>>> This patchset: >>>>>> (1)Preparation for adding GTDT support in arm_arch_timer >>>>>> 1. Move some enums and marcos to header file >>>>>> 2. Add a new enum for spi type. >>>>>> 3. Improve printk relevant code >>>>>> >>>>>> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c >>>>>> Parse all kinds of timer in GTDT table of ACPI:arch timer, >>>>>> memory-mapped timer and SBSA Generic Watchdog timer. >>>>>> This driver can help to simplify all the relevant timer drivers, >>>>>> and separate all the ACPI GTDT knowledge from them. >>>>>> >>>>>> (3)Simplify ACPI code for arm_arch_timer >>>>>> >>>>>> (4)Add GTDT support for ARM memory-mapped timer >>>>> >>>>> GTDT is ARM-specific AFAICS. >>>> >>>> yes, you are right, it is. >>>> >>>>> >>>>> If so, why do we need that code to reside in drivers/acpi/ ? >>>> >>>> Although the GTDT is just for ARM64, but this driver is parsing one >>>> of ACPI table, >>>> I think that could be treated as ACPI driver. Do I miss something? :-) >>> >>> Yes, you are. Nobody except for ARM64 will ever need it. >> >> GTDT is part of ACPI spec, drivers/acpi/ is for driver code of >> ACPI spec, I think it can stay in drivers/acpi/ from this point >> of view, am I right? > > The question is not "Can it?", but "Does it need to?". > > It is in the spec, but still there's only one architecture needing it. > > There is no way to test it on any other architecture and no reason to build it > for any other architecture, so why does it need to be located in drivers/acpi/ ? I'm fine to move it to other places such as arch/arm64/kernel/, but I would like to ask ARM64 maintainer's suggestion for this. Will, Catalin, what's your opinion on this? Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Thu, 30 Jun 2016 21:48:02 +0800 Subject: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer In-Reply-To: <2435381.sM3CFAEXNR@vostro.rjw.lan> References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> <5351858.jEb0qfTvrF@vostro.rjw.lan> <2f0e60e1-f429-2bd3-5f26-fd6199e64f34@linaro.org> <2435381.sM3CFAEXNR@vostro.rjw.lan> Message-ID: <57714bed-3f9c-90c2-ac30-2d462d8a06d4@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/6/30 21:27, Rafael J. Wysocki wrote: > On Thursday, June 30, 2016 10:10:02 AM Hanjun Guo wrote: >> Hi Rafael, >> >> On 2016/6/30 9:37, Rafael J. Wysocki wrote: >>> On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote: >>>> Hi Rafael, >>>> >>>> On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: >>>>> On Wed, Jun 29, 2016 at 8:15 PM, wrote: >>>>>> From: Fu Wei >>>>>> >>>>>> This patchset: >>>>>> (1)Preparation for adding GTDT support in arm_arch_timer >>>>>> 1. Move some enums and marcos to header file >>>>>> 2. Add a new enum for spi type. >>>>>> 3. Improve printk relevant code >>>>>> >>>>>> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c >>>>>> Parse all kinds of timer in GTDT table of ACPI:arch timer, >>>>>> memory-mapped timer and SBSA Generic Watchdog timer. >>>>>> This driver can help to simplify all the relevant timer drivers, >>>>>> and separate all the ACPI GTDT knowledge from them. >>>>>> >>>>>> (3)Simplify ACPI code for arm_arch_timer >>>>>> >>>>>> (4)Add GTDT support for ARM memory-mapped timer >>>>> >>>>> GTDT is ARM-specific AFAICS. >>>> >>>> yes, you are right, it is. >>>> >>>>> >>>>> If so, why do we need that code to reside in drivers/acpi/ ? >>>> >>>> Although the GTDT is just for ARM64, but this driver is parsing one >>>> of ACPI table, >>>> I think that could be treated as ACPI driver. Do I miss something? :-) >>> >>> Yes, you are. Nobody except for ARM64 will ever need it. >> >> GTDT is part of ACPI spec, drivers/acpi/ is for driver code of >> ACPI spec, I think it can stay in drivers/acpi/ from this point >> of view, am I right? > > The question is not "Can it?", but "Does it need to?". > > It is in the spec, but still there's only one architecture needing it. > > There is no way to test it on any other architecture and no reason to build it > for any other architecture, so why does it need to be located in drivers/acpi/ ? I'm fine to move it to other places such as arch/arm64/kernel/, but I would like to ask ARM64 maintainer's suggestion for this. Will, Catalin, what's your opinion on this? Thanks Hanjun