From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHqxR-0003zY-Oo for qemu-devel@nongnu.org; Tue, 28 Jun 2016 07:13:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHqxN-0000OS-Mq for qemu-devel@nongnu.org; Tue, 28 Jun 2016 07:13:33 -0400 Received: from [59.151.112.132] (port=11966 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHqxM-0000MC-PX for qemu-devel@nongnu.org; Tue, 28 Jun 2016 07:13:29 -0400 References: <1466403224-16604-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Cao jin Message-ID: <57725D43.1030107@cn.fujitsu.com> Date: Tue, 28 Jun 2016 19:19:31 +0800 MIME-Version: 1.0 In-Reply-To: <1466403224-16604-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 00/13] Add param Error ** for msi_init()--part2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Markus Armbruster , Marcel Apfelbaum , Alex Williamson , Hannes Reinecke , Dmitry Fleytman , Paolo Bonzini , John Snow , Gerd Hoffmann ping On 06/20/2016 02:13 PM, Cao jin wrote: > rebased against upstream, and passed make check. > > changelog: > 1. vmw_pvscsi: for compatibility, leave the field msi_used alone. > 2. since patch "msi_init: change return value to 0 on success" has been adopted > first, the patch "megasas: Fix check for msi_init() failure" isn't necessary > anymore, so drop it. > 3. fix failure of make check. It is actually not a bug, test case > "/ahci/hba_spec" always think the 1st capability pointed by Capabilities > pointer should be MSI, and the patch changed the order of adding capability. > Since we don`t pass a error object to msi_init() in ich9ahci and return on > its error, also and PCIDeviceClass->exit function is enough to free all the > resource even if .realize() returns on msi_init() failure, so, revert to the > position where we added msi capability to make "make check" happy. > > cc: Gerd Hoffmann > cc: John Snow > cc: Dmitry Fleytman > cc: Jason Wang > cc: Michael S. Tsirkin > cc: Hannes Reinecke > cc: Paolo Bonzini > cc: Alex Williamson > cc: Markus Armbruster > cc: Marcel Apfelbaum > > Cao jin (13): > change pvscsi_init_msi() type to void > mptsas: change .realize function name > usb xhci: change msi/msix property type > intel-hda: change msi property type > mptsas: change msi property type > megasas: change msi/msix property type > pci bridge dev: change msi property type > pci: Convert msi_init() to Error and fix callers to check it > megasas: remove unnecessary megasas_use_msi() > mptsas: remove unnecessary internal msi state flag > vmxnet3: remove unnecessary internal msi state flag > e1000e: remove unnecessary internal msi state flag > vmw_pvscsi: remove unnecessary internal msi state flag > > hw/audio/intel-hda.c | 29 +++++++++++++++---- > hw/ide/ich.c | 7 +++-- > hw/net/e1000e.c | 37 +++++------------------- > hw/net/vmxnet3.c | 52 +++++++++++---------------------- > hw/pci-bridge/ioh3420.c | 6 +++- > hw/pci-bridge/pci_bridge_dev.c | 31 ++++++++++++++------ > hw/pci-bridge/xio3130_downstream.c | 6 +++- > hw/pci-bridge/xio3130_upstream.c | 6 +++- > hw/pci/msi.c | 11 +++++-- > hw/scsi/megasas.c | 59 ++++++++++++++++++++------------------ > hw/scsi/mptsas.c | 40 +++++++++++++++++--------- > hw/scsi/mptsas.h | 5 ++-- > hw/scsi/vmw_pvscsi.c | 15 ++++------ > hw/usb/hcd-xhci.c | 35 ++++++++++++++++------ > hw/vfio/pci.c | 7 +++-- > include/hw/pci/msi.h | 3 +- > 16 files changed, 194 insertions(+), 155 deletions(-) > -- Yours Sincerely, Cao jin