From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 04/11] drm/i915: Support for GuC interrupts Date: Tue, 28 Jun 2016 14:44:54 +0100 Message-ID: <57727F56.6040706@linux.intel.com> References: <1467029818-3417-1-git-send-email-akash.goel@intel.com> <1467029818-3417-5-git-send-email-akash.goel@intel.com> <57724B70.4010303@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id C2BE86E01B for ; Tue, 28 Jun 2016 13:45:21 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Goel, Akash" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI4LzA2LzE2IDEyOjEyLCBHb2VsLCBBa2FzaCB3cm90ZToKPgo+Cj4gT24gNi8yOC8yMDE2 IDM6MzMgUE0sIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Pgo+PiBPbiAyNy8wNi8xNiAxMzoxNiwg YWthc2guZ29lbEBpbnRlbC5jb20gd3JvdGU6Cj4+PiBGcm9tOiBTYWdhciBBcnVuIEthbWJsZSA8 c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+Pj4KPj4+IFRoZXJlIGFyZSBjZXJ0YWluIHR5cGVz IG9mIGludGVycnVwdHMgd2hpY2ggSG9zdCBjYW4gcmVjaWV2ZSBmcm9tIEd1Qy4KPj4+IEd1QyB1 a2VybmVsIHNlbmRzIGFuIGludGVycnVwdCB0byBIb3N0IGZvciBjZXJ0YWluIGV2ZW50cywgbGlr ZSBmb3IKPj4+IGV4YW1wbGUgcmV0cmlldmUvY29uc3VtZSB0aGUgbG9ncyBnZW5lcmF0ZWQgYnkg dWtlcm5lbC4KPj4+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IHRvIHJlY2VpdmUgaW50ZXJydXB0 cyBmcm9tIEd1QyBidXQgY3VycmVudGx5Cj4+PiBlbmFibGVzICYgcGFydGlhbGx5IGhhbmRsZXMg b25seSB0aGUgaW50ZXJydXB0IHNlbnQgYnkgR3VDIHVrZXJuZWwuCj4+PiBGdXR1cmUgcGF0Y2hl cyB3aWxsIGFkZCBzdXBwb3J0IGZvciBoYW5kbGluZyBvdGhlciBpbnRlcnJ1cHQgdHlwZXMuCj4+ Pgo+Pj4gdjI6IFVzZSBjb21tb24gbG93IGxldmVsIHJvdXRpbmVzIGZvciBQTSBJRVIvSUlSIHBy b2dyYW1taW5nIChDaHJpcykKPj4+ICAgICAgUmVuYW1lIGludGVycnVwdCBmdW5jdGlvbnMgdG8g Z2VuOV94eHggZnJvbSBnZW44X3h4eCAoQ2hyaXMpCj4+PiAgICAgIFJlcGxhY2UgZGlzYWJsaW5n IG9mIHdha2UgcmVmIGFzc2VydHMgd2l0aCBycG0gZ2V0L3B1dCAoQ2hyaXMpCj4+Pgo+Pj4gU2ln bmVkLW9mZi1ieTogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4K Pj4+IFNpZ25lZC1vZmYtYnk6IEFrYXNoIEdvZWwgPGFrYXNoLmdvZWxAaW50ZWwuY29tPgo+Pj4g LS0tCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAgICB8ICAx ICsKPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgIDUg KysKPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyAgICAgICAgICAgIHwgOTUK Pj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3JlZy5oICAgICAgICAgICAgfCAxMSArKysrCj4+PiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oICAgICAgICAgICB8ICAzICsKPj4+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZ3VjLmggICAgICAgICAgIHwgIDUgKysKPj4+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jICAgIHwgIDQgKysKPj4+ICAgNyBmaWxlcyBjaGFuZ2Vk LCAxMjAgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPj4+Pj4KPj4+ICtzdGF0aWMgdm9p ZCBnZW45X2d1YzJob3N0X2V2ZW50c193b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPj4+ ICt7Cj4+PiArICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9Cj4+PiArICAg ICAgICBjb250YWluZXJfb2Yod29yaywgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUsIGd1Yy5ldmVu dHNfd29yayk7Cj4+PiArCj4+PiArICAgIHNwaW5fbG9ja19pcnEoJmRldl9wcml2LT5pcnFfbG9j ayk7Cj4+PiArICAgIC8qIFNwZWVkIHVwIHdvcmsgY2FuY2VsYXRpb24gZHVyaW5nIGRpc2FibGlu ZyBndWMgaW50ZXJydXB0cy4gKi8KPj4+ICsgICAgaWYgKCFkZXZfcHJpdi0+Z3VjLmludGVycnVw dHNfZW5hYmxlZCkgewo+Pj4gKyAgICAgICAgc3Bpbl91bmxvY2tfaXJxKCZkZXZfcHJpdi0+aXJx X2xvY2spOwo+Pj4gKyAgICAgICAgcmV0dXJuOwo+Pj4gKyAgICB9Cj4+PiArCj4+PiArICAgIC8q IFRob3VnaCB0aGlzIHdvcmsgaXRlbSBnZXRzIHN5bmNlZCBkdXJpbmcgcnBtIHN1c3BlbmQsIGJ1 dAo+Pj4gc3RpbGwgbmVlZAo+Pj4gKyAgICAgKiBhIHJwbSBnZXQvcHV0IHRvIGF2b2lkIHRoZSB3 YXJuaW5nLCBhcyBpdCBjb3VsZCBnZXQgZXhlY3V0ZWQKPj4+IGluIGEKPj4+ICsgICAgICogd2lu ZG93LCB3aGVyZSBycG0gcmVmIGNvdW50IGhhcyBkcm9wcGVkIHRvIHplcm8gYnV0IHJwbQo+Pj4g c3VzcGVuZCBoYXMKPj4+ICsgICAgICogbm90IGtpY2tlZCBpbi4gR2VuZXJhbGx5IGRldmljZSBp cyBleHBlY3RlZCB0byBiZSBhY3RpdmUgb25seQo+Pj4gYXQgdGhpcwo+Pj4gKyAgICAgKiB0aW1l IHNvIGdldC9wdXQgc2hvdWxkIGJlIHJlYWxseSBxdWljay4KPj4+ICsgICAgICovCj4+PiArICAg IGludGVsX3J1bnRpbWVfcG1fZ2V0KGRldl9wcml2KTsKPj4+ICsKPj4+ICsgICAgZ2VuNl9lbmFi bGVfcG1faXJxKGRldl9wcml2LCBHRU45X0dVQ19UT19IT1NUX0lOVF9FVkVOVCk7Cj4+PiArICAg IHNwaW5fdW5sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPj4+ICsKPj4+ICsgICAgLyog VE9ETzogSGFuZGxlIHRoZSBldmVudHMgZm9yIHdoaWNoIEd1QyBpbnRlcnJ1cHRlZCBob3N0ICov Cj4+PiArCj4+PiArICAgIGludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPj4+ICt9Cj4+ Pgo+Pj4gICAvKioKPj4+ICAgICogaXZ5YnJpZGdlX3Bhcml0eV93b3JrIC0gV29ya3F1ZXVlIGNh bGxlZCB3aGVuIGEgcGFyaXR5IGVycm9yCj4+PiBpbnRlcnJ1cHQKPj4+IEBAIC0xMzcxLDExICsx NDM1LDEzIEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBnZW44X2d0X2lycV9hY2soc3RydWN0Cj4+PiBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4+ICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJU aGUgbWFzdGVyIGNvbnRyb2wgaW50ZXJydXB0IGxpZWQgKEdUMykhXG4iKTsKPj4+ICAgICAgIH0K Pj4+Cj4+PiAtICAgIGlmIChtYXN0ZXJfY3RsICYgR0VOOF9HVF9QTV9JUlEpIHsKPj4+ICsgICAg aWYgKG1hc3Rlcl9jdGwgJiAoR0VOOF9HVF9QTV9JUlEgfCBHRU44X0dUX0dVQ19JUlEpKSB7Cj4+ PiAgICAgICAgICAgZ3RfaWlyWzJdID0gSTkxNV9SRUFEX0ZXKEdFTjhfR1RfSUlSKDIpKTsKPj4+ IC0gICAgICAgIGlmIChndF9paXJbMl0gJiBkZXZfcHJpdi0+cG1fcnBzX2V2ZW50cykgewo+Pj4g KyAgICAgICAgaWYgKGd0X2lpclsyXSAmIChkZXZfcHJpdi0+cG1fcnBzX2V2ZW50cyB8Cj4+PiAr ICAgICAgICAgICAgICAgICBkZXZfcHJpdi0+Z3VjX2V2ZW50cykpIHsKPj4+ICAgICAgICAgICAg ICAgSTkxNV9XUklURV9GVyhHRU44X0dUX0lJUigyKSwKPj4+IC0gICAgICAgICAgICAgICAgICAg ICAgZ3RfaWlyWzJdICYgZGV2X3ByaXYtPnBtX3Jwc19ldmVudHMpOwo+Pj4gKyAgICAgICAgICAg ICAgICAgICAgICBndF9paXJbMl0gJiAoZGV2X3ByaXYtPnBtX3Jwc19ldmVudHMgfAo+Pj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgIGRldl9wcml2LT5ndWNfZXZlbnRzKSk7Cj4+PiAgICAg ICAgICAgICAgIHJldCA9IElSUV9IQU5ETEVEOwo+Pj4gICAgICAgICAgIH0gZWxzZQo+Pj4gICAg ICAgICAgICAgICBEUk1fRVJST1IoIlRoZSBtYXN0ZXIgY29udHJvbCBpbnRlcnJ1cHQgbGllZCAo UE0pIVxuIik7Cj4+PiBAQCAtMTQwNyw2ICsxNDczLDkgQEAgc3RhdGljIHZvaWQgZ2VuOF9ndF9p cnFfaGFuZGxlcihzdHJ1Y3QKPj4+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+Pj4KPj4+ ICAgICAgIGlmIChndF9paXJbMl0gJiBkZXZfcHJpdi0+cG1fcnBzX2V2ZW50cykKPj4+ICAgICAg ICAgICBnZW42X3Jwc19pcnFfaGFuZGxlcihkZXZfcHJpdiwgZ3RfaWlyWzJdKTsKPj4+ICsKPj4+ ICsgICAgaWYgKGd0X2lpclsyXSAmIGRldl9wcml2LT5ndWNfZXZlbnRzKQo+Pj4gKyAgICAgICAg Z2VuOV9ndWNfaXJxX2hhbmRsZXIoZGV2X3ByaXYsIGd0X2lpclsyXSk7Cj4+PiAgIH0KPj4+Cj4+ PiAgIHN0YXRpYyBib29sIGJ4dF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QoZW51bSBwb3J0IHBv cnQsIHUzMiB2YWwpCj4+PiBAQCAtMTY1Myw2ICsxNzIyLDIwIEBAIHN0YXRpYyB2b2lkIGdlbjZf cnBzX2lycV9oYW5kbGVyKHN0cnVjdAo+Pj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUz MiBwbV9paXIpCj4+PiAgICAgICB9Cj4+PiAgIH0KPj4+Cj4+PiArc3RhdGljIHZvaWQgZ2VuOV9n dWNfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+Pj4gdTMy IGd0X2lpcikKPj4+ICt7Cj4+PiArICAgIGlmIChndF9paXIgJiBHRU45X0dVQ19UT19IT1NUX0lO VF9FVkVOVCkgewo+Pj4gKyAgICAgICAgc3Bpbl9sb2NrKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+ Pj4gKyAgICAgICAgaWYgKGRldl9wcml2LT5ndWMuaW50ZXJydXB0c19lbmFibGVkKSB7Cj4+Cj4+ IFNvIGl0IGlzIGV4cGVjdGVkIGludGVycnVwdHMgd2lsbCBhbHdheXMgYmUgZW5hYmxlZCB3aGVu Cj4+IGk5MTUuZ3VjX2xvZ19sZXZlbCBpcyBzZXQsIGNvcnJlY3Q/Cj4+Cj4gWWVzIGN1cnJlbnRs eSBvbmx5IHdoZW4gZ3VjX2xvZ19sZXZlbCA+IDAsIGludGVycnVwdCBzaG91bGQgYmUgZW5hYmxl ZC4KPgo+IEJ1dCB3ZSBuZWVkIHRvIGRpc2FibGUvZW5hYmxlIHRoZSBpbnRlcnJ1cHQgdXBvbiBz dXNwZW5kL3Jlc3VtZSBhbmQKPiBhY3Jvc3MgR1BVIHJlc2V0Lgo+IFNvIGludGVycnVwdCBtYXkg bm90IGJlIGFsd2F5cyBpbiBhIGVuYWJsZWQgc3RhdGUgd2hlbiBndWNfbG9nX2xldmVsPjAuCj4K Pj4gQWxzbyBkbyB5b3UgbmVlZCB0byBjaGVjayBhZ2FpbnN0IGRldl9wcml2LT5ndWMuaW50ZXJy dXB0c19lbmFibGVkIGF0Cj4+IGFsbCB0aGVuPyBPciBmcm9tIGFuIG9wcG9zaXRlIGFuZ2xlLCB3 b3VsZCB5b3UgaW5zdGVhZCBuZWVkIHRvIGxvZyB0aGUKPj4gZmFjdCB1bmV4cGVjdGVkIGludGVy cnVwdCB3YXMgcmVjZWl2ZWQgaGVyZT8KPgo+IEkgdGhpbmsgdGhpcyBjaGVjayBpcyBuZWVkZWQs IHRvIGF2b2lkIHRoZSByYWNlIGluIGRpc2FibGluZyBpbnRlcnJ1cHQuCj4gUGxlYXNlIHJlZmVy IHRoZSBzZXF1ZW5jZSBpbiBpbnRlcnJ1cHQgZGlzYWJsaW5nIGZ1bmN0aW9uIChzYW1lIGFzIHJw cwo+IGRpc2FibGluZyksIHRoZXJlIHdlIGZpcnN0IHNldCB0aGUgaW50ZXJydXB0c19lbmFibGVk IGZsYWcgdG8gZmFsc2UsCj4gdGhlbiB3YWl0IGZvciB0aGUgd29yayBpdGVtIHRvIGZpbmlzaCBl eGVjdXRpb24gYW5kIHRoZW4gcHJvZ3JhbSB0aGUgSU1SCj4gcmVnaXN0ZXIuCgpSaWdodCBJIHNl ZSBub3cgdGhhdCBpdCBpcyBjb3B5LXBhc3RlZCBleGlzdGluZyBzZXF1ZW5jZS4gSW4gdGhpcyBj YXNlIEkgCndvbid0IHF1ZXN0aW9uIGl0IGZ1cnRoZXIuIDopCgo+Pgo+Pj4gKyAgICAgICAgICAg IC8qIFByb2Nlc3MgYWxsIHRoZSBHdUMgdG8gSG9zdCBldmVudHMgaW4gYm90dG9tIGhhbGYgKi8K Pj4+ICsgICAgICAgICAgICBnZW42X2Rpc2FibGVfcG1faXJxKGRldl9wcml2LAo+Pj4gKyAgICAg ICAgICAgICAgICBHRU45X0dVQ19UT19IT1NUX0lOVF9FVkVOVCk7Cj4+Cj4+IFdoeSBpdCBpcyBp bXBvcnRhbnQgdG8gZGlzYWJsZSB0aGUgaW50ZXJydXB0IGhlcmU/IE5vdCBmb3IgdGhlIHF1ZXVl Cj4+IHdvcmsgSSB0aGluay4KPgo+IFdlIHdhbnQgdG8gJiBjYW4gaGFuZGxlIG9uZSBpbnRlcnJ1 cHQgYXQgYSB0aW1lLCB1bmxlc3MgdGhlIHF1ZXVlZCB3b3JrCj4gaXRlbSBpcyBleGVjdXRlZCB3 ZSBjYW4ndCBwcm9jZXNzIHRoZSBuZXh0IGludGVycnVwdCwgc28gYmV0dGVyIHRvIGtlZXAKPiB0 aGUgaW50ZXJydXB0IG1hc2tlZC4KPiBTb3JyeSB0aGlzIGlzIHdoYXQgaXMgbXkgdW5kZXJzdGFu ZGluZy4KClNvIGl0IGlzIHF1ZXVlZCBpbiBoYXJkd2FyZSBhbmQgd2lsbCBnZXQgYXNzZXJ0ZWQg d2hlbiB1bm1hc2tlZD8KCj4KPj4KPj4gQWxzbywgaXMgaXQgc2FmZSB3aXRoIHJlZ2FyZHMgdG8g cG90ZW50aWFsbHkgbG9zaW5nIHRoZSBpbnRlcnJ1cHQ/Cj4+Cj4gUGFydGljdWxhcmx5IGZvciB0 aGUgRkxVU0hfTE9HX0JVRkZFUiBjYXNlLCBHdUMgd29uJ3Qgc2VuZCBhIG5ldyBmbHVzaAo+IGlu dGVycnVwdCB1bmxlc3MgaXRzIGdldHMgYW4gYWNrbm93bGVkZ2VtZW50IChmbHVzaCBzaWduYWwp IG9mIHRoZQo+IHByZXZpb3VzIG9uZSBmcm9tIEhvc3QuCgpBaCBzbyB0aGUgcHJldmlvdXMgY29t bWVudCBpcyByZWFsbHkgaW1wb3NzaWJsZT8gSSBtZWFuIHRoZSBuZWVkIHRvIG1hc2s/CgpQb3Nz aWJseSBqdXN0IHB1dCBhIGNvbW1lbnQgdXAgdGhlcmUgZXhwbGFpbmluZyB0aGF0LgoKPgo+Pj4g KyAgICAgICAgICAgIHF1ZXVlX3dvcmsoZGV2X3ByaXYtPndxLCAmZGV2X3ByaXYtPmd1Yy5ldmVu dHNfd29yayk7Cj4+Cj4+IEJlY2F1c2UgZGV2X3ByaXYtPndxIGlzIGEgb25lIGEgdGltZSBpbiBv cmRlciB3cSBzbyBpZiBzb21ldGhpbmcgZWxzZSBpcwo+PiBydW5uaW5nIG9uIGl0IGFuZCB0YWtp bmcgdGltZSwgY2FuIHRoYXQgYWxzbyBiZSBhIGNhdXNlIG9mIGRyb3BwaW5nIGFuCj4+IGludGVy cnVwdCBvciBiZWluZyBsYXRlIHdpdGggc2VuZGluZyB0aGUgZmx1c2ggc2lnbmFsIHRvIHRoZSBn dWMgYW5kIHNvCj4+IGxvc2luZyBzb21lIGxvZ3M/Cj4KPiBJdHMgYSBEcml2ZXIncyBwcml2YXRl IHdvcmtxdWV1ZSBhbmQgVHVyYm8gd29yayBpdGVtIGlzIGFsc28gcXVldWVkCj4gaW5zaWRlIHRo aXMgd29ya3F1ZXVlIHdoaWNoIHRvbyBuZWVkcyB0byBiZSBleGVjdXRlZCB3aXRob3V0IG11Y2gg ZGVsYXkuCj4gQnV0IHllcyB0aGUgZmx1c2ggd29yayBpdGVtIGNhbiBnZXQgc3Vic3RhbnRpYWxs eSBkZWxheWVkIGluIGNhc2UgaWYKPiB0aGVyZSBhcmUgb3RoZXIgd29yayBpdGVtcyBxdWV1ZWQg YmVmb3JlIGl0LCBlc3BlY2lhbGx5IHRoZQo+IG1tLnJldGlyZV93b3JrIChidXQgZ2VuZXJhbGx5 IGV4ZWN1dGVzIGV2ZXJ5IH4xIHNlY29uZCkuCj4KPiBCZXN0IHdvdWxkIGJlIGlmIHRoZSBsb2cg YnVmZmVyICg0NEtCIGRhdGEpIGNhbiBiZSBzYW1wbGVkIGluIElSUQo+IGNvbnRleHQgKG9yIFRh c2tsZXQgY29udGV4dCkgaXRzZWxmLgoKSSB3YXMganVzdCB0cnlpbmcgdG8gdW5kZXJzdGFuZCBp ZiB5b3UgcGVyaGFwcyBuZWVkIGEgZGVkaWNhdGVkIHdxLiBJIApkb24ndCBoYXZlIGEgZmVlbCBh dCBhbGwgb24gaG93IG11Y2ggZGF0YSBndWMgbG9nZ2luZyBnZW5lcmF0ZXMgcGVyIApzZWNvbmQu IElmIHRoZSBpbnRlcnJ1cHQgaXMgbG93IGZyZXF1ZW5jeSBldmVuIHdpdGggYSBsb3Qgb2YgY21k IApzdWJtaXNzaW9uIGhhcHBlbmluZyBpdCBjb3VsZCBiZSBmaW5lIGxpa2UgaXQgaXMuCgpSZWdh cmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=