From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
David Vrabel <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <JGross@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init()
Date: Wed, 29 Jun 2016 13:42:33 +0100 [thread overview]
Message-ID: <5773C239.1040005@citrix.com> (raw)
In-Reply-To: <5770F0CF02000078000F8DD3@prv-mh.provo.novell.com>
On 27/06/16 08:24, Jan Beulich wrote:
>>>> On 24.06.16 at 17:01, <david.vrabel@citrix.com> wrote:
>> On 07/06/16 07:31, Jan Beulich wrote:
>>> - drop unused function parameter of read_dev_bar()
>>> - drop rom_init() (now identical to bar_init())
>>> - fold read_dev_bar() into its now single caller
>>> - simplify determination of 64-bit memory resource
>>> - use const and unsigned
>>
>> Please split this in 5 separate patches for easier review.
>>
>> Especially as often anyone writing "simplify" means "accidentally break".
>
> So this is directly opposite of what Boris had asked for - originally
> there were two patches, which I folded upon his request (and
> which he gave his R-b for already). May I ask the two of you to
> first settle on a consistent set of expectations to patches like this?
SubmittingPatches section 3 is clear on what is required.
If your commit message is a list of bullet points it's a pretty big hint
that none of the changes are related.
David
next prev parent reply other threads:[~2016-06-29 12:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 6:27 [PATCH v2 0/2] xen-pciback: correct and clean up BAR handling Jan Beulich
2016-06-07 6:30 ` [PATCH v2 1/2] xen-pciback: return proper values during BAR sizing Jan Beulich
2016-06-07 6:30 ` Jan Beulich
2016-06-07 14:06 ` Boris Ostrovsky
2016-06-07 14:06 ` Boris Ostrovsky
2016-06-07 14:14 ` Jan Beulich
2016-06-07 14:14 ` Jan Beulich
2016-06-24 9:13 ` [PATCH v3 " Jan Beulich
2016-06-24 14:08 ` David Vrabel
2016-06-24 14:08 ` [Xen-devel] " David Vrabel
2016-06-24 9:13 ` Jan Beulich
2016-06-07 6:31 ` [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() Jan Beulich
2016-06-07 6:31 ` Jan Beulich
2016-06-07 14:06 ` Boris Ostrovsky
2016-06-07 14:06 ` [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init() Boris Ostrovsky
2016-06-24 15:01 ` [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() David Vrabel
2016-06-27 7:24 ` Jan Beulich
2016-06-29 12:42 ` David Vrabel [this message]
2016-06-29 12:42 ` [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init() David Vrabel
2016-06-27 7:24 ` Jan Beulich
2016-06-24 15:01 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5773C239.1040005@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.