From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbcF3BvO (ORCPT ); Wed, 29 Jun 2016 21:51:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55039 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650AbcF3BvL (ORCPT ); Wed, 29 Jun 2016 21:51:11 -0400 Subject: Re: [PATCH net-next V2] tun: introduce tx skb ring To: "Michael S. Tsirkin" References: <1465979897-4445-1-git-send-email-jasowang@redhat.com> <20160617033218-mutt-send-email-mst@redhat.com> <20160622211620-mutt-send-email-mst@redhat.com> <576B701F.2020105@redhat.com> <20160628100907-mutt-send-email-mst@redhat.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, davem@davemloft.net, eric.dumazet@gmail.com, brouer@redhat.com From: Jason Wang Message-ID: <57747AEC.8050307@redhat.com> Date: Thu, 30 Jun 2016 09:50:36 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160628100907-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 30 Jun 2016 01:50:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年06月28日 15:09, Michael S. Tsirkin wrote: > On Thu, Jun 23, 2016 at 01:14:07PM +0800, Jason Wang wrote: >> >> On 2016年06月23日 02:18, Michael S. Tsirkin wrote: >>> On Fri, Jun 17, 2016 at 03:41:20AM +0300, Michael S. Tsirkin wrote: >>>>> Would it help to have ptr_ring_resize that gets an array of >>>>> rings and resizes them both to same length? >>> OK, here it is. Untested so far, and no skb wrapper. >>> Pls let me know whether this is what you had in mind. >> Exactly what I want. >> >> Thanks > Ok and this for skb_array > > --> > skb_array: add wrappers for resizing > > Signed-off-by: Michael S. Tsirkin > > -- > > diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h > index c900708..7e01c1f 100644 > --- a/include/linux/skb_array.h > +++ b/include/linux/skb_array.h > @@ -151,16 +151,24 @@ static inline int skb_array_init(struct skb_array *a, int size, gfp_t gfp) > return ptr_ring_init(&a->ring, size, 0, gfp); > } > > -void __skb_array_destroy_skb(void *ptr) > +static void __skb_array_destroy_skb(void *ptr) > { > kfree_skb(ptr); > } > > -int skb_array_resize(struct skb_array *a, int size, gfp_t gfp) > +static inline int skb_array_resize(struct skb_array *a, int size, gfp_t gfp) > { > return ptr_ring_resize(&a->ring, size, gfp, __skb_array_destroy_skb); > } Will split up the above tweak into another patch when reposting. > > +static inline int skb_raay_resize_multiple(struct skb_array **rings, int nrings, I think you mean 'skb_array_resize' here. > + int size, gfp_t gfp) > +{ > + BUILD_BUG_ON(offsetof(struct skb_array, ring)); > + ptr_ring_resize_multiple((struct ptr_ring **)rings, nrings, size, gfp, > + __skb_array_destroy_skb); This should be return ptr_ring_resize_multiple(... > +} > + > static inline void skb_array_cleanup(struct skb_array *a) > { > ptr_ring_cleanup(&a->ring, __skb_array_destroy_skb); With this, looks like there's no need for a new flag. Will repost the series with those two patches. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net-next V2] tun: introduce tx skb ring Date: Thu, 30 Jun 2016 09:50:36 +0800 Message-ID: <57747AEC.8050307@redhat.com> References: <1465979897-4445-1-git-send-email-jasowang@redhat.com> <20160617033218-mutt-send-email-mst@redhat.com> <20160622211620-mutt-send-email-mst@redhat.com> <576B701F.2020105@redhat.com> <20160628100907-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Cc: kvm@vger.kernel.org, eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, brouer@redhat.com, davem@davemloft.net To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20160628100907-mutt-send-email-mst@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org CgpPbiAyMDE25bm0MDbmnIgyOOaXpSAxNTowOSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3RlOgo+ IE9uIFRodSwgSnVuIDIzLCAyMDE2IGF0IDAxOjE0OjA3UE0gKzA4MDAsIEphc29uIFdhbmcgd3Jv dGU6Cj4+Cj4+IE9uIDIwMTblubQwNuaciDIz5pelIDAyOjE4LCBNaWNoYWVsIFMuIFRzaXJraW4g d3JvdGU6Cj4+PiBPbiBGcmksIEp1biAxNywgMjAxNiBhdCAwMzo0MToyMEFNICswMzAwLCBNaWNo YWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4+Pj4+IFdvdWxkIGl0IGhlbHAgdG8gaGF2ZSBwdHJfcmlu Z19yZXNpemUgdGhhdCBnZXRzIGFuIGFycmF5IG9mCj4+Pj4+IHJpbmdzIGFuZCByZXNpemVzIHRo ZW0gYm90aCB0byBzYW1lIGxlbmd0aD8KPj4+IE9LLCBoZXJlIGl0IGlzLiBVbnRlc3RlZCBzbyBm YXIsIGFuZCBubyBza2Igd3JhcHBlci4KPj4+IFBscyBsZXQgbWUga25vdyB3aGV0aGVyIHRoaXMg aXMgd2hhdCB5b3UgaGFkIGluIG1pbmQuCj4+IEV4YWN0bHkgd2hhdCBJIHdhbnQuCj4+Cj4+IFRo YW5rcwo+IE9rIGFuZCB0aGlzIGZvciBza2JfYXJyYXkKPgo+IC0tPgo+IHNrYl9hcnJheTogYWRk IHdyYXBwZXJzIGZvciByZXNpemluZwo+Cj4gU2lnbmVkLW9mZi1ieTogTWljaGFlbCBTLiBUc2ly a2luIDxtc3RAcmVkaGF0LmNvbT4KPgo+IC0tCj4KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51 eC9za2JfYXJyYXkuaCBiL2luY2x1ZGUvbGludXgvc2tiX2FycmF5LmgKPiBpbmRleCBjOTAwNzA4 Li43ZTAxYzFmIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvc2tiX2FycmF5LmgKPiArKysg Yi9pbmNsdWRlL2xpbnV4L3NrYl9hcnJheS5oCj4gQEAgLTE1MSwxNiArMTUxLDI0IEBAIHN0YXRp YyBpbmxpbmUgaW50IHNrYl9hcnJheV9pbml0KHN0cnVjdCBza2JfYXJyYXkgKmEsIGludCBzaXpl LCBnZnBfdCBnZnApCj4gICAJcmV0dXJuIHB0cl9yaW5nX2luaXQoJmEtPnJpbmcsIHNpemUsIDAs IGdmcCk7Cj4gICB9Cj4gICAKPiAtdm9pZCBfX3NrYl9hcnJheV9kZXN0cm95X3NrYih2b2lkICpw dHIpCj4gK3N0YXRpYyB2b2lkIF9fc2tiX2FycmF5X2Rlc3Ryb3lfc2tiKHZvaWQgKnB0cikKPiAg IHsKPiAgIAlrZnJlZV9za2IocHRyKTsKPiAgIH0KPiAgIAo+IC1pbnQgc2tiX2FycmF5X3Jlc2l6 ZShzdHJ1Y3Qgc2tiX2FycmF5ICphLCBpbnQgc2l6ZSwgZ2ZwX3QgZ2ZwKQo+ICtzdGF0aWMgaW5s aW5lIGludCBza2JfYXJyYXlfcmVzaXplKHN0cnVjdCBza2JfYXJyYXkgKmEsIGludCBzaXplLCBn ZnBfdCBnZnApCj4gICB7Cj4gICAJcmV0dXJuIHB0cl9yaW5nX3Jlc2l6ZSgmYS0+cmluZywgc2l6 ZSwgZ2ZwLCBfX3NrYl9hcnJheV9kZXN0cm95X3NrYik7Cj4gICB9CgpXaWxsIHNwbGl0IHVwIHRo ZSBhYm92ZSB0d2VhayBpbnRvIGFub3RoZXIgcGF0Y2ggd2hlbiByZXBvc3RpbmcuCgo+ICAgCj4g K3N0YXRpYyBpbmxpbmUgaW50IHNrYl9yYWF5X3Jlc2l6ZV9tdWx0aXBsZShzdHJ1Y3Qgc2tiX2Fy cmF5ICoqcmluZ3MsIGludCBucmluZ3MsCgpJIHRoaW5rIHlvdSBtZWFuICdza2JfYXJyYXlfcmVz aXplJyBoZXJlLgoKPiArCQkJCQkgICBpbnQgc2l6ZSwgZ2ZwX3QgZ2ZwKQo+ICt7Cj4gKwlCVUlM RF9CVUdfT04ob2Zmc2V0b2Yoc3RydWN0IHNrYl9hcnJheSwgcmluZykpOwo+ICsJcHRyX3Jpbmdf cmVzaXplX211bHRpcGxlKChzdHJ1Y3QgcHRyX3JpbmcgKiopcmluZ3MsIG5yaW5ncywgc2l6ZSwg Z2ZwLAo+ICsJCQkJIF9fc2tiX2FycmF5X2Rlc3Ryb3lfc2tiKTsKClRoaXMgc2hvdWxkIGJlIHJl dHVybiBwdHJfcmluZ19yZXNpemVfbXVsdGlwbGUoLi4uCgo+ICt9Cj4gKwo+ICAgc3RhdGljIGlu bGluZSB2b2lkIHNrYl9hcnJheV9jbGVhbnVwKHN0cnVjdCBza2JfYXJyYXkgKmEpCj4gICB7Cj4g ICAJcHRyX3JpbmdfY2xlYW51cCgmYS0+cmluZywgX19za2JfYXJyYXlfZGVzdHJveV9za2IpOwoK V2l0aCB0aGlzLCBsb29rcyBsaWtlIHRoZXJlJ3Mgbm8gbmVlZCBmb3IgYSBuZXcgZmxhZy4gV2ls bCByZXBvc3QgdGhlIApzZXJpZXMgd2l0aCB0aG9zZSB0d28gcGF0Y2hlcy4KClRoYW5rcwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlv biBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcK aHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVh bGl6YXRpb24=