From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ziyuan Xu Date: Fri, 01 Jul 2016 13:46:37 +0800 Subject: [U-Boot] [PATCH 2/4] usb: dwc2-otg: redefine fifo-size for rk3288 In-Reply-To: References: <1467271321-17605-1-git-send-email-xzy.xu@rock-chips.com> <1467271321-17605-3-git-send-email-xzy.xu@rock-chips.com> Message-ID: <577603BD.2070007@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de hi simon, On 2016?06?30? 23:23, Simon Glass wrote: > Hi Ziyuan, > > On 30 June 2016 at 00:21, Ziyuan Xu wrote: >> Redefine RX FIFO size & TX FIFO size for rk3288. >> >> Signed-off-by: Ziyuan Xu >> --- >> >> drivers/usb/gadget/dwc2_udc_otg_regs.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/usb/gadget/dwc2_udc_otg_regs.h b/drivers/usb/gadget/dwc2_udc_otg_regs.h >> index 78ec90e..a0617c8 100644 >> --- a/drivers/usb/gadget/dwc2_udc_otg_regs.h >> +++ b/drivers/usb/gadget/dwc2_udc_otg_regs.h >> @@ -130,8 +130,14 @@ struct dwc2_usbotg_reg { >> #define HIGH_SPEED_CONTROL_PKT_SIZE 64 >> #define HIGH_SPEED_BULK_PKT_SIZE 512 >> >> +#ifdef CONFIG_ROCKCHIP_RK3288 >> +#define RX_FIFO_SIZE (275*4) >> +#define NPTX_FIFO_SIZE (16*4) >> +#else >> #define RX_FIFO_SIZE (1024*4) >> #define NPTX_FIFO_SIZE (1024*4) >> +#endif > I cannot see where this is used. Can you explain? Also can you add a > reason for the change in your commit message? Both RX_FIFO_SIZE and NPTX_FIFO_SIZE are used in dwc2_udc_otg.c::reconfig_usbd() for fifo configuration. We need to redefine properly for rk3288 soc. > >> + >> #define PTX_FIFO_SIZE (1536*1) >> >> #define DEPCTL_TXFNUM_0 (0x0<<22) >> -- >> 1.9.1 >> >> > Regards, > Simon > > >