From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing Subject: Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc() Date: Fri, 1 Jul 2016 14:18:56 +0800 Message-ID: <57760B50.5040107@huawei.com> References: <1466561446-30443-1-git-send-email-wangyijing@huawei.com> <5775D0E8.4060201@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-bcache-owner@vger.kernel.org To: Coly Li , Coly Li , axboe@fb.com, Kent Overstreet Cc: Eric Wheeler , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-raid.ids =D4=DA 2016/7/1 12:24, Coly Li =D0=B4=B5=C0: > =D4=DA 16/7/1 =C9=CF=CE=E710:09, wangyijing =D0=B4=B5=C0: >> >> >> =D4=DA 2016/6/29 18:20, Coly Li =D0=B4=B5=C0: >>> =D4=DA 16/6/22 =C9=CF=CE=E710:10, Yijing Wang =D0=B4=B5=C0: >>>> Cache_sb is not used in cache_alloc, and we have copied >>>> sb info to cache->sb already, remove it. >>>> >>>> Signed-off-by: Yijing Wang >>>> --- >>>> drivers/md/bcache/super.c | 4 ++-- >>>> 1 files changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c >>>> index f5dbb4e..aecaace 100644 >>>> --- a/drivers/md/bcache/super.c >>>> +++ b/drivers/md/bcache/super.c >>>> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj) >>>> module_put(THIS_MODULE); >>>> } >>>> =20 >>>> -static int cache_alloc(struct cache_sb *sb, struct cache *ca) >>>> +static int cache_alloc(struct cache *ca) >>>> { >>>> size_t free; >>>> struct bucket *b; >>>> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *s= b, struct page *sb_page, >>>> if (blk_queue_discard(bdev_get_queue(ca->bdev))) >>>> ca->discard =3D CACHE_DISCARD(&ca->sb); >>>> =20 >>>> - ret =3D cache_alloc(sb, ca); >>>> + ret =3D cache_alloc(ca); >>> >>> I am not sure whether struct cache_b *sb will be used in future, I >>> suggest to let it be for now. >>> >> >> We have copied sb to ca->sb, so if we need sb info in future, we cou= ld get info from ca->sb. >> >=20 > Hi Yijing, >=20 > Your point makes sense, please add > Reviewed-by: Coly Li > in your patch, if you don't mind :-) >=20 > Thanks for your interpretation. >=20 > Coly Thanks for your review very much! Thanks! Yijing. >=20 > . >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbcGAGUL (ORCPT ); Fri, 1 Jul 2016 02:20:11 -0400 Received: from szxga05-in.huawei.com ([119.145.14.199]:11574 "EHLO szxga05-in.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751036AbcGAGUJ (ORCPT ); Fri, 1 Jul 2016 02:20:09 -0400 Subject: Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc() To: Coly Li , Coly Li , , "Kent Overstreet" References: <1466561446-30443-1-git-send-email-wangyijing@huawei.com> <5775D0E8.4060201@huawei.com> CC: Eric Wheeler , , , From: wangyijing Message-ID: <57760B50.5040107@huawei.com> Date: Fri, 1 Jul 2016 14:18:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.23.4] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.57760B59.00AA,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 29be4943e1dde0025a1d151fb8c6123d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/7/1 12:24, Coly Li 写道: > 在 16/7/1 上午10:09, wangyijing 写道: >> >> >> 在 2016/6/29 18:20, Coly Li 写道: >>> 在 16/6/22 上午10:10, Yijing Wang 写道: >>>> Cache_sb is not used in cache_alloc, and we have copied >>>> sb info to cache->sb already, remove it. >>>> >>>> Signed-off-by: Yijing Wang >>>> --- >>>> drivers/md/bcache/super.c | 4 ++-- >>>> 1 files changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c >>>> index f5dbb4e..aecaace 100644 >>>> --- a/drivers/md/bcache/super.c >>>> +++ b/drivers/md/bcache/super.c >>>> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj) >>>> module_put(THIS_MODULE); >>>> } >>>> >>>> -static int cache_alloc(struct cache_sb *sb, struct cache *ca) >>>> +static int cache_alloc(struct cache *ca) >>>> { >>>> size_t free; >>>> struct bucket *b; >>>> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page, >>>> if (blk_queue_discard(bdev_get_queue(ca->bdev))) >>>> ca->discard = CACHE_DISCARD(&ca->sb); >>>> >>>> - ret = cache_alloc(sb, ca); >>>> + ret = cache_alloc(ca); >>> >>> I am not sure whether struct cache_b *sb will be used in future, I >>> suggest to let it be for now. >>> >> >> We have copied sb to ca->sb, so if we need sb info in future, we could get info from ca->sb. >> > > Hi Yijing, > > Your point makes sense, please add > Reviewed-by: Coly Li > in your patch, if you don't mind :-) > > Thanks for your interpretation. > > Coly Thanks for your review very much! Thanks! Yijing. > > . >