From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915: tidy up request alloc Date: Mon, 4 Jul 2016 11:36:03 +0100 Message-ID: <577A3C13.4010005@intel.com> References: <1467250532-23644-1-git-send-email-hong.liu@intel.com> <5774DD4C.6030702@linux.intel.com> <20160630102241.GY28577@nuc-i3427.alporthouse.com> <5775154A.9070005@linux.intel.com> <5776A12A.7040103@intel.com> <20160701183451.GB27799@nuc-i3427.alporthouse.com> <1467605321.2003.9.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id EE3766E3F0 for ; Mon, 4 Jul 2016 10:36:17 +0000 (UTC) In-Reply-To: <1467605321.2003.9.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Liu, Hong" , "chris@chris-wilson.co.uk" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMDQvMDcvMTYgMDU6MDgsIExpdSwgSG9uZyB3cm90ZToKPiBPbiBGcmksIDIwMTYtMDctMDEg YXQgMTk6MzQgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4gT24gRnJpLCBKdWwgMDEsIDIw MTYgYXQgMDU6NTg6MThQTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+PiBPbiAzMC8wNi8x NiAxMzo0OSwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Pj4KPj4+PiBPbiAzMC8wNi8xNiAxMToy MiwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+Pj4+PiBPbiBUaHUsIEp1biAzMCwgMjAxNiBhdCAwOTo1 MDoyMEFNICswMTAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4+Pj4+Cj4+Pj4+PiBPbiAzMC8w Ni8xNiAwMjozNSwgSG9uZyBMaXUgd3JvdGU6Cj4+Pj4+Pj4gUmV0dXJuIHRoZSBhbGxvY2F0ZWQg cmVxdWVzdCBwb2ludGVyIGRpcmVjdGx5IHRvIHJlbW92ZQo+Pj4+Pj4+IHRoZSBkb3VibGUgcG9p bnRlciBwYXJhbWV0ZXIuCj4+Pj4+Pj4KPj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBIb25nIExpdSA8 aG9uZy5saXVAaW50ZWwuY29tPgo+Pj4+Pj4+IC0tLQo+Pj4+Pj4+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYyB8IDI1ICsrKysrKystLS0tLS0tLS0tLS0KPj4+Pj4+PiAtLS0tLS0K Pj4+Pj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygt KQo+Pj4+Pj4+Cj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMKPj4+Pj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+Pj4+PiBp bmRleCAxZDk4NzgyLi45ODgxNDU1IDEwMDY0NAo+Pj4+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPj4+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4+Pj4+Pj4gQEAgLTI5ODgsMzIgKzI5ODgsMjYgQEAgdm9pZCBpOTE1X2dlbV9yZXF1 ZXN0X2ZyZWUoc3RydWN0Cj4+Pj4+Pj4ga3JlZgo+Pj4+Pj4+ICpyZXFfcmVmKQo+Pj4+Pj4+ICAg ICAgIGttZW1fY2FjaGVfZnJlZShyZXEtPmk5MTUtPnJlcXVlc3RzLCByZXEpOwo+Pj4+Pj4+ICAg fQo+Pj4+Pj4+Cj4+Pj4+Pj4gLXN0YXRpYyBpbmxpbmUgaW50Cj4+Pj4+Pj4gK3N0YXRpYyBpbmxp bmUgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICoKPj4+Pj4+PiAgIF9faTkxNV9nZW1fcmVx dWVzdF9hbGxvYyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4+Pj4+Pj4gLSAgICAg ICAgICAgICBzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4LAo+Pj4+Pj4+IC0gICAgICAgICAg ICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICoqcmVxX291dCkKPj4+Pj4+PiArICAgICAg ICAgICAgIHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgpCj4+Pj4+Pj4gICB7Cj4+Pj4+Pj4g ICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZW5naW5lLT5pOTE1Owo+ Pj4+Pj4+ICAgICAgIHVuc2lnbmVkIHJlc2V0X2NvdW50ZXIgPQo+Pj4+Pj4+IGk5MTVfcmVzZXRf Y291bnRlcigmZGV2X3ByaXYtPmdwdV9lcnJvcik7Cj4+Pj4+Pj4gICAgICAgc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpyZXE7Cj4+Pj4+Pj4gICAgICAgaW50IHJldDsKPj4+Pj4+Pgo+Pj4+ Pj4+IC0gICAgaWYgKCFyZXFfb3V0KQo+Pj4+Pj4+IC0gICAgICAgIHJldHVybiAtRUlOVkFMOwo+ Pj4+Pj4+IC0KPj4+Pj4+PiAtICAgICpyZXFfb3V0ID0gTlVMTDsKPj4+Pj4+PiAtCj4+Pj4+Pj4g ICAgICAgLyogQUJJOiBCZWZvcmUgdXNlcnNwYWNlIGFjY2Vzc2VzIHRoZSBHUFUgKGUuZy4KPj4+ Pj4+PiBleGVjYnVmZmVyKSwKPj4+Pj4+PiByZXBvcnQKPj4+Pj4+PiAgICAgICAgKiBFSU8gaWYg dGhlIEdQVSBpcyBhbHJlYWR5IHdlZGdlZCwgb3IgRUFHQUlOIHRvIGRyb3AKPj4+Pj4+PiB0aGUK Pj4+Pj4+PiBzdHJ1Y3RfbXV0ZXgKPj4+Pj4+PiAgICAgICAgKiBhbmQgcmVzdGFydC4KPj4+Pj4+ PiAgICAgICAgKi8KPj4+Pj4+PiAgICAgICByZXQgPSBpOTE1X2dlbV9jaGVja193ZWRnZShyZXNl dF9jb3VudGVyLAo+Pj4+Pj4+IGRldl9wcml2LT5tbS5pbnRlcnJ1cHRpYmxlKTsKPj4+Pj4+PiAg ICAgICBpZiAocmV0KQo+Pj4+Pj4+IC0gICAgICAgIHJldHVybiByZXQ7Cj4+Pj4+Pj4gKyAgICAg ICAgcmV0dXJuIEVSUl9QVFIocmV0KTsKPj4+Pj4+Pgo+Pj4+Pj4+ICAgICAgIHJlcSA9IGttZW1f Y2FjaGVfemFsbG9jKGRldl9wcml2LT5yZXF1ZXN0cywKPj4+Pj4+PiBHRlBfS0VSTkVMKTsKPj4+ Pj4+PiAgICAgICBpZiAocmVxID09IE5VTEwpCj4+Pj4+Pj4gLSAgICAgICAgcmV0dXJuIC1FTk9N RU07Cj4+Pj4+Pj4gKyAgICAgICAgcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4+Pj4+Pj4KPj4+ Pj4+PiAgICAgICByZXQgPSBpOTE1X2dlbV9nZXRfc2Vxbm8oZW5naW5lLT5pOTE1LCAmcmVxLT5z ZXFubyk7Cj4+Pj4+Pj4gICAgICAgaWYgKHJldCkKPj4+Pj4+PiBAQCAtMzA0MSwxNCArMzAzNSwx MyBAQCBfX2k5MTVfZ2VtX3JlcXVlc3RfYWxsb2Moc3RydWN0Cj4+Pj4+Pj4gaW50ZWxfZW5naW5l X2NzICplbmdpbmUsCj4+Pj4+Pj4gICAgICAgaWYgKHJldCkKPj4+Pj4+PiAgICAgICAgICAgZ290 byBlcnJfY3R4Owo+Pj4+Pj4+Cj4+Pj4+Pj4gLSAgICAqcmVxX291dCA9IHJlcTsKPj4+Pj4+PiAt ICAgIHJldHVybiAwOwo+Pj4+Pj4+ICsgICAgcmV0dXJuIHJlcTsKPj4+Pj4+Pgo+Pj4+Pj4+ICAg ZXJyX2N0eDoKPj4+Pj4+PiAgICAgICBpOTE1X2dlbV9jb250ZXh0X3VucmVmZXJlbmNlKGN0eCk7 Cj4+Pj4+Pj4gICBlcnI6Cj4+Pj4+Pj4gICAgICAga21lbV9jYWNoZV9mcmVlKGRldl9wcml2LT5y ZXF1ZXN0cywgcmVxKTsKPj4+Pj4+PiAtICAgIHJldHVybiByZXQ7Cj4+Pj4+Pj4gKyAgICByZXR1 cm4gRVJSX1BUUihyZXQpOwo+Pj4+Pj4+ICAgfQo+Pj4+Pj4+Cj4+Pj4+Pj4gICAvKioKPj4+Pj4+ PiBAQCAtMzA2NywxMyArMzA2MCw5IEBAIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqCj4+ Pj4+Pj4gICBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu Z2luZSwKPj4+Pj4+PiAgICAgICAgICAgICAgICAgIHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpj dHgpCj4+Pj4+Pj4gICB7Cj4+Pj4+Pj4gLSAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3Qg KnJlcTsKPj4+Pj4+PiAtICAgIGludCBlcnI7Cj4+Pj4+Pj4gLQo+Pj4+Pj4+ICAgICAgIGlmIChj dHggPT0gTlVMTCkKPj4+Pj4+PiAgICAgICAgICAgY3R4ID0gZW5naW5lLT5pOTE1LT5rZXJuZWxf Y29udGV4dDsKPj4+Pj4+PiAtICAgIGVyciA9IF9faTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhlbmdp bmUsIGN0eCwgJnJlcSk7Cj4+Pj4+Pj4gLSAgICByZXR1cm4gZXJyID8gRVJSX1BUUihlcnIpIDog cmVxOwo+Pj4+Pj4+ICsgICAgcmV0dXJuIF9faTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhlbmdpbmUs IGN0eCk7Cj4+Pj4+Pj4gICB9Cj4+Pj4+Pj4KPj4+Pj4+PiAgIHN0cnVjdCBkcm1faTkxNV9nZW1f cmVxdWVzdCAqCj4+Pj4+Pgo+Pj4+Pj4gTG9va3MgZ29vZCB0byBtZS4gQW5kIGhhdmUgdGhpcyBm ZWVsaW5nIEkndmUgc2VlbiB0aGlzCj4+Pj4+PiBzb21ld2hlcmUgYmVmb3JlLgo+Pj4+Pgo+Pj4+ PiBTZXZlcmFsIHRpbWVzLiBUaGlzIGlzIG5vdCB0aGUgZnVsbCB0aWR5LCBub3IgZG9lcyBpdCBy ZWFsaXNlCj4+Pj4+IHRoZSByYW1pZmFjdGlvbnMgb2YgcmVxdWVzdCBhbGxvYyB0aHJvdWdoIHRo ZSBzdGFjay4KPj4+Pgo+Pj4+IEhtIEkgY2FuJ3Qgc3BvdCB0aGF0IGl0IGlzIGRvaW5nIGFueXRo aW5nIHdyb25nIG9yIG1ha2luZwo+Pj4+IGFueXRoaW5nIHdvcnNlLiBZb3UgZG9uJ3Qgd2FudCB0 byBsZXQgdGhlIHNtYWxsIGNsZWFudXAgaW4/Cj4+Pj4KPj4+PiBSZWdhcmRzLAo+Pj4+IFR2cnRr bwo+Pj4KPj4+IEl0IG91Z2h0IHRvIG1ha2UgYWxtb3N0IG5vIGRpZmZlcmVuY2UsIGJlY2F1c2Ug dGhlICpvbmx5KiBwbGFjZSB0aGUKPj4+IGlubmVyIGZ1bmN0aW9uIGlzIGNhbGxlZCBpcyBmcm9t IHRoZSBvdXRlciBvbmUsIHdoaWNoIHBhc3NlcyBhCj4+PiBwb2ludGVyIHRvIGEgbG9jYWwgZm9y IHRoZSByZXR1cm5lZCBvYmplY3Q7IGFuZCB0aGUgaW5uZXIgb25lIGlzCj4+PiB0aGVuIGlubGlu ZWQsIHNvIHRoZSBjb21waWxlciBkb2Vzbid0IGFjdHVhbGx5IHB1dCBpdCBvbiB0aGUgc3RhY2sK Pj4+IGFuZCBjYWxsIHRvIHRoZSBpbm5lciBhbGxvY2F0b3IgYW55d2F5Lgo+Pj4KPj4+IFN0cmFu Z2VseSwgaG93ZXZlciwgd2l0aCB0aGlzIGNoYW5nZSB0aGUgY29kZSBiZWNvbWVzIH40MDAgYnl0 ZXMKPj4+IGJpZ2dlciEKPj4+Cj4+PiBEaXNhc3NlbWJseSByZXZlYWxzIHRoYXQgd2hpbGUgdGhl IGNvZGUgZm9yIHRoZSBleHRlcm5hbGx5LWNhbGxhYmxlCj4+PiBvdXRlciBmdW5jdGlvbiBpcyBp bmRlZWQgYWxtb3N0IGlkZW50aWNhbCwgYSBzZWNvbmQgY29weSBvZiBpdCBoYXMKPj4+IGFsc28g YmVlbiBpbmxpbmVkIGF0IHRoZSBvbmUgY2FsbHNpdGUgaW4gdGhpcyBmaWxlOgo+Pj4KPj4+IF9f aTkxNV9nZW1fb2JqZWN0X3N5bmMoKSAuLi4KPj4+IAlyZXEgPSBpOTE1X2dlbV9yZXF1ZXN0X2Fs bG9jKHRvLCBOVUxMKTsKPj4+Cj4+PiBJIGRvbid0IHRoaW5rIHRoYXQncyBhIGNyaXRpY2FsIHBh dGggYW5kIHdvdWxkIHJhdGhlciBoYXZlIDQwMAo+Pj4gYnl0ZXMKPj4+IHNtYWxsZXIgY29kZXNw YWNlLiBXZSBjYW4gZ2V0IHRoYXQgYmFjayBieSBhZGRpbmcgL25vaW5saW5lLyB0byB0aGUKPj4+ IG91dGVyIGZ1bmN0aW9uIGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2MoKSAobm90LCBvZiBjb3Vyc2Us IHRvIHRoZQo+Pj4gaW5uZXIgb25lLCB0aGF0IGRlZmluaXRlbHkgKnNob3VsZCogYmUgaW5saW5l KS4KPj4KPj4gX19pOTE1X2dlbV9vYmplY3Rfc3luYygpIHNob3VsZCBub3QgYmUgY2FsbGluZwo+ PiBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKCkuCj4+Cj4+IFRoYXQncyB0aGUgaXNzdWUgd2l0aCB0 aGlzIHBhdGNoLCB5b3VyIHBhdGNoIGFuZCBKb2huJ3MgcGF0Y2guCj4KPiBTbyB3ZSB3cm90ZSB0 aGUgaTkxNV9nZW1fcmVxdWVzdF9hbGxvYygpIHRoaXMgd2F5IGlzIHRvIGF2b2lkIGJlaW5nCj4g aW5saW5lZCBpbnRvIGNhbGxlcnMgbGlrZSBfX2k5MTVfZ2VtX29iamVjdF9zeW5jKCk/CgpOb3Qg c3BlY2lmaWNhbGx5LCBhcyB0aGUgZGVzY3JpcHRpb24gb2YgY29tbWl0IDI2ODI3MDg4MyBzYXlz LAoKIi4uLiB0aGlzIHBhdGNoIHJlbmFtZXMgdGhlIGV4aXN0aW5nIGk5MTVfZ2VtX3JlcXVlc3Rf YWxsb2MoKSwgYW5kCiAgbWFrZXMgaXQgbG9jYWwgKHN0YXRpYyBpbmxpbmUpLCBhbmQgcmVwbGFj ZXMgaXQgd2l0aCBhIHdyYXBwZXIgdGhhdAogIHByb3ZpZGVzIGEgZGVmYXVsdCBpZiB0aGUgY29u dGV4dCBpcyBOVUxMLCBhbmQgYWxzbyBoYXMgYSBuaWNlcgogIGNhbGxpbmcgY29udmVudGlvbiAo ZG9lc24ndCByZXF1aXJlIGEgcG9pbnRlciB0byBhbiBvdXRwdXQgcGFyYW1ldGVyKS4KICBUaGVu IHdlIGNoYW5nZSBhbGwgY2FsbGVycyB0byB1c2UgdGhlIG5ldyBjb252ZW50aW9uOgogICAgIE9M RDoKICAgICAgICAgZXJyID0gaTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhyaW5nLCB1c2VyX2N0eCwg JnJlcSk7CiAgICAgICAgIGlmIChlcnIpIC4uLgogICAgIE5FVzoKICAgICAgICAgcmVxID0gaTkx NV9nZW1fcmVxdWVzdF9hbGxvYyhyaW5nLCB1c2VyX2N0eCk7CiAgICAgICAgIGlmIChJU19FUlIo cmVxKSkgLi4uCiAgICAgT0xEOgogICAgICAgICBlcnIgPSBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9j KHJpbmcsIHJpbmctPmRlZmF1bHRfY29udGV4dCwgJnJlcSk7CiAgICAgICAgIGlmIChlcnIpIC4u LgogICAgIE5FVzoKICAgICAgICAgcmVxID0gaTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhyaW5nLCBO VUxMKTsKICAgICAgICAgaWYgKElTX0VSUihyZXEpKSAuLi4iCgpBdCB0aGUgdGltZSwgaXQgd2Fz IG1vcmUgYSBtYXR0ZXIgb2Ygc2ltcGxpZnlpbmcgcmV2aWV3IGFuZCBtaW5pbWlzaW5nIApsaW5l cy1vZi1jaGFuZ2UgYnkgYWRkaW5nIHRoZSB3cmFwcGVyIHRvIGltcGxlbWVudCB0aGUgbmV3IGNv bnZlbnRpb24gCnJhdGhlciB0aGFuIHJld3JpdGluZyB0aGUgcmVhbCBmdW5jdGlvbiBhdCB0aGUg c2FtZSB0aW1lIGFzIGNoYW5naW5nIGFsbCAKdGhlIGNhbGxlcnMuIFNvIEkgaGF2ZSBubyBvYmpl Y3Rpb24gdG8gY29udGludWluZyB0aGUgcHJvY2VzcyBvZiBtYWtpbmcgCnRoaXMgbmljZXIgYnkg bm93IGZsYXR0ZW5pbmcgdGhlIHR3byBsYXllcnMgaW50byBhIHNpbmdsZSBmdW5jdGlvbjsgSSAK anVzdCBub3RlZCB0aGUgb2RkaXR5IHRoYXQgdGhlIGZsYXR0ZW5pbmcgbWFkZSB0aGUgY29kZXNw YWNlIGxhcmdlci4KCkNocmlzLCBkbyB5b3UgaGF2ZSBhIHBhdGNoIGZvciAqbm90KiBjYWxsaW5n IGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2MoKSAKZnJvbSBpbnNpZGUgX19pOTE1X2dlbV9vYmplY3Rf c3luYygpID8gSSBkb24ndCByZWFsbHkga25vdyB3aHkgSm9obidzIApvcmlnaW5hbCBjb252ZXJz aW9uIHRvIHBhc3NpbmcgcmVxdWVzdHMgZXZlcnl3aGVyZSBuZWVkZWQgdGhpcy4KCi5EYXZlLgoK PiBJIGNoZWNrZWQgdGhlIGZpbGUgd2l0aCBHQ0MgNC44LjUgb24gbXkgY2VudG9zIGVudmlyb25t ZW50LCBpdCBpcyBsaWtlCj4gd2hhdCBEYXZlIGZvdW5kLiBXaXRoIHRoZSBwYXRjaCwgaTkxNV9n ZW1fb2JqZWN0X3N5bmMoKSBpcyAzNjggYnl0ZXMKPiBiaWdnZXIuCj4KPiBCdXQgd2hlbiBJIGNo ZWNrZWQgaXQgd2l0aCBHQ0MgNi4xLjEgb24gRmVkb3JhIDI0LCBpdCBzZWVtcyBpdCBpbmxpbmVz Cj4gdGhlIGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2MoKSBldmVuIHdpdGggdGhlIGN1cnJlbnQgaW1w bGVtZW50YXRpb24uCj4gV2l0aCB0aGUgcGF0Y2gsIHRoZSBpOTE1X2dlbV9vYmplY3Rfc3luYygp IGlzIDgwIGJ5dGVzIHNtYWxsZXIuCj4KPj4gLUNocmlzCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK