From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh jain Subject: Re: [PATCH v1 28/28] ether: support SoC device/driver Date: Tue, 5 Jul 2016 10:12:38 +0530 Message-ID: <577B3ABE.4040709@nxp.com> References: <1462542490-15556-1-git-send-email-viktorin@rehivetech.com> <1462542490-15556-29-git-send-email-viktorin@rehivetech.com> <577397EF.2080300@nxp.com> <20160704150451.1a61fbbd@pcviktorin.fit.vutbr.cz> <577A7245.700@nxp.com> <20160704163646.45d1f0f8@pcviktorin.fit.vutbr.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: To: Jan Viktorin Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0060.outbound.protection.outlook.com [104.47.41.60]) by dpdk.org (Postfix) with ESMTP id 8C531902 for ; Tue, 5 Jul 2016 06:42:02 +0200 (CEST) In-Reply-To: <20160704163646.45d1f0f8@pcviktorin.fit.vutbr.cz> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Monday 04 July 2016 08:06 PM, Jan Viktorin wrote: > On Mon, 4 Jul 2016 19:57:18 +0530 > Shreyansh jain wrote: > > [...] > >>>>> @@ -1431,7 +1524,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info) >>>>> >>>>> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); >>>>> (*dev->dev_ops->dev_infos_get)(dev, dev_info); >>>>> - dev_info->pci_dev = dev->pci_dev; >>>>> + dev_info->soc_dev = dev->soc_dev; >>>> >>>> I think both the members, pci_dev and soc_dev, should be updated by this call. >>>> Is there some specific reason why soc_dev is the only one which is getting updated? >>> >>> Yes, looks like a mistake. Thanks! And sorry for delayed reply. >> >> No problems - thanks for confirmation. >> I have gone through almost complete series and as and when you rebase it, it would have my ACK. > > OK, thanks. That's what I am playing with right now. I've rebased on v3 of this patch. There will > be some more tests in my v2. > >> rte_driver patchset which I sent last are broken - I will publish an updated version very soon. > > I am surprised that you've changed the args to RTE_EAL_PCI_REGISTER... Are you sure about this step? > I wrote that I'll change it myself for v2 for SoC to accept name and pointer as it was originally for PCI... Really? Then probably I understood it wrong. I don't have any issues with the first one as well but just for slightly cleaner approach I thought of going with your suggest (or, suggestion as understood by me). Anyways the patch is broken and doesn't apply on master. I will push a new version (with revert EAL_PCI_REGISTER arguments) within today. > > Jan > - Shreyansh