From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKRuT-0003AW-Np for qemu-devel@nongnu.org; Tue, 05 Jul 2016 11:05:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKRuO-0004Sp-OZ for qemu-devel@nongnu.org; Tue, 05 Jul 2016 11:05:13 -0400 References: <1467715800-20379-1-git-send-email-berrange@redhat.com> <1467715800-20379-3-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <577BCC98.3000007@redhat.com> Date: Tue, 5 Jul 2016 09:04:56 -0600 MIME-Version: 1.0 In-Reply-To: <1467715800-20379-3-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SrO42KiS3oieQE7EOTd5DoCWITo4HPDrj" Subject: Re: [Qemu-devel] [PATCH v1 2/2] Revert "block: don't register quorum driver if SHA256 support is unavailable" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Max Reitz , Alberto Garcia This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SrO42KiS3oieQE7EOTd5DoCWITo4HPDrj From: Eric Blake To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Max Reitz , Alberto Garcia Message-ID: <577BCC98.3000007@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 2/2] Revert "block: don't register quorum driver if SHA256 support is unavailable" References: <1467715800-20379-1-git-send-email-berrange@redhat.com> <1467715800-20379-3-git-send-email-berrange@redhat.com> In-Reply-To: <1467715800-20379-3-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/05/2016 04:50 AM, Daniel P. Berrange wrote: > The qcrypto hash APIs now guarantee that sha256 is available at > compile time, so skipping registration is rarely needed. A check > at time of open is kept to ensure good error reporting in the > (unlikely) case sha256 is runtime disabled. >=20 > This reverts commit e94867ed5f241008d0f53142b2704a075f9ed505. > --- > block/quorum.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SrO42KiS3oieQE7EOTd5DoCWITo4HPDrj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXe8yYAAoJEKeha0olJ0NqUMwH/1tuIZE//C6GlLedRXx1kfqy iSRXaa5UprLx0wV7MqZw32oQqBMFRmgyuxaj18B/5HMVkjGJe51Za8aE4aSbyMMB MgvxkySV3ZmC0p8Rk6/DGkpmxGl2oxnO5bOI+qkaDHyryuXCHXZ3iTyZAz121ed0 cMMppIR8QuOiniwCGLtsZx81JxSsn97TuoWUsyc61ixeBIWdPf16Ckt/bA8dzMdg viL7y6cTY87Ni4X4bFJxki+9soO+ySPn1vbS24pjOjfow7nR2wlvHZnxpoukX9R1 AUkdz0JQ4jwWPn2bMr8sUfUfFN9AxIwNI46Svq8YWnAfQ3WBOhB49t/SwAQACVE= =oIZa -----END PGP SIGNATURE----- --SrO42KiS3oieQE7EOTd5DoCWITo4HPDrj--