From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH v3 1/3] bcache: Remove redundant parameter for cache_alloc() Date: Tue, 5 Jul 2016 11:35:19 -0600 Message-ID: <577BEFD7.9050708@fb.com> References: <1467595405-20805-1-git-send-email-wangyijing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1467595405-20805-1-git-send-email-wangyijing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Yijing Wang , Kent Overstreet Cc: Eric Wheeler , Coly Li , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-raid.ids On 07/03/2016 07:23 PM, Yijing Wang wrote: > Cache_sb is not used in cache_alloc, and we have copied > sb info to cache->sb already, remove it. Added this, and 2-3/3 for 4.8, thanks. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755451AbcGERhP (ORCPT ); Tue, 5 Jul 2016 13:37:15 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:5194 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751407AbcGERhC (ORCPT ); Tue, 5 Jul 2016 13:37:02 -0400 Subject: Re: [PATCH v3 1/3] bcache: Remove redundant parameter for cache_alloc() To: Yijing Wang , Kent Overstreet References: <1467595405-20805-1-git-send-email-wangyijing@huawei.com> CC: Eric Wheeler , Coly Li , , , From: Jens Axboe Message-ID: <577BEFD7.9050708@fb.com> Date: Tue, 5 Jul 2016 11:35:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1467595405-20805-1-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM3PR19CA0025.namprd19.prod.outlook.com (10.164.243.163) To BLUPR15MB0452.namprd15.prod.outlook.com (10.163.214.18) X-MS-Office365-Filtering-Correlation-Id: 24ad4f30-a263-421c-8c3d-08d3a4fabf5f X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0452;2:B4NSHm99mn0t1pvbX/GukxKSILt4ji6YHkIXwGXbgooTgYlbUM3ImwOUM6yR8RfF5CljvuPoKog1H2CS4dDbFNSR9dcRT+j7/CgwSpmqAfvSqrEH67Y7YPTThflsR+kVwzKCNhiA/VPV71cz7kRU4ztP+IyhqPkU06u3Ic90hIZE80kswwaio/vCV+4NfZHn;3:GBI+OI1uCQKVGlOfQG0cqzHOQr2uBcBepSdXUUi0LRv15FAp4FyqWBFBaU4rILY8N87D5++fw9mudwYJ6AxQBzETlhs9LMSgJ7PdSZOH4UgNgVTcQ4z/WXO5uvE6h+bA;25:JJO0NBKcXUZb1jNID08rdn1AI6b1D5NIhxFUSG20bVzHfXH5Oa9UyhTHhhM7dUhWBm2pbjXIuv1Xlzwnh3xFartsbiZamE+Jx2lt6oBwoVIKNLAxVAcCmTkxCbhyydYaB5ZQetp7TXYNH0hCtDenHwH0OTnAIMwSyB9h18E0Lf69coeK7pOu+N2w5bzn3WroSUl2+gyFRE5ynByl+MVjiyeIt1NfXK6x7IK46PTNHxEGhQ9sKisMJkIKI+8MYSKima79+/uVjdaSm3Rxt5nK9JKq306MaHgQgZ8f7qC31jQDA7p8Y4QfCNlmrSyPUhHM1EgkpaVPETGxajPAQfAKHs4iZXOhIeRAE5Ydv4gwOMvj9Etf/dW5N492hlFvm1F1vzhr4GyPiuTXf3Axz8FRKr8IpU6hr07q0MFnEbI+j5I=;31:H1HbHKrH9dF1ie+PMRZ5HKfVmyuaX8fz6+2X0oBmJ1P1vvBXQ25RZ6hA5sHUGkRN0rYzw7JKOWJkkoFrdXr4b/DsBq6RgCLHuLZgmK7qW0TuCQFSsLIeua0SwW/X4fG6jIZ8J4zVFQtTKw2rLMhKMZ7fErARJvAWGpeGxb5HPic7nX06uYKLhmx5o1j/mQPSWJ4QOtN+rbysbXVO17VhoQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR15MB0452; X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0452;20:kCk6dl5h2ayWvGIbRVo1ZOKUjAxpfRSue2MDY/jU7PEFMf38Ai35/1jiVLbvWygXNa7vOdO2r7eJBlm8apJpDpCmsKymy4LeuFO3pGT2HsIRSGYu+Nh6E1HxVWSm15Vxm7a+KhiBOLRyd3IjqzS0nlqedO5bYGo0Iyfx9znrv5A=;4:gYRkUVkSTB7dOZX91jJcT6u7K4MFsp82ma6zy6RsFOATkp5yrPZhUG8tBbPRUNMVTMieA5/68QB9imusk/HYbk7VTvuoNyraywp/iF32rqXYOveCUciAhmIBx4+umHKNEK6Xls9Iijp93Att+uvkFYewRtCC5viscZSwC5I8R4kdpfonuT4z0Nxk6SYeNeReAfyEJuPZoncDsZJax4A+g1M1Q7tLj2Am2Yho0dUXnnW7rBwJLyCd+kS4Hf6tkz2zgWC9mcO5K2GaQ3LUjvR0NEz2Nn/22fuOFjPAdiuboNlx14y5MC8h6UM1v3yJSG4zf++vNWycdvhJMJNiGqWZVmsVQuH9bNFBC0JJxZ91fVx5f4MSlKZJo7+dE0HNNTfW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BLUPR15MB0452;BCL:0;PCL:0;RULEID:;SRVR:BLUPR15MB0452; X-Forefront-PRVS: 0994F5E0C5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377424004)(24454002)(189002)(199003)(377454003)(86362001)(64126003)(8676002)(87266999)(50986999)(76176999)(54356999)(65816999)(65806001)(65956001)(7846002)(97736004)(4326007)(66066001)(68736007)(2906002)(42186005)(81156014)(81166006)(2950100001)(50466002)(558084003)(189998001)(5001770100001)(33656002)(586003)(47776003)(117156001)(305945005)(230700001)(3846002)(7736002)(105586002)(83506001)(92566002)(106356001)(6116002)(4001350100001)(23746002)(77096005)(59896002)(101416001)(36756003)(80316001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR15MB0452;H:[192.168.1.130];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR15MB0452;23:rrvzzM1GyyazanTOm/PMN+lwwJmGZgSoeXcQN?= =?Windows-1252?Q?JJLeKpaKECeXMP5VGmSFjst4zlUfoV2xdJtOttJqCWlo7ymSxbMJO4oG?= =?Windows-1252?Q?ocJyrl3kSfOnLoN20+VNcpReRetoIed0/lv2klxgc3STCq+KkeZc6Cz2?= =?Windows-1252?Q?qWbA/X7YKsCIThYOuMsumgFh7Q+JNWRD4cjtBlGvWmOIst4eHLlpYUeW?= =?Windows-1252?Q?/ub8U4hjeLn1WDjrhgd9NGuGNRnOIb6snc7NM3c4LgCVfvhzMo3edMSL?= =?Windows-1252?Q?OKtuYT1yO8zkFkuhy+1vRyrbXlxuYUtalEv+3NQ2jw7SdvVuPqG5Yyoh?= =?Windows-1252?Q?dBN/JZmdu2i+MKvQSTu80KzCqCHSbuanwUL2WTcjkS/n2JFljYuzMp6v?= =?Windows-1252?Q?ggXzi4BS9bgZSqgdFV0xo7vptTZtp4nQDJ+yzb6tNhjlVnVV8WYNSsAL?= =?Windows-1252?Q?25xHH4hznAszSLQ81KAbBNRirKiKdmFrN2sHpDaFQW7nh4B7XJaOY375?= =?Windows-1252?Q?iuPginBJf54A83avh+YKT1mUO5OslOyztv7QE1QH4oIXwwPTYgufOSHG?= =?Windows-1252?Q?zE0IkjNWg6plOETZiEhwRXtU8MpHOMmxBaAIJHmQcQSjbZrz9eC2Q8m6?= =?Windows-1252?Q?topRrF/rG+49URVf5fappn7FSM6fiD10EeOAFcw+g8hVl213VIIsSeTi?= =?Windows-1252?Q?Yu/2VJNmECMIoy6t4EBjDbRV4lr8bL9NIjI9dgXnbR1vK9WMctqkSvX5?= =?Windows-1252?Q?e48mppAfKuRqpDqoBS6+wpDDrrHugOk4cQfk8tTAxumjdQ+8RVKkgwKY?= =?Windows-1252?Q?T+HmSyV858kg0aCRJQz/fgQmw1G6Fb+nPpQQs3BI03mLp9Bk09y6fO/Y?= =?Windows-1252?Q?oOcjwuoETDgKovmb1N61hCoOmWJPfIge2IZYEUu7w5wKxOwxvR4Dvood?= =?Windows-1252?Q?boALtRLaWVdt8dyeKzga0RrH2yOj0uaPH9OfYXFBjnUYn32U4loT8LrK?= =?Windows-1252?Q?kI6bYoKjPcDmlVlw1qBhEMWwUNejMQxdGNbcxdP+aWgJ7m7qj9KIjVCa?= =?Windows-1252?Q?R3at7HMUG47RCB+9Lw8Zqg/rRbWq3vaomTN1k5m8yDv/o6loQcWrTaFB?= =?Windows-1252?Q?0yOElHqnapR6sAVuo6HVnG5JCRlienzFr8atG82d1pRqDJSUUnMr8pdE?= =?Windows-1252?Q?EPmv4PPYZAYxabONTQwk9X6WWsNR/3HO9Bn3cjsekbS3qeGMG6IrVxj0?= =?Windows-1252?Q?/OfWVh0PKMsFqGHHEHr3SSlbx7rHP8qfyWxBIT774mA3YIfv2GqweY8d?= =?Windows-1252?Q?BhhBPbbGt9VTdSv5HbajtjIf7SXhBgG2A+atqwLuHC8PkHPdLI2aED/P?= =?Windows-1252?Q?tnqo4+BSDn91z1VXt2YOEFagH8WsXf2ZQVoMJI8Hrw21eTtpeUDPck?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0452;6:jMVyJcjzszOWWFuRoYYZXdENkIYDgB/46hRcov1qyhphBxHsF8sF7ESXyGYmUN9ltjitYD2fpVWwr2u3P5nipoxV/lcQRQtSqWBjKUOlYk2mNs6jtXbrcK+bNUgRJsYQTLkHT/A3dEuF9+S0+KNr2j+pBOFVyCwvlqiOpVWHPREJ/GA32db29wt8ENF0uPZhGDlQYZu17nO0XE20dJKVlugKHIDno/bSXLUYiO53EICHLMm7BKtGD/yVyuFGHrAbP186A/NMHmU13LMu7SPjG5aIxIVKHG8Z2GHHSLLIrZA=;5:i7t/lN5h6umfLXBNsOsXrq9IFBTzv/Gg8xsHj+8fPWyCclTn+ZAUiyilqWtOlhrO6GZUTiw2xFJMRss+UQUP8kmgBSQm0sZ1Aanxym2y3FOdFA+LJPPFLD/3+u+1g7Z+H3FqPTdbOBpyRc3Ry1h90A==;24:/6uSnTu9lvBadvMMdG67HAMWvz9PS9L0pqavuT1A7gvi/Zn8uinqCaAm3FP6yFfSLRfFVCH70eTqaRFk5QHYXX09OMHa+v54NQKlOYiP7no=;7:gj3T6ayfggjfXO5EpmSQu2kWotjzRFyXgqWdmLkNR/+gld0OZBCdxGdY9Yocn+qLN+IyCE854S+VCSktInTngprIyFzSP3r03GPPOK30J01MpECj5vWjTG1QTT+YWjEGUEeezjj74+ZbOzbB6VGWXmYwY9aodlD1TZJvZwQYwOB4elAGsB1iJmAQ+66J/AjTBwXGv9z03tqc1v/0dqf7k2Vwyaloj0qKjxVKS0XOAcKHCUINewBlOP/5J1WzyFEl SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR15MB0452;20:NcIZS7ukDCVqbD4YmqZmfGbfUWSFCarEjNbaRTBnxPVTQo5wyyWZnvdOiOTwS0KS+2vbFvIWjGi63gTUkHrQ3qkDwA9E7ouJgQH9otBfnWohVFa3v5Uc7gIe8zI9kNpef8WAJaHlCWOlRTCCpQHGxDmIG0IjCXy7l1Hn8oJvQFs= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2016 17:35:24.1634 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR15MB0452 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-05_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2016 07:23 PM, Yijing Wang wrote: > Cache_sb is not used in cache_alloc, and we have copied > sb info to cache->sb already, remove it. Added this, and 2-3/3 for 4.8, thanks. -- Jens Axboe