From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932954AbcGEVXY (ORCPT ); Tue, 5 Jul 2016 17:23:24 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:16781 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752503AbcGEVXX (ORCPT ); Tue, 5 Jul 2016 17:23:23 -0400 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: borntraeger@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release To: Paolo Bonzini , Joe Perches , Steven Rostedt , Borislav Petkov , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Cornelia Huck References: <1467642292-15671-1-git-send-email-bp@alien8.de> <1467642292-15671-2-git-send-email-bp@alien8.de> <20160705142648.57456ef8@gandalf.local.home> <20160705184517.GF12027@pd.tnic> <20160705145732.4b6dbd55@gandalf.local.home> <20160705194244.GG12027@pd.tnic> <20160705154959.2705b658@gandalf.local.home> <1467749333.16342.5.camel@perches.com> <577C1E63.8060608@de.ibm.com> <46183d11-5800-bb69-2da8-58fadc699cb8@redhat.com> Cc: LKML , Andrew Morton , Franck Bui , Greg Kroah-Hartman , Ingo Molnar , Linus Torvalds , Peter Zijlstra , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Janosch Frank From: Christian Borntraeger Date: Tue, 5 Jul 2016 23:23:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <46183d11-5800-bb69-2da8-58fadc699cb8@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16070521-0020-0000-0000-000001CE2CF9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16070521-0021-0000-0000-00001C9F8B1A Message-Id: <577C2542.9010008@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-05_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607050189 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/05/2016 11:14 PM, Paolo Bonzini wrote: > > > On 05/07/2016 22:53, Christian Borntraeger wrote: >> Yes, this is new in next. As far as I can see, the new message would only >> appear if we would call ratelimit_state_exit. Correct? We do not call this - >> I assume this is ok? >> >> We really only want to reuse the rate limit base code (to avoid writing the same >> code twice) and being in lib indicated that this can indeed be used outside >> printk. >> Now: your patch 1 would allow me to get rid of the messages completely >> by setting the flag and by not calling ratelimit_state_exit. Which is probably >> what we should do in our code. > > Can we delay fixing this after the code is merged in Linus's tree? Absolutely. We already have 2 smaller conflicts in next and I certainly do not want to add another one. The current ratelimit print does not hurt - it is just not necessary for us. so my statement was just a "statement of direction" to write some IBM speak ;-)