From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751015AbcGFEZr (ORCPT ); Wed, 6 Jul 2016 00:25:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:47896 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbcGFEZp (ORCPT ); Wed, 6 Jul 2016 00:25:45 -0400 Subject: Re: [PATCH 3/3] xen: support runqueue steal time on xen To: Stefano Stabellini References: <1466579034-12113-1-git-send-email-jgross@suse.com> <1466579034-12113-4-git-send-email-jgross@suse.com> Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com From: Juergen Gross Message-ID: <577C8845.4050304@suse.com> Date: Wed, 6 Jul 2016 06:25:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/16 17:23, Stefano Stabellini wrote: > On Wed, 22 Jun 2016, Juergen Gross wrote: >> Up to now reading the stolen time of a remote cpu was not possible in a >> performant way under Xen. This made support of runqueue steal time via >> paravirt_steal_rq_enabled impossible. >> >> With the addition of an appropriate hypervisor interface this is now >> possible, so add the support. >> >> Signed-off-by: Juergen Gross >> --- >> drivers/xen/time.c | 42 +++++++++++++++++++++++++----------------- >> 1 file changed, 25 insertions(+), 17 deletions(-) >> >> diff --git a/drivers/xen/time.c b/drivers/xen/time.c >> index 2257b66..65afbe9 100644 >> --- a/drivers/xen/time.c >> +++ b/drivers/xen/time.c >> @@ -19,6 +19,9 @@ >> /* runstate info updated by Xen */ >> static DEFINE_PER_CPU(struct vcpu_runstate_info, xen_runstate); >> >> +/* runstate info of remote cpu accessible */ >> +static bool xen_runstate_remote; > > Honestly I would rather have one global variable less if it means only > dropping one BUG_ON. Okay, I'll remove it. Juergen