From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960AbcGFHjz (ORCPT ); Wed, 6 Jul 2016 03:39:55 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:3320 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbcGFHjx (ORCPT ); Wed, 6 Jul 2016 03:39:53 -0400 Subject: Re: [PATCH 2/4] dt-bindings: Document the STM32 reset bindings To: Rob Herring References: <1467640052-6770-1-git-send-email-gabriel.fernandez@st.com> <1467640052-6770-2-git-send-email-gabriel.fernandez@st.com> <20160705161813.GA20477@rob-hp-laptop> CC: Philipp Zabel , Mark Rutland , Maxime Coquelin , Russell King , , , , , From: Gabriel Fernandez Message-ID: <577CB59E.1080508@st.com> Date: Wed, 6 Jul 2016 09:39:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160705161813.GA20477@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.0.158] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-06_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thanks for reviewing On 07/05/2016 06:18 PM, Rob Herring wrote: > On Mon, Jul 04, 2016 at 03:47:30PM +0200, gabriel.fernandez@st.com wrote: >> From: Maxime Coquelin >> >> This adds documentation of device tree bindings for the >> STM32 reset controller. >> >> Signed-off-by: Maxime Coquelin >> --- >> .../devicetree/bindings/reset/st,stm32-rcc.txt | 50 ++++++++++++++++++++++ >> 1 file changed, 50 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> >> diff --git a/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt b/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> new file mode 100644 >> index 0000000..333080c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> @@ -0,0 +1,50 @@ >> +STMicroelectronics STM32 Peripheral Reset Controller >> +==================================================== >> + >> +The RCC IP is both a reset and a clock controller. This documentation only >> +documents the reset part. > The clock part is already documented or will do later? Either way, you > are describing an IP block, so please describe all of it now and in one > place. > > Rob The clock part is already documented. Okay to put this in one place, but in which directory ? what do you prefer ? - create a rcc directory - put the file on top, in Documentation/devicetree/bindings Best regards Gabriel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriel Fernandez Subject: Re: [PATCH 2/4] dt-bindings: Document the STM32 reset bindings Date: Wed, 6 Jul 2016 09:39:10 +0200 Message-ID: <577CB59E.1080508@st.com> References: <1467640052-6770-1-git-send-email-gabriel.fernandez@st.com> <1467640052-6770-2-git-send-email-gabriel.fernandez@st.com> <20160705161813.GA20477@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160705161813.GA20477@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Philipp Zabel , Mark Rutland , Maxime Coquelin , Russell King , patrice.chotard-qxv4g6HH51o@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Rob, Thanks for reviewing On 07/05/2016 06:18 PM, Rob Herring wrote: > On Mon, Jul 04, 2016 at 03:47:30PM +0200, gabriel.fernandez-qxv4g6HH51o@public.gmane.org wrote: >> From: Maxime Coquelin >> >> This adds documentation of device tree bindings for the >> STM32 reset controller. >> >> Signed-off-by: Maxime Coquelin >> --- >> .../devicetree/bindings/reset/st,stm32-rcc.txt | 50 ++++++++++++++++++++++ >> 1 file changed, 50 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> >> diff --git a/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt b/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> new file mode 100644 >> index 0000000..333080c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> @@ -0,0 +1,50 @@ >> +STMicroelectronics STM32 Peripheral Reset Controller >> +==================================================== >> + >> +The RCC IP is both a reset and a clock controller. This documentation only >> +documents the reset part. > The clock part is already documented or will do later? Either way, you > are describing an IP block, so please describe all of it now and in one > place. > > Rob The clock part is already documented. Okay to put this in one place, but in which directory ? what do you prefer ? - create a rcc directory - put the file on top, in Documentation/devicetree/bindings Best regards Gabriel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: gabriel.fernandez@st.com (Gabriel Fernandez) Date: Wed, 6 Jul 2016 09:39:10 +0200 Subject: [PATCH 2/4] dt-bindings: Document the STM32 reset bindings In-Reply-To: <20160705161813.GA20477@rob-hp-laptop> References: <1467640052-6770-1-git-send-email-gabriel.fernandez@st.com> <1467640052-6770-2-git-send-email-gabriel.fernandez@st.com> <20160705161813.GA20477@rob-hp-laptop> Message-ID: <577CB59E.1080508@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, Thanks for reviewing On 07/05/2016 06:18 PM, Rob Herring wrote: > On Mon, Jul 04, 2016 at 03:47:30PM +0200, gabriel.fernandez at st.com wrote: >> From: Maxime Coquelin >> >> This adds documentation of device tree bindings for the >> STM32 reset controller. >> >> Signed-off-by: Maxime Coquelin >> --- >> .../devicetree/bindings/reset/st,stm32-rcc.txt | 50 ++++++++++++++++++++++ >> 1 file changed, 50 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> >> diff --git a/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt b/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> new file mode 100644 >> index 0000000..333080c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> @@ -0,0 +1,50 @@ >> +STMicroelectronics STM32 Peripheral Reset Controller >> +==================================================== >> + >> +The RCC IP is both a reset and a clock controller. This documentation only >> +documents the reset part. > The clock part is already documented or will do later? Either way, you > are describing an IP block, so please describe all of it now and in one > place. > > Rob The clock part is already documented. Okay to put this in one place, but in which directory ? what do you prefer ? - create a rcc directory - put the file on top, in Documentation/devicetree/bindings Best regards Gabriel