From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753356AbcGFK4R (ORCPT ); Wed, 6 Jul 2016 06:56:17 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:56049 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbcGFK4P (ORCPT ); Wed, 6 Jul 2016 06:56:15 -0400 Subject: Re: [PATCH v13 1/8] perf tools: Drop redundant evsel->overwrite indicator To: Jiri Olsa References: <1467613209-191781-1-git-send-email-wangnan0@huawei.com> <1467613209-191781-2-git-send-email-wangnan0@huawei.com> <20160706105332.GA26517@krava> CC: , , , , Arnaldo Carvalho de Melo , He Kuang , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Nilay Vaish From: "Wangnan (F)" Message-ID: <577CE3A5.2090404@huawei.com> Date: Wed, 6 Jul 2016 18:55:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160706105332.GA26517@krava> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.577CE3CB.0085,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 312f6ad2e1401b3f94c4484ac8f3af0b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/7/6 18:53, Jiri Olsa wrote: > On Mon, Jul 04, 2016 at 06:20:02AM +0000, Wang Nan wrote: > > SNIP > >> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c >> index 0fea724..3abe519 100644 >> --- a/tools/perf/util/evsel.c >> +++ b/tools/perf/util/evsel.c >> @@ -1359,6 +1359,9 @@ static int __perf_evsel__open(struct perf_evsel *evsel, struct cpu_map *cpus, >> int pid = -1, err; >> enum { NO_CHANGE, SET_TO_MAX, INCREASED_MAX } set_rlimit = NO_CHANGE; >> >> + if (perf_missing_features.write_backward && evsel->attr.write_backward) >> + return -EINVAL; >> + >> if (evsel->system_wide) >> nthreads = 1; >> else >> @@ -1389,11 +1392,6 @@ fallback_missing_features: >> if (perf_missing_features.lbr_flags) >> evsel->attr.branch_sample_type &= ~(PERF_SAMPLE_BRANCH_NO_FLAGS | >> PERF_SAMPLE_BRANCH_NO_CYCLES); >> - if (perf_missing_features.write_backward) { >> - if (evsel->overwrite) >> - return -EINVAL; >> - evsel->attr.write_backward = false; >> - } > so we don't change the attr.write_backward anymore? > based on the kernel support.. We don't need fallback here. If evsel->attr.write_backward is selected and it is missing, we should fail. > we do it for other features, why not here? also changelog > did not mentioned it at all ;-) > > thanks, > jirka