From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests Date: Wed, 6 Jul 2016 12:05:48 +0100 Message-ID: <577CE60C.5030905@arm.com> References: <1467745519-9868-1-git-send-email-boris.ostrovsky@oracle.com> <1467745519-9868-21-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1467745519-9868-21-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Boris Ostrovsky , xen-devel@lists.xen.org Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, zhaoshenglong@huawei.com, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org KENDIFN0ZWZhbm8pCgpIaSBCb3JpcywKCk9uIDA1LzA3LzE2IDIwOjA1LCBCb3JpcyBPc3Ryb3Zz a3kgd3JvdGU6Cj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX2FyY2guaCBiL3Rvb2xz L2xpYnhsL2xpYnhsX2FyY2guaAo+IGluZGV4IDM0YTg1M2MuLjdjNjUzNmIgMTAwNjQ0Cj4gLS0t IGEvdG9vbHMvbGlieGwvbGlieGxfYXJjaC5oCj4gKysrIGIvdG9vbHMvbGlieGwvbGlieGxfYXJj aC5oCj4gQEAgLTYyLDQgKzYyLDcgQEAgaW50IGxpYnhsX19hcmNoX2RvbWFpbl9jb25zdHJ1Y3Rf bWVtbWFwKGxpYnhsX19nYyAqZ2MsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdWludDMyX3QgZG9taWQsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tKTsKPgo+ICtpbnQgbGlieGxfX2Rv bV9sb2FkX2FjcGkobGlieGxfX2djICpnYywKPiArCQkJIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZv ICppbmZvLAo+ICsJCQkgc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tKTsKClRoaXMgZmlsZSBjb250 YWlucyBhcmNoIHNwZWNpZmljIGZ1bmN0aW9uIHdpdGggYXJlIGNhbGxlZCBieSB0aGUgZ2VuZXJp YyAKbGlieGwgY29kZS4KCkkgZG9uJ3QgdGhpbmsgdGhpcyBpcyB0aGUgcmlnaHQgZmlsZSBmb3Ig YW4geDg2IHNwZWNpZmljIGZ1bmN0aW9uIHdoaWNoIApoYXMgYSBnZW5lcmljIG5hbWUuIElITU8s IHRoaXMgc2hvdWxkIGdvIGluIGxpYnhsX3g4Nl9hY3BpLmggd2l0aCAieDg2IiAKaW4gdGhlIG5h bWUgYW5kIHdpdGggJ19oaWRkZW4nIGF0dHJpYnV0ZS4KCj4gICAjZW5kaWYKClsuLi5dCgo+ICtz dGF0aWMgaW50IHBvcHVsYXRlX2FjcGlfcGFnZXMoc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tLAo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgeGVuX3Bmbl90ICpleHRlbnRzLAo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG51bV9wYWdlcywKPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBhY3BpX2N0eHQgKmN0eHQpCj4g K3sKPiArICAgIGludCByYzsKPiArICAgIHhjX2ludGVyZmFjZSAqeGNoID0gZG9tLT54Y2g7Cj4g KyAgICB1aW50MzJfdCBkb21pZCA9IGRvbS0+Z3Vlc3RfZG9taWQ7Cj4gKyAgICB1bnNpZ25lZCBs b25nIGlkeCwgZmlyc3RfaGlnaF9pZHggPSAoMXVsbCA8PCAoMzIgLSBjdHh0LT5wYWdlX3NoaWZ0 KSk7Cj4gKwo+ICsgICAgZm9yICg7IG51bV9wYWdlczsgbnVtX3BhZ2VzLS0sIGV4dGVudHMrKykg ewo+ICsKPiArICAgICAgICBpZiAoeGNfZG9tYWluX3BvcHVsYXRlX3BoeXNtYXAoeGNoLCBkb21p ZCwgMSwgMCwgMCwgZXh0ZW50cykgPT0gMSkKCkl0IGxvb2tzIGxpa2UgdGhpcyBpcyB3b3JraW5n IGJlY2F1c2UgbGlieGwgaXMgc2V0dGluZyB0aGUgbWF4aW11bSBzaXplIApvZiB0aGUgZG9tYWlu IHdpdGggc29tZSBzbGFjayAoMU1CKS4gWW91IG1pZ2h0IGdldCBpbiB0cm91YmxlIGlmIHRoZSAK c2xhY2sgaXMgcmVkdWNlZCBvciB1c2VkIGJ5IHNvbWVvbmUgb3IgdGhlIEFDUEkgYmxvYiBpcyBp bmNyZWFzaW5nLgoKPiArICAgICAgICAgICAgY29udGludWU7Cj4gKwo+ICsgICAgICAgIGlmIChk b20tPmhpZ2htZW1fZW5kKSB7Cj4gKyAgICAgICAgICAgIGlkeCA9IC0tZG9tLT5oaWdobWVtX2Vu ZDsKPiArICAgICAgICAgICAgaWYgKCBpZHggPT0gZmlyc3RfaGlnaF9pZHggKQo+ICsgICAgICAg ICAgICAgICAgZG9tLT5oaWdobWVtX2VuZCA9IDA7Cj4gKyAgICAgICAgfSBlbHNlCj4gKyAgICAg ICAgICAgIGlkeCA9IC0tZG9tLT5sb3dtZW1fZW5kOwo+ICsKPiArICAgICAgICByYyA9IHhjX2Rv bWFpbl9hZGRfdG9fcGh5c21hcCh4Y2gsIGRvbWlkLAo+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFhFTk1BUFNQQUNFX2dtZm4sCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaWR4LCAqZXh0ZW50cyk7Cj4gKyAgICAgICAgaWYgKHJjKQo+ICsg ICAgICAgICAgICByZXR1cm4gcmM7Cj4gKyAgICB9Cj4gKwo+ICsgICAgcmV0dXJuIDA7Cj4gK30K PiArCj4gK2ludCBsaWJ4bF9fZG9tX2xvYWRfYWNwaShsaWJ4bF9fZ2MgKmdjLAo+ICsJCQkgbGli eGxfZG9tYWluX2J1aWxkX2luZm8gKmluZm8sCj4gKwkJCSBzdHJ1Y3QgeGNfZG9tX2ltYWdlICpk b20pCj4gK3sKPiArICAgIHN0cnVjdCBhY3BpX2NvbmZpZyBjb25maWcgPSB7MH07Cj4gKyAgICBz dHJ1Y3QgYWNwaV9jdHh0IGN0eHQ7Cj4gKyAgICB1aW50MzJfdCBkb21pZCA9IGRvbS0+Z3Vlc3Rf ZG9taWQ7Cj4gKyAgICB4Y19pbnRlcmZhY2UgKnhjaCA9IGRvbS0+eGNoOwo+ICsgICAgaW50IHJj LCBpLCBhY3BpX3BhZ2VzX251bTsKPiArICAgIHhlbl9wZm5fdCBleHRlbnQsICpleHRlbnRzOwo+ ICsgICAgdm9pZCAqYWNwaV9wYWdlcywgKmd1ZXN0X2FjcGlfcGFnZXMgPSBOVUxMOwo+ICsgICAg dW5zaWduZWQgbG9uZyBwYWdlX21hc2s7Cj4gKwo+ICsgICAgaWYgKChpbmZvLT50eXBlICE9IExJ QlhMX0RPTUFJTl9UWVBFX0hWTSkgfHwKPiArICAgICAgICAoaW5mby0+ZGV2aWNlX21vZGVsX3Zl cnNpb24gIT0gTElCWExfREVWSUNFX01PREVMX1ZFUlNJT05fTk9ORSkpCj4gKyAgICAgICAgcmV0 dXJuIDA7Cj4gKwo+ICsgICAgY3R4dC5wYWdlX3NpemUgPSBYQ19ET01fUEFHRV9TSVpFKGRvbSk7 Cj4gKyAgICBjdHh0LnBhZ2Vfc2hpZnQgPSBYQ19ET01fUEFHRV9TSElGVChkb20pOwo+ICsgICAg cGFnZV9tYXNrID0gKDFVTCA8PCBjdHh0LnBhZ2Vfc2hpZnQpIC0gMTsKPiArCj4gKyAgICBjdHh0 Lm1lbV9vcHMuYWxsb2MgPSBtZW1fYWxsb2M7Cj4gKyAgICBjdHh0Lm1lbV9vcHMudjJwID0gdmly dF90b19waHlzOwo+ICsKPiArICAgIHJjID0gaW5pdF9hY3BpX2NvbmZpZyhnYywgZG9tLCBpbmZv LCAmY29uZmlnKTsKPiArICAgIGlmIChyYykgewo+ICsgICAgICAgIExPRyhFUlJPUiwgIiVzOiBp bml0X2FjcGlfY29uZmlnIGZhaWxlZCAocmM9JWQpIiwgX19GVU5DVElPTl9fLCByYyk7Cj4gKyAg ICAgICAgcmV0dXJuIHJjOwo+ICsgICAgfQo+ICsKPiArICAgIC8qIE1hcCBwYWdlIHRoYXQgd2ls bCBob2xkIFJTRFAgKi8KPiArICAgIGV4dGVudCA9IFJTRFBfQUREUkVTUyA+PiBjdHh0LnBhZ2Vf c2hpZnQ7Cj4gKyAgICByYyA9IHBvcHVsYXRlX2FjcGlfcGFnZXMoZG9tLCAmZXh0ZW50LCAxLCAm Y3R4dCk7Cj4gKyAgICBpZiAocmMpIHsKPiArICAgICAgICBMT0coRVJST1IsICIlczogcG9wdWxh dGVfYWNwaV9wYWdlcyBmb3IgcnNkcCBmYWlsZWQgd2l0aCAlZCIsCj4gKyAgICAgICAgICAgIF9f RlVOQ1RJT05fXywgcmMpOwo+ICsgICAgICAgIGdvdG8gb3V0Owo+ICsgICAgfQo+ICsgICAgY29u ZmlnLnJzZHAgPSAodW5zaWduZWQgbG9uZyl4Y19tYXBfZm9yZWlnbl9yYW5nZSh4Y2gsIGRvbWlk LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjdHh0LnBhZ2Vfc2l6ZSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgUFJPVF9SRUFEIHwgUFJPVF9XUklURSwKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUlNEUF9BRERSRVNTID4+ IGN0eHQucGFnZV9zaGlmdCk7Cj4gKyAgICBpZiAoIWNvbmZpZy5yc2RwKSB7Cj4gKyAgICAgICAg TE9HKEVSUk9SLCAiJXM6IENhbid0IG1hcCBhY3BpX3BoeXNpY2FsIiwgX19GVU5DVElPTl9fKTsK PiArICAgICAgICByYyA9IC0xOwo+ICsgICAgICAgIGdvdG8gb3V0Owo+ICsgICAgfQo+ICsKPiAr ICAgIC8qIE1hcCBhY3BpX2luZm8gcGFnZSAqLwo+ICsgICAgZXh0ZW50ID0gQUNQSV9JTkZPX1BI WVNJQ0FMX0FERFJFU1MgPj4gY3R4dC5wYWdlX3NoaWZ0Owo+ICsgICAgcmMgPSBwb3B1bGF0ZV9h Y3BpX3BhZ2VzKGRvbSwgJmV4dGVudCwgMSwgJmN0eHQpOwo+ICsgICAgaWYgKHJjKSB7Cj4gKyAg ICAgICAgTE9HKEVSUk9SLCAiJXM6IHBvcHVsYXRlX2FjcGlfcGFnZXMgZm9yIGFjcGlfaW5mbyBm YWlsZWQgd2l0aCAlZCIsCj4gKyAgICAgICAgICAgIF9fRlVOQ1RJT05fXywgcmMpOwo+ICsgICAg ICAgIGdvdG8gb3V0Owo+ICsgICAgfQo+ICsKPiArICAgIGNvbmZpZy5haW5mb3AgPSAodW5zaWdu ZWQgbG9uZyl4Y19tYXBfZm9yZWlnbl9yYW5nZSh4Y2gsIGRvbWlkLAo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGN0eHQucGFnZV9zaXpl LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFBST1RfUkVBRCB8IFBST1RfV1JJVEUsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQUNQSV9JTkZPX1BIWVNJQ0FMX0FERFJFU1Mg Pj4gY3R4dC5wYWdlX3NoaWZ0KTsKCkxvYWRpbmcgdGhlIEFDUEkgYmxvYiBvbiBBUk0gd2lsbCBi ZSB2ZXJ5IHNpbWlsYXIgZXhjZXB0IGZvciB0aGUgYmFzZSAKYWRkcmVzcy4gU28gaXQgd291bGQg YmUgbmljZSB0byBzaGFyZSBzb21lIGNvZGUgd2l0aCBpdC4KCkhvd2V2ZXIsIGFzIG1lbnRpb25l ZCBpbiB0aGUgQUNQSSB0aHJlYWQgWzFdLCBhbGwgdGhlIGJsb2JzIGFyZSAKZ2VuZXJhbGx5IGxv YWRlZCBieSBsaWJ4YyBhbmQgbm90IGxpYnhsLiBUaGlzIGlzIG1vcmUgdHJ1ZSBvbiBBUk0gCmJl Y2F1c2UgdGhlIGd1ZXN0IGFkZHJlc3Mgc3BhY2UgaXMgY29udHJvbGxlZCBieSBsaWJ4YyAodGhl IHBvc2l0aW9uIG9mIAphbGwgdGhlIGJsb2IgYXJlIGRlY2lkZWQgYnkgaXQpLgoKUmVnYXJkcywK ClsxXSAKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9hcmNoaXZlcy9odG1sL3hlbi1kZXZl bC8yMDE2LTA3L21zZzAwMDQwLmh0bWwKCi0tIApKdWxpZW4gR3JhbGwKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QK WGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=