From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests Date: Wed, 6 Jul 2016 17:04:04 +0100 Message-ID: <577D2BF4.5020309@arm.com> References: <1467745519-9868-1-git-send-email-boris.ostrovsky@oracle.com> <1467745519-9868-21-git-send-email-boris.ostrovsky@oracle.com> <577CE60C.5030905@arm.com> <71cc1261-6a98-9a83-0fe2-11b3a82b9706@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <71cc1261-6a98-9a83-0fe2-11b3a82b9706@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Boris Ostrovsky , xen-devel@lists.xen.org Cc: Stefano Stabellini , wei.liu2@citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, zhaoshenglong@huawei.com, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org SGkgQm9yaXMsCgpPbiAwNi8wNy8xNiAxNjo1MCwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOgo+IE9u IDA3LzA2LzIwMTYgMDc6MDUgQU0sIEp1bGllbiBHcmFsbCB3cm90ZToKPj4+ICtzdGF0aWMgaW50 IHBvcHVsYXRlX2FjcGlfcGFnZXMoc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tLAo+Pj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB4ZW5fcGZuX3QgKmV4dGVudHMsCj4+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBudW1fcGFnZXMsCj4+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBhY3BpX2N0eHQgKmN0eHQpCj4+PiAr ewo+Pj4gKyAgICBpbnQgcmM7Cj4+PiArICAgIHhjX2ludGVyZmFjZSAqeGNoID0gZG9tLT54Y2g7 Cj4+PiArICAgIHVpbnQzMl90IGRvbWlkID0gZG9tLT5ndWVzdF9kb21pZDsKPj4+ICsgICAgdW5z aWduZWQgbG9uZyBpZHgsIGZpcnN0X2hpZ2hfaWR4ID0gKDF1bGwgPDwgKDMyIC0KPj4+IGN0eHQt PnBhZ2Vfc2hpZnQpKTsKPj4+ICsKPj4+ICsgICAgZm9yICg7IG51bV9wYWdlczsgbnVtX3BhZ2Vz LS0sIGV4dGVudHMrKykgewo+Pj4gKwo+Pj4gKyAgICAgICAgaWYgKHhjX2RvbWFpbl9wb3B1bGF0 ZV9waHlzbWFwKHhjaCwgZG9taWQsIDEsIDAsIDAsIGV4dGVudHMpCj4+PiA9PSAxKQo+Pgo+PiBJ dCBsb29rcyBsaWtlIHRoaXMgaXMgd29ya2luZyBiZWNhdXNlIGxpYnhsIGlzIHNldHRpbmcgdGhl IG1heGltdW0KPj4gc2l6ZSBvZiB0aGUgZG9tYWluIHdpdGggc29tZSBzbGFjayAoMU1CKS4gWW91 IG1pZ2h0IGdldCBpbiB0cm91YmxlIGlmCj4+IHRoZSBzbGFjayBpcyByZWR1Y2VkIG9yIHVzZWQg Ynkgc29tZW9uZSBvciB0aGUgQUNQSSBibG9iIGlzIGluY3JlYXNpbmcuCj4KPgo+IEkgc2F3IHlv dXIgY29udmVyc2F0aW9uIGFib3V0IHNsYWNrIHdpdGggU3RlZmFubyBhbmQgSSBhbSBub3Qgc3Vy ZSBJCj4gdW5kZXJzdG9vZCB3aGF0IGl0IHdhcyBhYm91dC4gSWYgdGhpcyB3YXMgYWJvdXQgcGFk ZGluZyBndWVzdCdzIG1lbW9yeQo+IHRvIGJlIGFibGUgdG8gcHV0IHRoZXJlIHNvbWUgYWRkaXRp b25hbCBkYXRhIChzdWNoIEFDUEkgdGFibGVzKSB0aGVuCj4gdGhpcyBpcyBub3QgbXkgaW50ZW50 aW9uIGhlcmU6IGlmIEkgY2FuJ3QgcG9wdWxhdGUgKGJlY2F1c2UgaXQgaXMKPiBhbHJlYWR5IHBv cHVsYXRlZCwgSSBndWVzcykgdGhlbiBJIHRyeSB0byBtb3ZlIG1lbW9yeSBhcm91bmQgd2l0aCBj b2RlCj4gYmVsb3cuIFRoYXQncyB3aGF0IG1lbV9ob2xlX3BvcHVsYXRlX3JhbSgpIGRvZXMgYXMg d2VsbC4KClRoZSBtYXhpbXVtIGFtb3VudCBvZiBtZW1vcnkgdGhhdCBjb3VsZCBiZSBhc3NpZ25l ZCB0byBhIGRvbWFpbiBpcyBmaXhlZCAKcGVyLWRvbWFpbi4gVGhpcyBtYXhpbXVtIGFtb3VudCBk b2VzIG5vdCB0YWtlIGludG8gYWNjb3VudCB0aGUgc2l6ZSBvZiAKdGhlIEFDUEkgYmxvYi4gU28g eW91IG1heSBlbmQgdXAgdG8gZmFpbCBiZWNhdXNlIGFsbCB0aGUgbWVtb3J5IHdhcyAKYXNzaWdu ZWQgc29tZXdoZXJlIGVsc2UuCgo+Cj4+Cj4+PiArICAgICAgICAgICAgY29udGludWU7Cj4+PiAr Cj4+PiArICAgICAgICBpZiAoZG9tLT5oaWdobWVtX2VuZCkgewo+Pj4gKyAgICAgICAgICAgIGlk eCA9IC0tZG9tLT5oaWdobWVtX2VuZDsKPj4+ICsgICAgICAgICAgICBpZiAoIGlkeCA9PSBmaXJz dF9oaWdoX2lkeCApCj4+PiArICAgICAgICAgICAgICAgIGRvbS0+aGlnaG1lbV9lbmQgPSAwOwo+ Pj4gKyAgICAgICAgfSBlbHNlCj4+PiArICAgICAgICAgICAgaWR4ID0gLS1kb20tPmxvd21lbV9l bmQ7Cj4+PiArCj4+PiArICAgICAgICByYyA9IHhjX2RvbWFpbl9hZGRfdG9fcGh5c21hcCh4Y2gs IGRvbWlkLAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWEVOTUFQ U1BBQ0VfZ21mbiwKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlk eCwgKmV4dGVudHMpOwo+Pj4gKyAgICAgICAgaWYgKHJjKQo+Pj4gKyAgICAgICAgICAgIHJldHVy biByYzsKPj4+ICsgICAgfQo+Pj4gKwo+Pj4gKyAgICByZXR1cm4gMDsKPj4+ICt9Cj4+PiArCj4+ PiAraW50IGxpYnhsX19kb21fbG9hZF9hY3BpKGxpYnhsX19nYyAqZ2MsCj4+PiArICAgICAgICAg ICAgIGxpYnhsX2RvbWFpbl9idWlsZF9pbmZvICppbmZvLAo+Pj4gKyAgICAgICAgICAgICBzdHJ1 Y3QgeGNfZG9tX2ltYWdlICpkb20pCj4+PiArewo+Pj4gKyAgICBzdHJ1Y3QgYWNwaV9jb25maWcg Y29uZmlnID0gezB9Owo+Pj4gKyAgICBzdHJ1Y3QgYWNwaV9jdHh0IGN0eHQ7Cj4+PiArICAgIHVp bnQzMl90IGRvbWlkID0gZG9tLT5ndWVzdF9kb21pZDsKPj4+ICsgICAgeGNfaW50ZXJmYWNlICp4 Y2ggPSBkb20tPnhjaDsKPj4+ICsgICAgaW50IHJjLCBpLCBhY3BpX3BhZ2VzX251bTsKPj4+ICsg ICAgeGVuX3Bmbl90IGV4dGVudCwgKmV4dGVudHM7Cj4+PiArICAgIHZvaWQgKmFjcGlfcGFnZXMs ICpndWVzdF9hY3BpX3BhZ2VzID0gTlVMTDsKPj4+ICsgICAgdW5zaWduZWQgbG9uZyBwYWdlX21h c2s7Cj4+PiArCj4+PiArICAgIGlmICgoaW5mby0+dHlwZSAhPSBMSUJYTF9ET01BSU5fVFlQRV9I Vk0pIHx8Cj4+PiArICAgICAgICAoaW5mby0+ZGV2aWNlX21vZGVsX3ZlcnNpb24gIT0KPj4+IExJ QlhMX0RFVklDRV9NT0RFTF9WRVJTSU9OX05PTkUpKQo+Pj4gKyAgICAgICAgcmV0dXJuIDA7Cj4+ PiArCj4+PiArICAgIGN0eHQucGFnZV9zaXplID0gWENfRE9NX1BBR0VfU0laRShkb20pOwo+Pj4g KyAgICBjdHh0LnBhZ2Vfc2hpZnQgPSBYQ19ET01fUEFHRV9TSElGVChkb20pOwo+Pj4gKyAgICBw YWdlX21hc2sgPSAoMVVMIDw8IGN0eHQucGFnZV9zaGlmdCkgLSAxOwo+Pj4gKwo+Pj4gKyAgICBj dHh0Lm1lbV9vcHMuYWxsb2MgPSBtZW1fYWxsb2M7Cj4+PiArICAgIGN0eHQubWVtX29wcy52MnAg PSB2aXJ0X3RvX3BoeXM7Cj4+PiArCj4+PiArICAgIHJjID0gaW5pdF9hY3BpX2NvbmZpZyhnYywg ZG9tLCBpbmZvLCAmY29uZmlnKTsKPj4+ICsgICAgaWYgKHJjKSB7Cj4+PiArICAgICAgICBMT0co RVJST1IsICIlczogaW5pdF9hY3BpX2NvbmZpZyBmYWlsZWQgKHJjPSVkKSIsCj4+PiBfX0ZVTkNU SU9OX18sIHJjKTsKPj4+ICsgICAgICAgIHJldHVybiByYzsKPj4+ICsgICAgfQo+Pj4gKwo+Pj4g KyAgICAvKiBNYXAgcGFnZSB0aGF0IHdpbGwgaG9sZCBSU0RQICovCj4+PiArICAgIGV4dGVudCA9 IFJTRFBfQUREUkVTUyA+PiBjdHh0LnBhZ2Vfc2hpZnQ7Cj4+PiArICAgIHJjID0gcG9wdWxhdGVf YWNwaV9wYWdlcyhkb20sICZleHRlbnQsIDEsICZjdHh0KTsKPj4+ICsgICAgaWYgKHJjKSB7Cj4+ PiArICAgICAgICBMT0coRVJST1IsICIlczogcG9wdWxhdGVfYWNwaV9wYWdlcyBmb3IgcnNkcCBm YWlsZWQgd2l0aCAlZCIsCj4+PiArICAgICAgICAgICAgX19GVU5DVElPTl9fLCByYyk7Cj4+PiAr ICAgICAgICBnb3RvIG91dDsKPj4+ICsgICAgfQo+Pj4gKyAgICBjb25maWcucnNkcCA9ICh1bnNp Z25lZCBsb25nKXhjX21hcF9mb3JlaWduX3JhbmdlKHhjaCwgZG9taWQsCj4+PiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3R4dC5wYWdlX3Np emUsCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgUFJPVF9SRUFEIHwKPj4+IFBST1RfV1JJVEUsCj4+PiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUlNEUF9BRERSRVNTCj4+Pj4+IGN0 eHQucGFnZV9zaGlmdCk7Cj4+PiArICAgIGlmICghY29uZmlnLnJzZHApIHsKPj4+ICsgICAgICAg IExPRyhFUlJPUiwgIiVzOiBDYW4ndCBtYXAgYWNwaV9waHlzaWNhbCIsIF9fRlVOQ1RJT05fXyk7 Cj4+PiArICAgICAgICByYyA9IC0xOwo+Pj4gKyAgICAgICAgZ290byBvdXQ7Cj4+PiArICAgIH0K Pj4+ICsKPj4+ICsgICAgLyogTWFwIGFjcGlfaW5mbyBwYWdlICovCj4+PiArICAgIGV4dGVudCA9 IEFDUElfSU5GT19QSFlTSUNBTF9BRERSRVNTID4+IGN0eHQucGFnZV9zaGlmdDsKPj4+ICsgICAg cmMgPSBwb3B1bGF0ZV9hY3BpX3BhZ2VzKGRvbSwgJmV4dGVudCwgMSwgJmN0eHQpOwo+Pj4gKyAg ICBpZiAocmMpIHsKPj4+ICsgICAgICAgIExPRyhFUlJPUiwgIiVzOiBwb3B1bGF0ZV9hY3BpX3Bh Z2VzIGZvciBhY3BpX2luZm8gZmFpbGVkCj4+PiB3aXRoICVkIiwKPj4+ICsgICAgICAgICAgICBf X0ZVTkNUSU9OX18sIHJjKTsKPj4+ICsgICAgICAgIGdvdG8gb3V0Owo+Pj4gKyAgICB9Cj4+PiAr Cj4+PiArICAgIGNvbmZpZy5haW5mb3AgPSAodW5zaWduZWQgbG9uZyl4Y19tYXBfZm9yZWlnbl9y YW5nZSh4Y2gsIGRvbWlkLAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY3R4dC5wYWdlX3NpemUsCj4+PiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQUk9UX1JFQUQgfAo+Pj4g UFJPVF9XUklURSwKPj4+ICsKPj4+IEFDUElfSU5GT19QSFlTSUNBTF9BRERSRVNTID4+IGN0eHQu cGFnZV9zaGlmdCk7Cj4+Cj4+IExvYWRpbmcgdGhlIEFDUEkgYmxvYiBvbiBBUk0gd2lsbCBiZSB2 ZXJ5IHNpbWlsYXIgZXhjZXB0IGZvciB0aGUgYmFzZQo+PiBhZGRyZXNzLiBTbyBpdCB3b3VsZCBi ZSBuaWNlIHRvIHNoYXJlIHNvbWUgY29kZSB3aXRoIGl0Lgo+Pgo+PiBIb3dldmVyLCBhcyBtZW50 aW9uZWQgaW4gdGhlIEFDUEkgdGhyZWFkIFsxXSwgYWxsIHRoZSBibG9icyBhcmUKPj4gZ2VuZXJh bGx5IGxvYWRlZCBieSBsaWJ4YyBhbmQgbm90IGxpYnhsLiBUaGlzIGlzIG1vcmUgdHJ1ZSBvbiBB Uk0KPj4gYmVjYXVzZSB0aGUgZ3Vlc3QgYWRkcmVzcyBzcGFjZSBpcyBjb250cm9sbGVkIGJ5IGxp YnhjICh0aGUgcG9zaXRpb24KPj4gb2YgYWxsIHRoZSBibG9iIGFyZSBkZWNpZGVkIGJ5IGl0KS4K Pgo+IFRoZSBkaWZmZXJlbmNlIGlzIHRoYXQgSSBub3Qgb25seSBsb2FkIHRoZSB0YWJsZXMgaGVy ZSBidXQgYWxzbyBidWlsZAo+IHRoZW0uIFdoaWNoIG1heSBvciBtYXkgbm90IGJlIHRoZSByaWdo dCB0aGluZyB0byBkbyBpbiBsaWJ4Yy4KPgo+IEkgc3VwcG9zZSBJIGNhbiBkZWZlciBsb2FkaW5n IChhbmQgdGhlbiBrZWVwIHBvaW50ZXIgdG8gdGFibGVzIGluCj4gYWNwaXRhYmxlX2Jsb2IpIGJ1 dCB0aGUgdGhlbiBJIG5lZWQgdG8ga2VlcCBSU0RQIGRlc2NyaXB0b3Igc29tZXdoZXJlCj4gZWxz ZSAoaXQgaXMgbm90IHBhcnQgb2YgdGhlIGJsb2Igc2luY2UgaXQgbGl2ZXMgaW4gbG93ZXIgTUIg b2YgdGhlIGd1ZXN0KS4KClRoZSBkZXZpY2UgdHJlZSBmb3IgQVJNIGFyZSBidWlsdCBpbiBsaWJ4 bCBhbmQgbG9hZGVkIGZvciBsaWJ4Yy4gSUhNTywgCml0IHdvdWxkIGJlIHN0cmFuZ2UgdG8gaGF2 ZSBhIGRpZmZlcmVudCBwYXR0ZXJuIGZvciBBQ1BJLgoKUmVnYXJkcywKCi0tIApKdWxpZW4gR3Jh bGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54 ZW4ub3JnL3hlbi1kZXZlbAo=