From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 6/6] ena: fix for icc compiler
Date: Fri, 8 Jul 2016 15:07:02 +0100
Message-ID: <577FB386.7090907@intel.com>
References: <1466510763-19569-6-git-send-email-jan@semihalf.com>
 <1467299099-32498-1-git-send-email-jan@semihalf.com>
 <1467299099-32498-7-git-send-email-jan@semihalf.com>
 <577B7539.3000007@intel.com> <20160708132342.GA20808@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Cc: Jan Medala <jan@semihalf.com>, dev@dpdk.org,
 Alexander Matushevsky <matua@amazon.com>, Jakub Palider <jpa@semihalf.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 1ED016CD1
 for <dev@dpdk.org>; Fri,  8 Jul 2016 16:07:15 +0200 (CEST)
In-Reply-To: <20160708132342.GA20808@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/8/2016 2:23 PM, Bruce Richardson wrote:
> On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote:
>> On 6/30/2016 4:04 PM, Jan Medala wrote:
>>> Signed-off-by: Alexander Matushevsky <matua@amazon.com>
>>> Signed-off-by: Jakub Palider <jpa@semihalf.com>
>>> Signed-off-by: Jan Medala <jan@semihalf.com>
>>
>> The compilation error to fix is [1], it may be good to add what to fix
>> into commit log.
>>
>> [1]
>> =3D=3D Build drivers/net/ena
>>   CC ena_ethdev.o
>> /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943): erro=
r
>> #188: enumerated type mixed with another type
>>         struct ena_com_create_io_ctx ctx =3D { 0 };
>>                                              ^
>>
>> /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036): err=
or
>> #188: enumerated type mixed with another type
>>         struct ena_com_create_io_ctx ctx =3D { 0 };
>>                                              ^
>> ...
>>
>>> --- a/drivers/net/ena/ena_ethdev.c
>>> +++ b/drivers/net/ena/ena_ethdev.c
>>> @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct rte_eth_dev=
 *dev,
>>>  			      __rte_unused unsigned int socket_id,
>>>  			      __rte_unused const struct rte_eth_txconf *tx_conf)
>>>  {
>>> -	struct ena_com_create_io_ctx ctx =3D { 0 };
>>> +	struct ena_com_create_io_ctx ctx =3D
>>> +		/* policy set to _HOST just to satisfy icc compiler */
>>> +		{ ENA_ADMIN_PLACEMENT_POLICY_HOST,
>>> +		  ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 };
>>
>> Trailing "0" are not required, compiler will take care of them.
>>
> Actually, given that this is a structure init and not an array, the tra=
iling=20
> zeros are actually required, since we are not using C99 designated init=
ializers.
As far as I know same thing is valid for both array and struct.
uninitialized values set to default values.


c.c:
----
struct mys {
        int a;
        int b;
        int c;
};

int main(int argc, char *argv[])
{
        struct mys s =3D {99};

        return 0;
}

gcc -S -std=3Dc90 c.c

c.s:
----
...
        movl    %edi, -20(%rbp)
        movq    %rsi, -32(%rbp)
        movq    $0, -16(%rbp)   <----
        movl    $0, -8(%rbp)    <----
        movl    $99, -16(%rbp)
        movl    $0, %eax
        popq    %rbp
        ret
...


> Therefore, I'll leave the zeros in - if anyone wants to convert the for=
mat of
> the initializers to c99 style later, and remove the trailing zeros then=
, it can
> go as a separate patch. I'll just merge this fix in with patch 1 that i=
ntroduces
> the issue.
>=20
> /Bruce
>=20