From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbcGLIuF (ORCPT ); Tue, 12 Jul 2016 04:50:05 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:19878 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbcGLIuC (ORCPT ); Tue, 12 Jul 2016 04:50:02 -0400 X-AuditID: cbfec7f4-f796c6d000001486-35-5784af36be57 Subject: Re: [PATCH 1/2] soc: samsung: Change type of PMU configuration register value to u32 To: Abhilash Kesavan References: <1467750507-13853-1-git-send-email-a.kesavan@samsung.com> <1467750507-13853-2-git-send-email-a.kesavan@samsung.com> Cc: linux-samsung-soc , linux-arm-kernel , Kukjin Kim , "linux-kernel@vger.kernel.org" From: Krzysztof Kozlowski Message-id: <5784AF35.9080302@samsung.com> Date: Tue, 12 Jul 2016 10:49:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xa7pm61vCDb7Mt7F4/cLQYs1fJYve BVfZLDY9vsZqcXnXHDaLGef3MTmweeycdZfdY/OSeo++LasYPT5vkgtgieKySUnNySxLLdK3 S+DKuHR8FXvBc+6Kqw/vszcwHuTsYuTkkBAwkdj2Zgs7hC0mceHeejYQW0hgKaPE3A7bLkYu IPsZo8TE6ZdYQBLCAvESO57OZgKxRQQMJd7vfMsOUdTPJPF85zsWEIdZ4DajxKw108Cq2ASM JTYvXwI2lldAS2LvtFlg61gEVCUOdBxjBbFFBSIkZm3/wQRRIyjxY/I9sG2cAsESC369AKrn ABqqLjFlSi5ImFlAXmLzmrfMExgFZiHpmIVQNQtJ1QJG5lWMoqmlyQXFSem5hnrFibnFpXnp esn5uZsYIaH8ZQfj4mNWhxgFOBiVeHgfnG4OF2JNLCuuzD3EKMHBrCTC+3lVS7gQb0piZVVq UX58UWlOavEhRmkOFiVx3rm73ocICaQnlqRmp6YWpBbBZJk4OKUaGLU+S+v+atyU39af6BHi /S/+qP2sZ18T3ydsnzM5WkrtUOcx+f3Pfs3JP6xbact890jArut5DX67Hlklc6g+CX0eysoW dvmh1yaZN97Wb74USvgLOFx90bY+bpG+ys4X5VsKj7FIVB9a1Dn/uWv1s9q1536UqYc3hPh9 sZ3HFl/IOEHkw+KtP5VYijMSDbWYi4oTAU7v1tdhAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2016 04:44 PM, Abhilash Kesavan wrote: > Hi Krzysztof, > > On Wed, Jul 6, 2016 at 8:47 AM, Krzysztof Kozlowski > wrote: >> On Tue, Jul 5, 2016 at 10:28 PM, Abhilash Kesavan wrote: >>> Exynos7 has certain PMU registers that needs to be configured with >>> u32 values. >>> >>> Signed-off-by: Abhilash Kesavan >>> --- >>> drivers/soc/samsung/exynos-pmu.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/soc/samsung/exynos-pmu.h b/drivers/soc/samsung/exynos-pmu.h >>> index a469e36..1bdc506 100644 >>> --- a/drivers/soc/samsung/exynos-pmu.h >>> +++ b/drivers/soc/samsung/exynos-pmu.h >>> @@ -18,7 +18,7 @@ >>> >>> struct exynos_pmu_conf { >>> unsigned int offset; >>> - u8 val[NUM_SYS_POWERDOWN]; >>> + unsigned int val[NUM_SYS_POWERDOWN]; >> >> You mentioned u32 but I see unsigned int here. This should be u32. > Will change. >> >> BTW, none of your emails reached my samsung inbox. I got them only >> from the lists. Please investigate why this couldn't be delivered to >> samsung.com address. > > Not quite sure why that happened even after I added you as a > recipient. I'll be posting some patches soon, let's see if the same > occurs again or if it was a one-off case. No problem with these mails so either this was one time issue or it was caused by git-send-email and company's SMTP server. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Tue, 12 Jul 2016 10:49:57 +0200 Subject: [PATCH 1/2] soc: samsung: Change type of PMU configuration register value to u32 In-Reply-To: References: <1467750507-13853-1-git-send-email-a.kesavan@samsung.com> <1467750507-13853-2-git-send-email-a.kesavan@samsung.com> Message-ID: <5784AF35.9080302@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/11/2016 04:44 PM, Abhilash Kesavan wrote: > Hi Krzysztof, > > On Wed, Jul 6, 2016 at 8:47 AM, Krzysztof Kozlowski > wrote: >> On Tue, Jul 5, 2016 at 10:28 PM, Abhilash Kesavan wrote: >>> Exynos7 has certain PMU registers that needs to be configured with >>> u32 values. >>> >>> Signed-off-by: Abhilash Kesavan >>> --- >>> drivers/soc/samsung/exynos-pmu.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/soc/samsung/exynos-pmu.h b/drivers/soc/samsung/exynos-pmu.h >>> index a469e36..1bdc506 100644 >>> --- a/drivers/soc/samsung/exynos-pmu.h >>> +++ b/drivers/soc/samsung/exynos-pmu.h >>> @@ -18,7 +18,7 @@ >>> >>> struct exynos_pmu_conf { >>> unsigned int offset; >>> - u8 val[NUM_SYS_POWERDOWN]; >>> + unsigned int val[NUM_SYS_POWERDOWN]; >> >> You mentioned u32 but I see unsigned int here. This should be u32. > Will change. >> >> BTW, none of your emails reached my samsung inbox. I got them only >> from the lists. Please investigate why this couldn't be delivered to >> samsung.com address. > > Not quite sure why that happened even after I added you as a > recipient. I'll be posting some patches soon, let's see if the same > occurs again or if it was a one-off case. No problem with these mails so either this was one time issue or it was caused by git-send-email and company's SMTP server. Best regards, Krzysztof