From: Jens Axboe <axboe@kernel.dk>
To: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] block: atari: Return early for unsupported sector size
Date: Wed, 13 Jul 2016 09:32:11 -0700 [thread overview]
Message-ID: <57866D0B.2020608@kernel.dk> (raw)
In-Reply-To: <1467736712-11825-1-git-send-email-krisman@linux.vnet.ibm.com>
On 07/05/2016 09:38 AM, Gabriel Krisman Bertazi wrote:
> For 4K LBA or very large disks, atari_partition can easily get tricked
> into thinking it has found an Atari partition table. Depending on the
> data in the disk, it ends up creating partitions with awkward lengths.
>
> We saw logs like this while playing with fio.
>
> [5.625867] nvme2n1: AHDI p2
> [5.625872] nvme2n1: p2 size 2910030523 extends beyond EOD, truncated
>
> People has had issues with misinterpreted AHDI partition tables for a long
> time, see this BSD thread from 1995, for example.
>
> https://mail-index.netbsd.org/port-atari/1995/11/19/0001.html
>
> Since the atari partition, according to the spec, doesn't even support
> sector sizes with more than 512, a quick sanity check is reasonable to
> just bail out early, before even attempting to read sector 0.
Added for 4.8, thanks.
--
Jens Axboe
prev parent reply other threads:[~2016-07-13 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 16:38 [PATCH] block: atari: Return early for unsupported sector size Gabriel Krisman Bertazi
2016-07-13 1:42 ` Gabriel Krisman Bertazi
2016-07-13 16:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57866D0B.2020608@kernel.dk \
--to=axboe@kernel.dk \
--cc=krisman@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.