From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNiQl-00041l-LC for qemu-devel@nongnu.org; Thu, 14 Jul 2016 11:20:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNiQk-0000W2-Pc for qemu-devel@nongnu.org; Thu, 14 Jul 2016 11:20:03 -0400 References: <1468503826-10617-1-git-send-email-marcel@redhat.com> <1468503826-10617-2-git-send-email-marcel@redhat.com> From: Marcel Apfelbaum Message-ID: <5787AD95.3080100@redhat.com> Date: Thu, 14 Jul 2016 18:19:49 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, rth@twiddle.net, aurelien@aurel32.net, leon.alrae@imgtec.com, agraf@suse.de, peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk, mst@redhat.com On 07/14/2016 04:51 PM, Thomas Huth wrote: > On 14.07.2016 15:43, Marcel Apfelbaum wrote: >> On a slower machine the test can take more than 30 seconds. >> Increase the timeout to 100 seconds. >> >> Signed-off-by: Marcel Apfelbaum >> --- >> tests/prom-env-test.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c >> index 6df57d2..7a62857 100644 >> --- a/tests/prom-env-test.c >> +++ b/tests/prom-env-test.c >> @@ -30,7 +30,7 @@ static void check_guest_memory(void) >> int i; >> >> /* Poll until code has run and modified memory. Wait at most 30 seconds */ >> - for (i = 0; i < 3000; ++i) { >> + for (i = 0; i < 10000; ++i) { >> signature = readl(ADDRESS); >> if (signature == MAGIC) { >> break; > > Ack, but could you please also update the comment before the for-loop? > Sure, I'll take care of it once I'll get comments for the other patches. Thanks, Marcel > Thanks, > Thomas >