From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbcGOHgi (ORCPT ); Fri, 15 Jul 2016 03:36:38 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:8726 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbcGOHge (ORCPT ); Fri, 15 Jul 2016 03:36:34 -0400 X-AuditID: cbfec7f5-f792a6d000001302-62-5788927fcc3f Subject: Re: ARM: dts: exynos: Properly select eMMC HighSpeed mode To: Alim Akhtar , Jaehoon Chung , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1468500458-7142-1-git-send-email-k.kozlowski@samsung.com> <578857FD.7030601@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <5788927E.2050803@samsung.com> Date: Fri, 15 Jul 2016 09:36:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <578857FD.7030601@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsVy+t/xy7r1kzrCDT4uMLJ4MG8bm8XGGetZ LeYfOcdqceNXG6vF6xeGFv2PXzNbbHp8jdXi8q45bBYzzu9jcuD02LSqk81j85J6j74tqxg9 Pm+SC2CJ4rJJSc3JLEst0rdL4MqYcfo+a8EvgYpvf66zNTDu4u1i5OCQEDCR2LO8tIuRE8gU k7hwbz1bFyMXh5DAUkaJD1u72UASQgLPGCUmv4gBsYUFnCRe/L0BFhcR+Mko8ft6BURNukTX 9YlgcWYBC4mtW1ezg9hsAsYSm5cvAYvzCmhJbHz1DSzOIqAq8WTyYVYQW1QgQmLW9h9MEDWC Ej8m32MBsTkFtCW6X/SzgtzJLKAncf+iFsR4eYnNa94yT2AUmIWkYxZC1SwkVQsYmVcxiqaW JhcUJ6XnGukVJ+YWl+al6yXn525ihAT51x2MS49ZHWIU4GBU4uHdcag9XIg1say4MvcQowQH s5IIL+vEjnAh3pTEyqrUovz4otKc1OJDjNIcLErivDN3vQ8B+j2xJDU7NbUgtQgmy8TBKdXA WLv9scdJubUr+izWxy2WnBa6lNFTN0U2d1qXkfjFaQY/L6zbw/jiv7bqtdv1H1e/KlTaVPK3 6bzAjucabooOCzNd/d6lz9gf+iRgRW/ilS2KS72OFIQxdh69dSwu2SaL2936tNlW541l62pW G042S++zve+WUDLzweKgs5KHq28tyjb9bLDgqBJLcUaioRZzUXEiADQhvr9uAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 05:26 AM, Alim Akhtar wrote: > Hi Krzysztof, > > On 07/14/2016 06:17 PM, Krzysztof Kozlowski wrote: >> Exynos5410 supports eMMC version 4.41 so HS200 is the top mode which >> should be configured. This is reflected in usage of >> "samsung,exynos5250-dw-mshc" compatible. However DTS contained also >> property "mmc-hs400-1_8v" which is parsed by MMC core therefore >> resulting in mixed configuration. MMC core set HS400 but dwmmc_exynos >> driver did not configure the data strobe for HS400 DDR mode. >> >> Removal of HS400 properties fixes semi-random mmc errors during boot: >> mmc_host mmc0: Bus speed (slot 0) = 400000000Hz (slot req >> 200000000Hz, actual 200000000HZ div = 1) >> mmc0: mmc_select_hs400 failed, error -84 >> mmc0: error -84 whilst initialising MMC card >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts >> b/arch/arm/boot/dts/exynos5410-odroidxu.dts >> index d9499310a301..7536164438ca 100644 >> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts >> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts >> @@ -447,14 +447,12 @@ >> samsung,dw-mshc-ciu-div = <3>; >> samsung,dw-mshc-sdr-timing = <0 4>; >> samsung,dw-mshc-ddr-timing = <0 2>; >> - samsung,dw-mshc-hs400-timing = <0 2>; > not sure but can we use /delete-property/ option for this removable? No need for this. This property is set only here - in Odroid XU DTS. >> samsung,read-strobe-delay = <90>; > this also need to be removed. Ah, right, thanks! >> pinctrl-names = "default"; >> pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 >> &sd0_cd>; >> bus-width = <8>; >> cap-mmc-highspeed; >> mmc-hs200-1_8v; >> - mmc-hs400-1_8v; > same as above if possible use /delete-property/ Same, no need because this does not come from other DTS/DTSI. >> vmmc-supply = <&ldo20_reg>; >> vqmmc-supply = <&ldo11_reg>; >> }; >> > Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 15 Jul 2016 09:36:30 +0200 Subject: ARM: dts: exynos: Properly select eMMC HighSpeed mode In-Reply-To: <578857FD.7030601@samsung.com> References: <1468500458-7142-1-git-send-email-k.kozlowski@samsung.com> <578857FD.7030601@samsung.com> Message-ID: <5788927E.2050803@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/15/2016 05:26 AM, Alim Akhtar wrote: > Hi Krzysztof, > > On 07/14/2016 06:17 PM, Krzysztof Kozlowski wrote: >> Exynos5410 supports eMMC version 4.41 so HS200 is the top mode which >> should be configured. This is reflected in usage of >> "samsung,exynos5250-dw-mshc" compatible. However DTS contained also >> property "mmc-hs400-1_8v" which is parsed by MMC core therefore >> resulting in mixed configuration. MMC core set HS400 but dwmmc_exynos >> driver did not configure the data strobe for HS400 DDR mode. >> >> Removal of HS400 properties fixes semi-random mmc errors during boot: >> mmc_host mmc0: Bus speed (slot 0) = 400000000Hz (slot req >> 200000000Hz, actual 200000000HZ div = 1) >> mmc0: mmc_select_hs400 failed, error -84 >> mmc0: error -84 whilst initialising MMC card >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts >> b/arch/arm/boot/dts/exynos5410-odroidxu.dts >> index d9499310a301..7536164438ca 100644 >> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts >> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts >> @@ -447,14 +447,12 @@ >> samsung,dw-mshc-ciu-div = <3>; >> samsung,dw-mshc-sdr-timing = <0 4>; >> samsung,dw-mshc-ddr-timing = <0 2>; >> - samsung,dw-mshc-hs400-timing = <0 2>; > not sure but can we use /delete-property/ option for this removable? No need for this. This property is set only here - in Odroid XU DTS. >> samsung,read-strobe-delay = <90>; > this also need to be removed. Ah, right, thanks! >> pinctrl-names = "default"; >> pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 >> &sd0_cd>; >> bus-width = <8>; >> cap-mmc-highspeed; >> mmc-hs200-1_8v; >> - mmc-hs400-1_8v; > same as above if possible use /delete-property/ Same, no need because this does not come from other DTS/DTSI. >> vmmc-supply = <&ldo20_reg>; >> vqmmc-supply = <&ldo11_reg>; >> }; >> > Best regards, Krzysztof