From: Julien Grall <julien.grall@arm.com>
To: Corneliu ZUZU <czuzu@bitdefender.com>, xen-devel@lists.xen.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v4 4/7] asm/atomic.h: common prototyping (add xen/atomic.h)
Date: Fri, 15 Jul 2016 10:30:29 +0100 [thread overview]
Message-ID: <5788AD35.3030301@arm.com> (raw)
In-Reply-To: <1468565413-32716-1-git-send-email-czuzu@bitdefender.com>
On 15/07/16 07:50, Corneliu ZUZU wrote:
> Create a common-side <xen/atomic.h> to establish, among others, prototypes of
> atomic functions called from common-code. Done to avoid introducing
> inconsistencies between arch-side <asm/atomic.h> headers when we make subtle
> changes to one of them. Some arm-side macros had to be turned into inline
> functions in the process (also updated README.LinuxPrimitives file).
>
> Removed outdated comment ("NB. I've [...]").
>
> Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Changed since v3:
> * update README.LinuxPrimitives file
> ---
> xen/arch/arm/README.LinuxPrimitives | 14 +--
> xen/include/asm-arm/atomic.h | 45 ++++++----
> xen/include/asm-x86/atomic.h | 103 +---------------------
> xen/include/xen/atomic.h | 171 ++++++++++++++++++++++++++++++++++++
> 4 files changed, 210 insertions(+), 123 deletions(-)
> create mode 100644 xen/include/xen/atomic.h
>
> diff --git a/xen/arch/arm/README.LinuxPrimitives b/xen/arch/arm/README.LinuxPrimitives
> index 4906593..2fcdfa4 100644
> --- a/xen/arch/arm/README.LinuxPrimitives
> +++ b/xen/arch/arm/README.LinuxPrimitives
> @@ -27,10 +27,11 @@ The following functions were taken from Linux:
> atomic_add(), atomic_add_return(), atomic_sub(), atomic_sub_return(),
> atomic_cmpxchg(), __atomic_add_unless()
>
> -Also, the following macros which were in the meantime moved to asm-arm/atomic.h:
> - atomic_xchg(v, new), atomic_inc(v), atomic_dec(v),
> +Also, the following macros which were in the meantime moved to asm-arm/atomic.h
> +and most of them turned to inline functions:
> + atomic_xchg(v, new) [still macro], atomic_inc(v), atomic_dec(v),
> atomic_inc_and_test(v), atomic_dec_and_test(v),
> - atomic_inc_return(v), atomic_dec_return(v),
> + atomic_inc_return(v) [still macro], atomic_dec_return(v) [still macro],
> atomic_sub_and_test(i, v), atomic_add_negative(i,v)
As mentioned in patch #1, those functions are not easily sync-able after
this patch. Please drop them from README.LinuxPrimitives.
>
> ---------------------------------------------------------------------
> @@ -105,10 +106,11 @@ The following functions were taken from Linux:
> atomic_add(), atomic_add_return(), atomic_sub(), atomic_sub_return(),
> atomic_cmpxchg(), __atomic_add_unless()
>
> -Also, the following macros which were in the meantime moved to asm-arm/atomic.h:
> - atomic_xchg(v, new), atomic_inc(v), atomic_dec(v),
> +Also, the following macros which were in the meantime moved to asm-arm/atomic.h
> +and most of them turned to inline functions:
> + atomic_xchg(v, new) [still macro], atomic_inc(v), atomic_dec(v),
> atomic_inc_and_test(v), atomic_dec_and_test(v),
> - atomic_inc_return(v), atomic_dec_return(v),
> + atomic_inc_return(v) [still macro], atomic_dec_return(v) [still macro],
> atomic_sub_and_test(i, v), atomic_add_negative(i,v)
Ditto.
With that:
Acked-by: Julien Grall <julien.grall@arm.com>
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-15 9:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 6:47 [PATCH v4 0/7] <asm/atomic.h> adjustments Corneliu ZUZU
2016-07-15 6:48 ` [PATCH v4 1/7] asm-arm/atomic.h: fix arm32|arm64 macros duplication Corneliu ZUZU
2016-07-15 9:28 ` Julien Grall
2016-07-15 9:55 ` Corneliu ZUZU
2016-07-15 10:06 ` Julien Grall
2016-07-15 10:17 ` Corneliu ZUZU
2016-07-15 6:48 ` [PATCH v4 2/7] asm-x86/atomic.h: minor: proper atomic_inc_and_test() placement Corneliu ZUZU
2016-07-15 6:49 ` [PATCH v4 3/7] asm-arm/atomic.h: reorder macros to match x86-side Corneliu ZUZU
2016-07-15 9:28 ` Julien Grall
2016-07-15 6:50 ` [PATCH v4 4/7] asm/atomic.h: common prototyping (add xen/atomic.h) Corneliu ZUZU
2016-07-15 9:30 ` Julien Grall [this message]
2016-07-15 9:59 ` Corneliu ZUZU
2016-07-15 6:50 ` [PATCH v4 5/7] xen/atomic.h: fix: make atomic_read() param const Corneliu ZUZU
2016-07-15 9:31 ` Julien Grall
2016-07-15 6:51 ` [PATCH v4 6/7] asm-arm/atomic.h: atomic_{inc, dec}_return: macros to inline functions Corneliu ZUZU
2016-07-15 6:59 ` Corneliu ZUZU
2016-07-15 6:52 ` [PATCH v4 7/7] asm/atomic.h: implement missing and add common prototypes Corneliu ZUZU
2016-07-15 9:34 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5788AD35.3030301@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=czuzu@bitdefender.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.