From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO5ER-0007qj-LD for qemu-devel@nongnu.org; Fri, 15 Jul 2016 11:40:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO5EP-0008VQ-HU for qemu-devel@nongnu.org; Fri, 15 Jul 2016 11:40:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO5EP-0008VJ-9U for qemu-devel@nongnu.org; Fri, 15 Jul 2016 11:40:49 -0400 References: <577A6955.6020603@kamp.de> <577B130A.3040205@redhat.com> <3221d3d3-37ee-9752-396e-379792445ee0@redhat.com> <577BCB35.6060103@redhat.com> <1a6cbf2d-ff64-0994-23b4-eb305d5ce35f@redhat.com> <5788B660.2060001@kamp.de> From: Eric Blake Message-ID: <578903FF.2050400@redhat.com> Date: Fri, 15 Jul 2016 09:40:47 -0600 MIME-Version: 1.0 In-Reply-To: <5788B660.2060001@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nDakO5M16t19tOp0k7sMGvsR2SGgEEl42" Subject: Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , Paolo Bonzini , "qemu-devel@nongnu.org" Cc: Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nDakO5M16t19tOp0k7sMGvsR2SGgEEl42 From: Eric Blake To: Peter Lieven , Paolo Bonzini , "qemu-devel@nongnu.org" Cc: Kevin Wolf Message-ID: <578903FF.2050400@redhat.com> Subject: Re: Regression: block: Add .bdrv_co_pwrite_zeroes() References: <577A6955.6020603@kamp.de> <577B130A.3040205@redhat.com> <3221d3d3-37ee-9752-396e-379792445ee0@redhat.com> <577BCB35.6060103@redhat.com> <1a6cbf2d-ff64-0994-23b4-eb305d5ce35f@redhat.com> <5788B660.2060001@kamp.de> In-Reply-To: <5788B660.2060001@kamp.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/15/2016 04:09 AM, Peter Lieven wrote: > Am 05.07.2016 um 17:09 schrieb Paolo Bonzini: >> >> On 05/07/2016 16:59, Eric Blake wrote: >>> And yes, we could probably switch to (potentially slower) / % * inste= ad >>> of bit operations in block/io.c to accommodate a non-power-of-2 optim= al >>> size, but it would require a careful audit to make sure we don't have= >>> even more bit-wise operations lurking that were assuming a power of 2= =2E >> Yes, it would require some auditing but it has always worked. Regardi= ng >> speed, I'm sure that / % * are not slower than a system call! :) >=20 > Eric, whats the status of this? Will you send a follow-up to your serie= s > restoring the old behaviour? Still on my plate. As it is a bug-fix, the patch can go in even after hard freeze, so at the moment I've unfortunately been more focused on other patches (such as NBD_CMD_WRITE_ZEROES support) that were posted before soft freeze, but which must be committed prior to hard freeze or else they miss 2.7. But rest assured that I'll make sure 2.7 doesn't regress on your setup. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nDakO5M16t19tOp0k7sMGvsR2SGgEEl42 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXiQP/AAoJEKeha0olJ0NqNuIIAJBqRLslIrdqC8WCS8t0Cq0l rVNOXBecQCLhYw6R7mSY1fybxjJV8cCAOwSoRQre8KlJ2TkTE8gUhytOpepJuAo6 gr6X5DgovNicvugaSk2ocYmwMk/6d/9hxiQoenN2S8pImagkP+tJCwfNl7ZuUUcQ gT7ChNhnPp3aq23OK77GWfHF7JD/+koJWWujSxieFRck7/iKbch300uWxvlNNIOS cmhSTNXVCJ/B1RMGK/IvEzIYtt4mr4XbnhcAAjZ+5J+rkU4sjwfXSQasMvR85Jok AUTpsUrIBZjoAtKti3umyVCw0yvtQraHr/pMAaZVoH+b4j/shCoFHJQQTMCmR1Y= =qKpF -----END PGP SIGNATURE----- --nDakO5M16t19tOp0k7sMGvsR2SGgEEl42--