From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751814AbcGOWfy (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jul 2016 18:35:54 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:35060 "EHLO
	mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751615AbcGOWfx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jul 2016 18:35:53 -0400
Subject: Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit
To: Paul Gortmaker <paul.gortmaker@windriver.com>
References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com>
 <1467932621-358-2-git-send-email-steve_longerbeam@mentor.com>
 <CAP=VYLp+M7ucA0ipzDwaEn4qHOt5yYCOyAwx=9+ON217ou7onw@mail.gmail.com>
Cc: p.zabel@pengutronix.de, dri-devel@lists.freedesktop.org,
        LKML <linux-kernel@vger.kernel.org>,
        Steve Longerbeam <steve_longerbeam@mentor.com>
From: Steve Longerbeam <slongerbeam@gmail.com>
Message-ID: <57896546.3010202@gmail.com>
Date: Fri, 15 Jul 2016 15:35:50 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <CAP=VYLp+M7ucA0ipzDwaEn4qHOt5yYCOyAwx=9+ON217ou7onw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 07/10/2016 05:02 PM, Paul Gortmaker wrote:
>
> +#include <linux/export.h>
> +#include <linux/module.h>
> You have a u32 field in a struct called "modules" but aside from that, I do not
> see anything in this code requiring module.h -- did I miss something?
>
> You might want export.h for EXPORT_SYMBOL though.
>
>

Hi Paul, yes module.h wasn't needed. Fixed in next version.

Steve