From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 18 Jul 2016 09:07:11 +0200 Subject: [U-Boot] [PATCH] spl: Fix compilation warnings for arm64 In-Reply-To: References: <77d6afa8c48d75a6eaa114fb36fd429bb965d2aa.1468565330.git.michal.simek@xilinx.com> Message-ID: <578C801F.2090600@xilinx.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 17.7.2016 16:12, Simon Glass wrote: > Hi Michal, > > On 15 July 2016 at 00:48, Michal Simek wrote: >> Make code 64bit aware. >> >> Warnings: >> +../arch/arm/lib/spl.c: In function ?jump_to_image_linux?: >> +../arch/arm/lib/spl.c:63:3: warning: cast to pointer from integer of >> different size [-Wint-to-pointer-cast] >> +../common/spl/spl_fat.c: In function ?spl_load_image_fat?: >> +../common/spl/spl_fat.c:91:33: warning: cast to pointer from integer >> of different size [-Wint-to-pointer-cast] >> >> Signed-off-by: Michal Simek >> --- >> >> arch/arm/lib/spl.c | 2 +- >> common/spl/spl_fat.c | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) > > Reviewed-by: Simon Glass > > You could use map_sysmem() / unmap_sysmem() to convert a ulong address > into a pointer. Isn't this used more for remapping with non zero length? I see in the code that people are using it just for conversion but the question is if this is right usage. Thanks, Michal