From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 18 Jul 2016 10:38:51 +0200 Subject: [U-Boot] [mips][cfi] Unable to write into flash under qemu In-Reply-To: References: <577BDBF4.8010807@gmail.com> Message-ID: <578C959B.3020404@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Alon, Hi Daniel, On 10.07.2016 22:50, Alon Bar-Lev wrote: > On 5 July 2016 at 19:10, Daniel Schwierzeck > wrote: >> >> Hi Alon, >> >> +cc Paul, Stefan >> >> Am 05.07.2016 um 14:04 schrieb Alon Bar-Lev: >>> Hi, >>> >>> Found the debug setting. >>> >>> When I try to erase flash under qemu I get the following error, the >>> erase actually succeeds in the backed file, I see sector as 0xff. >>> >>> Can anyone check if problem is within u-boot or qemu? >>> >>> Thanks! >> >> I've found the problem. Paul sent a fix [1] for pflash in June 2013 >> to make 32 Bit access working with YAMON bootloader. >> >> The fix mirrors the flash status value in the upper 16 Bits of the return >> value. Thus U-Boot gets a value of 0x800080 in flash_full_status_check() >> after a block erase command. U-Boot compares the status value in >> flash_isequal() with the expected value of 0x80 but that fails. >> >> Because of this I think pflash support for Malta is broken since Qemu 1.6.0. >> >> A possible fix could be this: > > Hi, > Thanks again. > How do we merge this fix? Daniel, could you please send a proper patch (non-inlined) for this so that I can push it to upstream? Or did I miss this patch? Thanks, Stefan