From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbcGRWDA (ORCPT ); Mon, 18 Jul 2016 18:03:00 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33889 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011AbcGRWC6 (ORCPT ); Mon, 18 Jul 2016 18:02:58 -0400 Subject: Re: [PATCH 2/2] net: ethernet: marvell: pxa168_eth: use phy_ethtool_{get|set}_link_ksettings To: Philippe Reynes , davem@davemloft.net, jszhang@marvell.com, sergei.shtylyov@cogentembedded.com, mugunthanvnm@ti.com, a@unstable.cc, fw@strlen.de References: <1468791046-19567-1-git-send-email-tremyfr@gmail.com> <1468791046-19567-2-git-send-email-tremyfr@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <578D520F.9000209@gmail.com> Date: Mon, 18 Jul 2016 15:02:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468791046-19567-2-git-send-email-tremyfr@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/17/2016 02:30 PM, Philippe Reynes wrote: > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes > --- > - cmd.phy_address = pep->phy_addr; > - cmd.speed = pep->phy_speed; > - cmd.duplex = pep->phy_duplex; > - cmd.advertising = PHY_BASIC_FEATURES; > - cmd.autoneg = AUTONEG_ENABLE; > + cmd.base.phy_address = pep->phy_addr; > + cmd.base.speed = pep->phy_speed; > + cmd.base.duplex = pep->phy_duplex; > + ethtool_convert_legacy_u32_to_link_mode(cmd.link_modes.advertising, > + PHY_BASIC_FEATURES); > + cmd.base.autoneg = AUTONEG_ENABLE; > > - if (cmd.speed != 0) > - cmd.autoneg = AUTONEG_DISABLE; > + if (cmd.base.speed != 0) > + cmd.base.autoneg = AUTONEG_DISABLE; > > - return pxa168_set_settings(dev, &cmd); > + return phy_ethtool_set_link_ksettings(dev, &cmd); This duplicates quite a bit of code that the core PHYLIB already deals with, you should plan for a subsequent cleanup patch which removes all of this. -- Florian