From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752295AbcGSGDM (ORCPT ); Tue, 19 Jul 2016 02:03:12 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:38924 "EHLO mx1.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbcGSGDH (ORCPT ); Tue, 19 Jul 2016 02:03:07 -0400 Subject: Re: [mtd-next:master 30/33] drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl' To: Brian Norris , kbuild test robot References: <201607190315.0nkQuD2W%fengguang.wu@intel.com> <20160718202026.GB137880@google.com> Cc: Marek Vasut , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, kbuild-all@01.org, Graham Moore From: Stefan Roese Message-ID: <578DC294.5090605@denx.de> Date: Tue, 19 Jul 2016 08:03:00 +0200 MIME-Version: 1.0 In-Reply-To: <20160718202026.GB137880@google.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.07.2016 22:20, Brian Norris wrote: > On Tue, Jul 19, 2016 at 03:43:17AM +0800, kbuild test robot wrote: >> tree: git://git.infradead.org/linux-mtd-next.git master >> head: f78921b9020c510ed222a6c2402e2aa126432415 >> commit: 140623410536905fa6ab737b625decfde6c64a72 [30/33] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller >> config: x86_64-allmodconfig (attached as .config) >> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 >> reproduce: >> git checkout 140623410536905fa6ab737b625decfde6c64a72 >> # save the attached .config to linux build tree >> make ARCH=x86_64 >> >> All errors (new ones prefixed by >>): >> >> drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_read_execute': >>>> drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl' [-Werror=implicit-function-declaration] >> readsl(ahb_base, rxbuf, DIV_ROUND_UP(bytes_to_read, 4)); >> ^~~~~~ >> drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_write_execute': >>>> drivers/mtd/spi-nor/cadence-quadspi.c:613:3: error: implicit declaration of function 'writesl' [-Werror=implicit-function-declaration] >> writesl(cqspi->ahb_base, txbuf, DIV_ROUND_UP(write_bytes, 4)); >> ^~~~~~~ >> cc1: some warnings being treated as errors > > Hmm, does x86 not define readsl()/writesl()? I can never tell what > accessors are supposed to be "standard" across architectures. > > Either we need to drop the COMPILE_TEST or maybe make it (!X86 && > COMPILE_TEST). iowrite32_rep() etc should work for x86 as well. Thanks, Stefan