From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPZvZ-0006Il-Ti for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:39:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPZvV-0003cr-SH for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:39:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPZvV-0003cm-Jp for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:39:29 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 28F573B709 for ; Tue, 19 Jul 2016 18:39:29 +0000 (UTC) References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-5-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <578E73E0.1020708@redhat.com> Date: Tue, 19 Jul 2016 12:39:28 -0600 MIME-Version: 1.0 In-Reply-To: <20160719085432.4572-5-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JK1FtcVX6qeOXhWsn8r0sFR96kLpsXcni" Subject: Re: [Qemu-devel] [PATCH 04/37] qga: free remaining leaking state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JK1FtcVX6qeOXhWsn8r0sFR96kLpsXcni From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Message-ID: <578E73E0.1020708@redhat.com> Subject: Re: [Qemu-devel] [PATCH 04/37] qga: free remaining leaking state References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-5-marcandre.lureau@redhat.com> In-Reply-To: <20160719085432.4572-5-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/19/2016 02:53 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > qga/guest-agent-command-state.c | 6 ++++++ > qga/guest-agent-core.h | 1 + > qga/main.c | 6 ++++++ > 3 files changed, 13 insertions(+) >=20 > diff --git a/qga/guest-agent-command-state.c b/qga/guest-agent-command-= state.c > index 4de229c..e609d32 100644 > --- a/qga/guest-agent-command-state.c > +++ b/qga/guest-agent-command-state.c > @@ -71,3 +71,9 @@ GACommandState *ga_command_state_new(void) > cs->groups =3D NULL; > return cs; > } > + > +void ga_command_state_free(GACommandState *cs) > +{ > + g_slist_free_full(cs->groups, g_free); Same problem as 3/37 - our minimum glib is 2.22, but this function is 2.2= 8. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JK1FtcVX6qeOXhWsn8r0sFR96kLpsXcni Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXjnPgAAoJEKeha0olJ0Nq5E4H+gN6gilButyNjyjJMqSy7VbS V7eLaYRogqWD18ltal7VqSee7s4ibkGeqhqJ+o7ZJpudWRRhbpXaVOTyTtpXpyOD CODNF5VKos610CZn9hIG6aAONORVFEqtErsHJwyZ3ud71fPVv9lRVIiFSCHTdkZi OtiLWlcgaZaoVZsehx6cQ7qsfGH6hbBO/F97heamknGq15qy7pLVkm5yp+ugC2d6 C9czKl0PYTlpL+4TsQuIgwbV6VMua54vAru4VtCucQsSi6L5//e2WUyPIxM4cks1 s+NteVtJxJ3O+RqJGkyA+iIYEMUoyO9n+NgAYiHLziULfLeWNCSYHKjlrtCEcJU= =cWgH -----END PGP SIGNATURE----- --JK1FtcVX6qeOXhWsn8r0sFR96kLpsXcni--