From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPecp-0006T7-Gd for qemu-devel@nongnu.org; Tue, 19 Jul 2016 19:40:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPecm-0002Uv-AP for qemu-devel@nongnu.org; Tue, 19 Jul 2016 19:40:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPecm-0002Up-2D for qemu-devel@nongnu.org; Tue, 19 Jul 2016 19:40:28 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 919EAC057EC9 for ; Tue, 19 Jul 2016 23:40:27 +0000 (UTC) References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-16-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <578EBA6A.6070701@redhat.com> Date: Tue, 19 Jul 2016 17:40:26 -0600 MIME-Version: 1.0 In-Reply-To: <20160719085432.4572-16-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cgiHIXqEUw51fHdOH6k7ritXPWij8JpdJ" Subject: Re: [Qemu-devel] [PATCH 15/37] pc: simplify passing qemu_irq List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cgiHIXqEUw51fHdOH6k7ritXPWij8JpdJ From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Message-ID: <578EBA6A.6070701@redhat.com> Subject: Re: [Qemu-devel] [PATCH 15/37] pc: simplify passing qemu_irq References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-16-marcandre.lureau@redhat.com> In-Reply-To: <20160719085432.4572-16-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/19/2016 02:54 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > qemu_irq is already a pointer, no need to have an extra pointer level. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > hw/i386/pc.c | 8 ++++---- > hw/input/pckbd.c | 4 ++-- > include/hw/i386/pc.h | 2 +- > 3 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 1b8baa8..57b09c9 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -533,9 +533,9 @@ static uint64_t port92_read(void *opaque, hwaddr ad= dr, > return ret; > } > =20 > -static void port92_init(ISADevice *dev, qemu_irq *a20_out) > +static void port92_init(ISADevice *dev, qemu_irq a20_out) qemu_irq type naming goes against our normal conventions. But this isn't the series to change that. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cgiHIXqEUw51fHdOH6k7ritXPWij8JpdJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXjrprAAoJEKeha0olJ0NqYHEH/3t/KJXXVkMaqfnjpVpfhVFE kACfnu5B3SDy+aq+3eXLlAryZEEpD0NYVw561DrVFvxzDkbROcGoa8z+lxpNPI4L TCuLCHBzuZhIlef+WXh4xy7T5ozBR5D+BUk77KYhPeDXUuC1lHl3zyGOXg7dviQv sXq+kVmv/WO0mDneQ+o+rlynWse0yyualx6drT41H3EQn+Ws6rh5ujnRJ1ceJAuG E8Ebb+j0w8Kgz3itZL5LjBGtN094sY+eFlklIOdIxJopyqoWhxCwXrMDruveYiMv A/XqO79p9o8BHAa7nQ7vVuu973MhID0VF4Ss8XuIdCM4kqOWITl/aPnBAl0edeE= =9yJs -----END PGP SIGNATURE----- --cgiHIXqEUw51fHdOH6k7ritXPWij8JpdJ--