From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPemg-0005Dr-Rr for qemu-devel@nongnu.org; Tue, 19 Jul 2016 19:50:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPemd-0004AA-Me for qemu-devel@nongnu.org; Tue, 19 Jul 2016 19:50:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPemd-0004A6-Dz for qemu-devel@nongnu.org; Tue, 19 Jul 2016 19:50:39 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E3E687F748 for ; Tue, 19 Jul 2016 23:50:37 +0000 (UTC) References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-22-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <578EBCCD.6060806@redhat.com> Date: Tue, 19 Jul 2016 17:50:37 -0600 MIME-Version: 1.0 In-Reply-To: <20160719085432.4572-22-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eMaDOeoIBIQWHSPC0plf5QbjgmcKnU5Pq" Subject: Re: [Qemu-devel] [PATCH 21/37] tests: fix qom-test leaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eMaDOeoIBIQWHSPC0plf5QbjgmcKnU5Pq From: Eric Blake To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Message-ID: <578EBCCD.6060806@redhat.com> Subject: Re: [Qemu-devel] [PATCH 21/37] tests: fix qom-test leaks References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-22-marcandre.lureau@redhat.com> In-Reply-To: <20160719085432.4572-22-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/19/2016 02:54 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > tests/qom-test.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake >=20 > diff --git a/tests/qom-test.c b/tests/qom-test.c > index 23493a2..d48f890 100644 > --- a/tests/qom-test.c > +++ b/tests/qom-test.c > @@ -115,7 +115,7 @@ static void add_machine_test_cases(void) > const QListEntry *p; > QObject *qobj; > QString *qstr; > - const char *mname, *path; > + const char *mname; > =20 > qtest_start("-machine none"); > response =3D qmp("{ 'execute': 'query-machines' }"); > @@ -132,8 +132,9 @@ static void add_machine_test_cases(void) > g_assert(qstr); > mname =3D qstring_get_str(qstr); > if (!is_blacklisted(arch, mname)) { > - path =3D g_strdup_printf("qom/%s", mname); > + char *path =3D g_strdup_printf("qom/%s", mname); > qtest_add_data_func(path, g_strdup(mname), test_machine); > + g_free(path); > } > } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eMaDOeoIBIQWHSPC0plf5QbjgmcKnU5Pq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXjrzNAAoJEKeha0olJ0NqUbMH/0G4K89T7FY36k0BD/iSNlV0 XfaIWgVppXWBi+Xm3wCFCYsOlo/zPL1jaMOK0mlnK8ZofFK/MyPwGsql78Ap8vX2 +6xpOMgEMZJ/HSKd8i7swRhNXNOJH9oGnoBvDzajTPvSUHOsqi0cfIjneOpmw99G FQTI1suqHdR0LoRt77MvNqhUSHIhOE2FSdj3VXhyDxFn3SawJzWXl2WjH1X3C2G1 x/hwVUVwG9RQ0wziK/LecZim0yL8hS9sUbmErYcV2PlXAD5DOzuDXcdLL1tcsXrP /5F2g5MHLSKTJGSnr0H/nU6U2vxx5PhW8RhmBFb4t5f8G9R6skwpXBTKkqnoNC0= =l430 -----END PGP SIGNATURE----- --eMaDOeoIBIQWHSPC0plf5QbjgmcKnU5Pq--