From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753044AbcGTJfH (ORCPT ); Wed, 20 Jul 2016 05:35:07 -0400 Received: from a.mx.sdesigns.eu ([78.31.43.6]:20453 "EHLO a.mx.sdesigns.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772AbcGTJfD (ORCPT ); Wed, 20 Jul 2016 05:35:03 -0400 Subject: Re: [RFC PATCH v2] irqchip: add support for SMP irq router To: Sebastian Frias Cc: Marc Zyngier , Jason Cooper , Thomas Gleixner , LKML , Thibaud Cornic , Mason , Mans Rullgard References: <577542D1.4070307@laposte.net> <577A5260.3070001@free.fr> <577BA854.6090503@laposte.net> <20160705144151.GE3348@io.lakedaemon.net> <577BCFD2.8060203@laposte.net> <20160705155306.GG3348@io.lakedaemon.net> <577BE288.70200@laposte.net> <577BE4D8.2040601@arm.com> <577BE75B.4070109@laposte.net> <577BEABE.2010204@arm.com> <577CE1DE.6080502@laposte.net> <577D0C95.2000703@arm.com> <577E4819.4010004@laposte.net> <577E4E3C.5010505@arm.com> <578E37C9.8090907@laposte.net> From: Marc Gonzalez Message-ID: <578F45C4.2080005@sigmadesigns.com> Date: Wed, 20 Jul 2016 11:35:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: <578E37C9.8090907@laposte.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/07/2016 16:23, Sebastian Frias wrote: > I don't think there's supposed to be an empty line at the beginning of the patch. I don't know whether 'git am' knows to zap the spurious line. > 3) The file is called 'irq-tango_v4.c' but I think it should match the > compatible string, so I was thinking of renaming: > irq-tango_v4.c => irq-sigma_smp_irqrouter.c > irq-tango_v4.h => irq-sigma_smp_irqrouter.h > > What do you think? Why is the file called irq-tango_v4? Why v4? This is the second incarnation of a tango IRQ controller (that I know of). Why not -v2 then? (Could you please not mix dash and underscore? Use one or the other consistently.) > 5) checkpatch.pl reports a few warnings: > > - WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > I have not changed the file because I would like to be settled on the naming > first (see point 2 above) I now have a regex pattern that matches "tango" in MAINTAINERS. However, checkpatch only checks the current patch, not the existing MAINTAINERS file. > .../interrupt-controller/sigma,smp,irqrouter.txt | 135 ++ We've managed to use "tango" everywhere consistently (so far), please let's not introduce the "smp" terminology at this point, it will only confuse matters. (I use "smp87xy" to name specific boards, tango for the architecture/family.) I found only one occurrence of the "a,b,c" syntax $ find Documentation/devicetree/bindings -name "*,*,*" Documentation/devicetree/bindings/net/wireless/ti,wlcore,spi.txt Maybe we need to discuss this with the devicetree folks. Note: Mans created Documentation/devicetree/bindings/interrupt-controller/sigma,smp8642-intc.txt for the v1 intc driver. > +Required properties: > +- compatible: Should be "sigma,smp,irqrouter". You said in a previous message that you wanted to use a generic name. AFAIU, the current DT trend is the opposite: to use the name of the first board (chronologically) that used that HW incarnation. So that would be "sigma,smp87xx-intc" (We can fill the xx when the weenies in marketing finally decide to announce the chip.) The generic names you cited, like xhci, are actually naming a protocol, which many controllers implement (because it is standard). > +/* > + * Copyright (C) 2014 Sebastian Frias Having discussed this topic with Thibaud, I think it is better to use "official" email addresses for kernel submissions. Regards.