From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPyzA-0002I2-7n for qemu-devel@nongnu.org; Wed, 20 Jul 2016 17:24:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPyz8-0005X0-AV for qemu-devel@nongnu.org; Wed, 20 Jul 2016 17:24:55 -0400 References: <1468974062-7726-1-git-send-email-jcody@redhat.com> <1468974062-7726-14-git-send-email-jcody@redhat.com> From: Eric Blake Message-ID: <578FEC19.4040005@redhat.com> Date: Wed, 20 Jul 2016 15:24:41 -0600 MIME-Version: 1.0 In-Reply-To: <1468974062-7726-14-git-send-email-jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vUdwRqWDGIAmcLOhxwwCnAQpwdIVlcqlK" Subject: Re: [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-block@nongnu.org Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vUdwRqWDGIAmcLOhxwwCnAQpwdIVlcqlK From: Eric Blake To: Jeff Cody , qemu-block@nongnu.org Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org Message-ID: <578FEC19.4040005@redhat.com> Subject: Re: [Qemu-devel] [PULL 13/14] block/gluster: using new qapi schema References: <1468974062-7726-1-git-send-email-jcody@redhat.com> <1468974062-7726-14-git-send-email-jcody@redhat.com> In-Reply-To: <1468974062-7726-14-git-send-email-jcody@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/19/2016 06:21 PM, Jeff Cody wrote: > From: Prasanna Kumar Kalever >=20 > this patch adds 'GlusterServer' related schema in qapi/block-core.json >=20 > [Jeff: minor fix-ups of comments and formatting, per patch reviews] >=20 > Signed-off-by: Prasanna Kumar Kalever > Reviewed-by: Markus Armbruster > Reviewed-by: Eric Blake > Message-id: 1468947453-5433-5-git-send-email-prasanna.kalever@redhat.co= m > Signed-off-by: Jeff Cody > --- > +++ b/qapi/block-core.json > @@ -1666,13 +1666,14 @@ > +## > +# @BlockdevOptionsGluster > +# > +# Driver specific block device options for Gluster > +# > +# @volume: name of gluster volume where VM image resides > +# > +# @path: absolute path to image file in gluster volume > +# > +# @server: gluster server description > +# > +# @debug-level: #optional libgfapi log level (default '4' which is Err= or) You got one, > +# > +# Since: 2.7 > +## > +{ 'struct': 'BlockdevOptionsGluster', > + 'data': { 'volume': 'str', > + 'path': 'str', > + 'server': 'GlusterServer', > + '*debug_level': 'int' } } but not the other instance. Can be fixed in a followup patch if the pull request has already landed. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vUdwRqWDGIAmcLOhxwwCnAQpwdIVlcqlK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXj+wZAAoJEKeha0olJ0Nq860IAIo3BFMbUJ6Sy5+Yz2+lxodu l0wIaov8ayt3HxxstgBJY0DkhNy+QlaVTjPFLP/Unwa95WBZ1+8wtHkVE5itytgN /QXGtNZC50+Q5I8AIyesX9KFMX1fQQtj4gxAIX0R2lB3E4PV6mVnibKmb9RAVqoN wFk/nP2uPvQRVXpmS0L52o6v+7L3FV8ClKGe5cxkEcKMpl2gagy7p80HeviAB4aW zSGgvA+Op+7tU0efuZeHveMT7OszF8COvq60HjVsGnJD8eOkK3rqO5SWa6aJ460C AkXUnEy6reTz6sAE5eOqdBT0fdcBuzK5WwSydKXFUz7zZDl56hScV/KCPuIYbjo= =gVu2 -----END PGP SIGNATURE----- --vUdwRqWDGIAmcLOhxwwCnAQpwdIVlcqlK--