From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E411C433F5 for ; Fri, 29 Oct 2021 12:15:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B89B61177 for ; Fri, 29 Oct 2021 12:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231465AbhJ2MRr (ORCPT ); Fri, 29 Oct 2021 08:17:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbhJ2MRo (ORCPT ); Fri, 29 Oct 2021 08:17:44 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23AAAC061570; Fri, 29 Oct 2021 05:15:16 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id k13so16490227ljj.12; Fri, 29 Oct 2021 05:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=QgrejLPhmwaonglk/87BMy/DDGpmqiRAYppe9EnRVr4=; b=A+ZNKmDogHyLyOqThrIx2im9JmiBZM2RKr6BJSH7qigfuxjA+8f+l07n60V6RFIyuh tbuDeeQFb7+dcT1TkkJx9y0amDC9u5nrRiQs530v0pPwKY30ppmJ0Fr6XTbFfXBAn4Ec VyrbIxwdnn0coVj4CEi1sH5ac0nEdmo3eBfzORRIh0CURMwmL1Kb8ITgW2KGlbzflVWV KgC+62xHdg/V5Mr/IGsoQMdtdYWvwNC5Y5bYwGRC+yuHTwnH1xx/lzdqdiZIQ8kBTZ5G xs90qJ7Rzu2lzV0MFcVpdgtwWOE9x4GDkjPXd6/Ac7sUgox/fZBuwgIUwsfMOrXtB+D/ fQWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=QgrejLPhmwaonglk/87BMy/DDGpmqiRAYppe9EnRVr4=; b=wnR+4tUjSjfyfjrunowKlE56EzWjiV6qCSDfV9+hyDp7fTkQsPf/yHLRVoEAokA1mk ASIR6/aE7Lf5rZkPBPF7vK24BsLzbdhxktp3yhRy2vhmAAlrySGm4MAUYrQ+fr5en/z2 /XONoosGDMcJ7oR/28vsDL6iuP3xqERt+sc5QCeESoyubRizftehtT3zQbUXwHiwjvzK RgGf6f2SNxWJjBJzHNTWqPUWINC7vdtr/FBxoMzMlSU0kkMaBuT474/RpTnad/rlzN9C jbW18BemfIVJxHVECIrPMUzpeNqU/aKSetBD/ZIGXZfjtEKQCJX0EFaVS1vZrbOMyHPC O6kQ== X-Gm-Message-State: AOAM533icwwSHIdgdb1uKVwbqAFoWf2LOtvti2qe/3+eQW65TiWgpA+2 B4DJpyeGo/j4NRzh1D3tXQ8= X-Google-Smtp-Source: ABdhPJwzkAT1GAvW+n6j0hL4OQ+xEvaDsck59irti/Fx/wWDpRJw4y6eDPz7RLt76q/2JVdywsyQBg== X-Received: by 2002:a05:651c:893:: with SMTP id d19mr11634382ljq.236.1635509713081; Fri, 29 Oct 2021 05:15:13 -0700 (PDT) Received: from [192.168.26.149] (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id x7sm590496lfu.116.2021.10.29.05.15.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 05:15:12 -0700 (PDT) Message-ID: <578ae650-e5c0-cb86-8f34-18736e5d9239@gmail.com> Date: Fri, 29 Oct 2021 14:15:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Subject: Re: [PATCH 3/3] watchdog: bcm7038_wdt: support BCM4908 SoC To: Guenter Roeck , Florian Fainelli , Wim Van Sebroeck , Rob Herring Cc: bcm-kernel-feedback-list@broadcom.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20211028093059.32535-1-zajec5@gmail.com> <20211028093059.32535-3-zajec5@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28.10.2021 18:57, Guenter Roeck wrote: > On 10/28/21 9:29 AM, Florian Fainelli wrote: >> On 10/28/21 2:30 AM, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> Hardware supported by this driver goes back to the old bcm63xx days. It >>> was then reused in BCM7038 and later also in BCM4908. >>> >>> Depending on SoC model registers layout differs a bit. This commit >>> introduces support for per-chipset registers offsets & adds BCM4908 >>> layout. >>> >>> Later on BCM63xx SoCs support should be added too (probably as platform >>> devices due to missing DT). Eventually this driver should replace >>> bcm63xx_wdt.c. >>> > Seems unrelated / irrelevant in this commit log, except maybe after '---'. > >>> Signed-off-by: Rafał Miłecki >>> --- >> >> [snip] >> >>> + >>> +static const u16 bcm7038_wdt_regs_bcm4908[] = { >>> +    [BCM63XX_WDT_REG_DEFVAL]    = 0x28, > > REG_DEFVAL is an odd name for this register. I can see that the > bcm63xx driver uses it, but in reality it seems to be the timeout > value, not some default value, only the bcm63xx driver doesn't > seem to use it properly. I think REG_TIMEOUT or similar would > be a much better name. I used name used in Broadcom's SDK (and as I guess also in their documentation too). Take a look at this BCM60333 example: typedef struct Timer { uint32 TimerInts; /* 0x00 */ uint32 TimerCtl0; /* 0x04 */ uint32 TimerCtl1; /* 0x08 */ uint32 TimerCtl2; /* 0x0c */ uint32 TimerCnt0; /* 0x10 */ uint32 TimerCnt1; /* 0x14 */ uint32 TimerCnt2; /* 0x18 */ uint32 WatchDogDefCount; /* 0x1c */ uint32 WatchDogCtl; /* 0x20 */ uint32 WDResetCount; /* 0x24 */ } Timer; I got impression that Linux driver registers names usually follow what is used in hardware documentation. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 002E2C433F5 for ; Fri, 29 Oct 2021 12:16:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8F0D600CC for ; Fri, 29 Oct 2021 12:16:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B8F0D600CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qWPXqTWZaqbAY+68SU4gI5iHD/AxISyV2EdR85ZvJKc=; b=IDFs43MdifQ0zS tkT/1EQSEcibSi5NXTDDeJbAPdKahRdfeTbSuyLq5GWUQ156T5k0iN3CQH15w/3F3PuXVeR/MoIMd dhIIdUKVNSmbh+bdxgpwMNrepfx5hx/u0tUXvNWg6tNmzAiVP6Q1JQe/s0NY2zh3xIm+pWmjNETuK b2a2bEK97oHfsTWcBvyWzx1Z1UAPnvdOyltvLeOrmWiRQKbHrda6AAlrUHcXYlI1cNJwYSyhbroLS ziApn6OHXmgoOHlTsgLr2zP65btZs4N0caTWK2k+TpyAEF2WEloS7xodqYDaHVXbTm7KdZ3ZFhh56 Pod5mho4Cu2zDSRQ9Jsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgQn2-00AtRF-Bi; Fri, 29 Oct 2021 12:15:20 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgQmy-00AtQu-Gz for linux-arm-kernel@lists.infradead.org; Fri, 29 Oct 2021 12:15:17 +0000 Received: by mail-lj1-x236.google.com with SMTP id 1so10640777ljv.2 for ; Fri, 29 Oct 2021 05:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=QgrejLPhmwaonglk/87BMy/DDGpmqiRAYppe9EnRVr4=; b=A+ZNKmDogHyLyOqThrIx2im9JmiBZM2RKr6BJSH7qigfuxjA+8f+l07n60V6RFIyuh tbuDeeQFb7+dcT1TkkJx9y0amDC9u5nrRiQs530v0pPwKY30ppmJ0Fr6XTbFfXBAn4Ec VyrbIxwdnn0coVj4CEi1sH5ac0nEdmo3eBfzORRIh0CURMwmL1Kb8ITgW2KGlbzflVWV KgC+62xHdg/V5Mr/IGsoQMdtdYWvwNC5Y5bYwGRC+yuHTwnH1xx/lzdqdiZIQ8kBTZ5G xs90qJ7Rzu2lzV0MFcVpdgtwWOE9x4GDkjPXd6/Ac7sUgox/fZBuwgIUwsfMOrXtB+D/ fQWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=QgrejLPhmwaonglk/87BMy/DDGpmqiRAYppe9EnRVr4=; b=8PSjL0HbncGYBRQ71sg1+UYA8+WzBc4VrvxwlOi837mQTsWesmJqK97B7FX3OqN12Q LwpgdO2BQ+O1cnox2lYEVDJ82VG+GGIzve5cL7AJZDOfgJWJr98tCtWmbHChwcyDC9dh whfNHgnlqZlVVoqBh8SOJ5ptCP7uIhFOogIFx1IhNRrsVabb1Iq3xTd/wQ3pgkYElK/D PRR2UT4V3Id0+t9wdSkaDMwwkM7KxErgnMIqJBR0m2PsaDmM3tXxOjYphmK6ck0f1EzQ pKxXj8cD3uGpkhH6Bkg9/j/K7a/6HD/eI7MpR4/ZBBbamnTed0RgEjPpHIYGbmJzOqpA G7vQ== X-Gm-Message-State: AOAM530wOPsQgKjutNPUHj4NZsYebw5lQ4mhZa5KF+vn3FHcZnRRXGpE oLR1qUybW1RHJiOgyWvbjBo= X-Google-Smtp-Source: ABdhPJwzkAT1GAvW+n6j0hL4OQ+xEvaDsck59irti/Fx/wWDpRJw4y6eDPz7RLt76q/2JVdywsyQBg== X-Received: by 2002:a05:651c:893:: with SMTP id d19mr11634382ljq.236.1635509713081; Fri, 29 Oct 2021 05:15:13 -0700 (PDT) Received: from [192.168.26.149] (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id x7sm590496lfu.116.2021.10.29.05.15.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 05:15:12 -0700 (PDT) Message-ID: <578ae650-e5c0-cb86-8f34-18736e5d9239@gmail.com> Date: Fri, 29 Oct 2021 14:15:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Subject: Re: [PATCH 3/3] watchdog: bcm7038_wdt: support BCM4908 SoC To: Guenter Roeck , Florian Fainelli , Wim Van Sebroeck , Rob Herring Cc: bcm-kernel-feedback-list@broadcom.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20211028093059.32535-1-zajec5@gmail.com> <20211028093059.32535-3-zajec5@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211029_051516_652647_546E3258 X-CRM114-Status: GOOD ( 18.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjguMTAuMjAyMSAxODo1NywgR3VlbnRlciBSb2VjayB3cm90ZToKPiBPbiAxMC8yOC8yMSA5 OjI5IEFNLCBGbG9yaWFuIEZhaW5lbGxpIHdyb3RlOgo+PiBPbiAxMC8yOC8yMSAyOjMwIEFNLCBS YWZhxYIgTWnFgmVja2kgd3JvdGU6Cj4+PiBGcm9tOiBSYWZhxYIgTWnFgmVja2kgPHJhZmFsQG1p bGVja2kucGw+Cj4+Pgo+Pj4gSGFyZHdhcmUgc3VwcG9ydGVkIGJ5IHRoaXMgZHJpdmVyIGdvZXMg YmFjayB0byB0aGUgb2xkIGJjbTYzeHggZGF5cy4gSXQKPj4+IHdhcyB0aGVuIHJldXNlZCBpbiBC Q003MDM4IGFuZCBsYXRlciBhbHNvIGluIEJDTTQ5MDguCj4+Pgo+Pj4gRGVwZW5kaW5nIG9uIFNv QyBtb2RlbCByZWdpc3RlcnMgbGF5b3V0IGRpZmZlcnMgYSBiaXQuIFRoaXMgY29tbWl0Cj4+PiBp bnRyb2R1Y2VzIHN1cHBvcnQgZm9yIHBlci1jaGlwc2V0IHJlZ2lzdGVycyBvZmZzZXRzICYgYWRk cyBCQ000OTA4Cj4+PiBsYXlvdXQuCj4+Pgo+Pj4gTGF0ZXIgb24gQkNNNjN4eCBTb0NzIHN1cHBv cnQgc2hvdWxkIGJlIGFkZGVkIHRvbyAocHJvYmFibHkgYXMgcGxhdGZvcm0KPj4+IGRldmljZXMg ZHVlIHRvIG1pc3NpbmcgRFQpLiBFdmVudHVhbGx5IHRoaXMgZHJpdmVyIHNob3VsZCByZXBsYWNl Cj4+PiBiY202M3h4X3dkdC5jLgo+Pj4KPiBTZWVtcyB1bnJlbGF0ZWQgLyBpcnJlbGV2YW50IGlu IHRoaXMgY29tbWl0IGxvZywgZXhjZXB0IG1heWJlIGFmdGVyICctLS0nLgo+IAo+Pj4gU2lnbmVk LW9mZi1ieTogUmFmYcWCIE1pxYJlY2tpIDxyYWZhbEBtaWxlY2tpLnBsPgo+Pj4gLS0tCj4+Cj4+ IFtzbmlwXQo+Pgo+Pj4gKwo+Pj4gK3N0YXRpYyBjb25zdCB1MTYgYmNtNzAzOF93ZHRfcmVnc19i Y200OTA4W10gPSB7Cj4+PiArwqDCoMKgIFtCQ002M1hYX1dEVF9SRUdfREVGVkFMXcKgwqDCoCA9 IDB4MjgsCj4gCj4gUkVHX0RFRlZBTCBpcyBhbiBvZGQgbmFtZSBmb3IgdGhpcyByZWdpc3Rlci4g SSBjYW4gc2VlIHRoYXQgdGhlCj4gYmNtNjN4eCBkcml2ZXIgdXNlcyBpdCwgYnV0IGluIHJlYWxp dHkgaXQgc2VlbXMgdG8gYmUgdGhlIHRpbWVvdXQKPiB2YWx1ZSwgbm90IHNvbWUgZGVmYXVsdCB2 YWx1ZSwgb25seSB0aGUgYmNtNjN4eCBkcml2ZXIgZG9lc24ndAo+IHNlZW0gdG8gdXNlIGl0IHBy b3Blcmx5LiBJIHRoaW5rIFJFR19USU1FT1VUIG9yIHNpbWlsYXIgd291bGQKPiBiZSBhIG11Y2gg YmV0dGVyIG5hbWUuCgpJIHVzZWQgbmFtZSB1c2VkIGluIEJyb2FkY29tJ3MgU0RLIChhbmQgYXMg SSBndWVzcyBhbHNvIGluIHRoZWlyCmRvY3VtZW50YXRpb24gdG9vKS4KClRha2UgYSBsb29rIGF0 IHRoaXMgQkNNNjAzMzMgZXhhbXBsZToKCnR5cGVkZWYgc3RydWN0IFRpbWVyIHsKCXVpbnQzMglU aW1lckludHM7CQkvKiAweDAwICovCgl1aW50MzIJVGltZXJDdGwwOwkJLyogMHgwNCAqLwoJdWlu dDMyCVRpbWVyQ3RsMTsJCS8qIDB4MDggKi8KCXVpbnQzMglUaW1lckN0bDI7CQkvKiAweDBjICov Cgl1aW50MzIJVGltZXJDbnQwOwkJLyogMHgxMCAqLwoJdWludDMyCVRpbWVyQ250MTsJCS8qIDB4 MTQgKi8KCXVpbnQzMglUaW1lckNudDI7CQkvKiAweDE4ICovCgl1aW50MzIJV2F0Y2hEb2dEZWZD b3VudDsJLyogMHgxYyAqLwoJdWludDMyCVdhdGNoRG9nQ3RsOwkJLyogMHgyMCAqLwoJdWludDMy CVdEUmVzZXRDb3VudDsJCS8qIDB4MjQgKi8KfSBUaW1lcjsKCkkgZ290IGltcHJlc3Npb24gdGhh dCBMaW51eCBkcml2ZXIgcmVnaXN0ZXJzIG5hbWVzIHVzdWFsbHkgZm9sbG93IHdoYXQKaXMgdXNl ZCBpbiBoYXJkd2FyZSBkb2N1bWVudGF0aW9uLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=