From: akpm@linux-foundation.org
To: zhongjiang@huawei.com, mhocko@suse.cz, qiuxishi@huawei.com,
vbabka@suse.cz, mm-commits@vger.kernel.org
Subject: + mm-hugetlb-fix-race-when-migrate-pages.patch added to -mm tree
Date: Tue, 19 Jul 2016 16:06:51 -0700 [thread overview]
Message-ID: <578eb28b.YbRUDGz5RloTVlrE%akpm@linux-foundation.org> (raw)
The patch titled
Subject: mm/hugetlb.c: fix race when migrating pages
has been added to the -mm tree. Its filename is
mm-hugetlb-fix-race-when-migrate-pages.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-fix-race-when-migrate-pages.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-fix-race-when-migrate-pages.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: zhong jiang <zhongjiang@huawei.com>
Subject: mm/hugetlb.c: fix race when migrating pages
I hit the following code in huge_pte_alloc when run the database and
online-offline memory in the system.
BUG_ON(pte && !pte_none(*pte) && !pte_huge(*pte));
when pmd share function enable, we may be obtain a shared pmd entry. due
to ongoing offline memory , the pmd entry points to the page will turn
into migrate condition. therefore, the bug will come up.
The patch fixes it by checking the pmd entry when we obtain the lock. if
the shared pmd entry points to page is under migration. we should
allocate a new pmd entry.
Link: http://lkml.kernel.org/r/1468935958-21810-1-git-send-email-zhongjiang@huawei.com
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Xishi Qiu <qiuxishi@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/hugetlb.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff -puN mm/hugetlb.c~mm-hugetlb-fix-race-when-migrate-pages mm/hugetlb.c
--- a/mm/hugetlb.c~mm-hugetlb-fix-race-when-migrate-pages
+++ a/mm/hugetlb.c
@@ -4214,7 +4214,7 @@ pte_t *huge_pmd_share(struct mm_struct *
struct vm_area_struct *svma;
unsigned long saddr;
pte_t *spte = NULL;
- pte_t *pte;
+ pte_t *pte, entry;
spinlock_t *ptl;
if (!vma_shareable(vma, addr))
@@ -4240,6 +4240,11 @@ pte_t *huge_pmd_share(struct mm_struct *
ptl = huge_pte_lockptr(hstate_vma(vma), mm, spte);
spin_lock(ptl);
+ entry = huge_ptep_get(spte);
+ if (is_hugetlb_entry_migration(entry) ||
+ is_hugetlb_entry_hwpoisoned(entry)) {
+ goto out_unlock;
+ }
if (pud_none(*pud)) {
pud_populate(mm, pud,
(pmd_t *)((unsigned long)spte & PAGE_MASK));
@@ -4247,6 +4252,8 @@ pte_t *huge_pmd_share(struct mm_struct *
} else {
put_page(virt_to_page(spte));
}
+
+out_unlock:
spin_unlock(ptl);
out:
pte = (pte_t *)pmd_alloc(mm, pud, addr);
_
Patches currently in -mm which might be from zhongjiang@huawei.com are
mm-hugetlb-fix-race-when-migrate-pages.patch
mm-update-the-comment-in-__isolate_free_page.patch
mm-page_owner-align-with-pageblock_nr-pages.patch
next reply other threads:[~2016-07-19 23:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 23:06 akpm [this message]
2016-07-21 7:43 ` + mm-hugetlb-fix-race-when-migrate-pages.patch added to -mm tree Michal Hocko
2016-07-21 8:13 ` Naoya Horiguchi
2016-07-21 10:29 ` Michal Hocko
2016-07-21 10:54 ` zhong jiang
2016-07-21 11:27 ` Michal Hocko
2016-07-21 12:14 ` zhong jiang
2016-07-21 12:30 ` Michal Hocko
2016-07-21 12:45 ` zhong jiang
2016-07-21 12:55 ` Michal Hocko
2016-07-21 13:25 ` zhong jiang
2016-07-21 13:40 ` Michal Hocko
2016-07-21 13:58 ` zhong jiang
2016-07-21 14:01 ` Michal Hocko
2016-07-21 14:13 ` zhong jiang
2016-07-21 14:27 ` Michal Hocko
2016-07-21 14:33 ` zhong jiang
2016-07-22 7:17 ` Naoya Horiguchi
2016-07-26 7:58 ` Michal Hocko
2016-07-26 14:04 ` zhong jiang
2016-07-27 14:44 ` Michal Hocko
2016-07-29 11:27 ` Michal Hocko
2016-07-30 6:33 ` zhong jiang
2016-08-01 11:02 ` Michal Hocko
2016-08-01 15:04 ` zhong jiang
2016-08-01 15:31 ` Michal Hocko
[not found] <003701d1e328$202ca9d0$6085fd70$@alibaba-inc.com>
2016-07-21 8:19 ` Hillf Danton
2016-07-21 8:19 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578eb28b.YbRUDGz5RloTVlrE%akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=qiuxishi@huawei.com \
--cc=vbabka@suse.cz \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.