All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	David Miller <davem@davemloft.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: WAS ( Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action
Date: Thu, 21 Jul 2016 16:42:40 +0200	[thread overview]
Message-ID: <5790DF60.5010900@iogearbox.net> (raw)
In-Reply-To: <742d87f4-b1af-ff02-93a9-bdcd369492af@mojatatu.com>

On 07/21/2016 09:27 AM, Jamal Hadi Salim wrote:
[...]
> Forgot about csum which would work with pedit - didnt quiet parse what
> you are saying above though:
> does changing MAC address require changing to CHECKSUM_NONE? If yes,
> then seems like i need to send a patch for act_ife as well to make in
> the spirit of mirred?

Hmm, seems fine actually up to ETH_HLEN. In cases like vlan or mpls
modifications there's certainly a correction, but when going into rx
path this is pulled out already of the calculation afaik (see f.e.
dev_forward_skb()). So when mirred pushes this back in via skb_push_rcsum()
and dev_forward_skb() back out, it should be okay if I see this correctly.
But don't you still something like need skb_try_make_writable()?

      reply	other threads:[~2016-07-21 14:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-17  8:41 [PATCH net-next 1/1] net_sched: Introduce skbmod action Jamal Hadi Salim
2016-07-18  4:19 ` Alexei Starovoitov
2016-07-18  6:51   ` Jamal Hadi Salim
2016-07-18  9:44     ` Daniel Borkmann
2016-07-18 10:07       ` Thomas Graf
2016-07-18 10:26         ` Jamal Hadi Salim
2016-07-18 17:38           ` Cong Wang
2016-07-19 10:28             ` Jamal Hadi Salim
2016-07-18 10:08       ` Jamal Hadi Salim
2016-07-19 13:21         ` Daniel Borkmann
2016-07-19 13:56           ` Jamal Hadi Salim
2016-07-19 15:03             ` Daniel Borkmann
2016-07-19 18:04               ` Cong Wang
2016-07-20  0:23                 ` Daniel Borkmann
2016-07-21  7:27                   ` WAS ( " Jamal Hadi Salim
2016-07-21 14:42                     ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5790DF60.5010900@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=alexei.starovoitov@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.