From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbcGUPM2 (ORCPT ); Thu, 21 Jul 2016 11:12:28 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:22888 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752881AbcGUPMW (ORCPT ); Thu, 21 Jul 2016 11:12:22 -0400 X-AuditID: cbfec7f5-f792a6d000001302-14-5790e652fb8f Subject: Re: [alsa-devel] [PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board To: Chanwoo Choi References: <1467738877-31555-1-git-send-email-s.nawrocki@samsung.com> <5788721B.7010602@samsung.com> <578CB261.60507@samsung.com> <5790A3D0.4070500@samsung.com> Cc: robh@kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, inki.dae@samsung.com, broonie@kernel.org, ideal.song@samsung.com From: Sylwester Nawrocki Message-id: <5790E650.609@samsung.com> Date: Thu, 21 Jul 2016 17:12:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <5790A3D0.4070500@samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsVy+t/xK7pBzyaEG7z5L2Zx5eIhJouNM9az Wkx9+ITN4vqX56wW84+cY7XY9fc+o8Wk+xNYLF6/MLS4vGsOm8WM8/uYLP7v2cHuwO2x4XMT m8emVZ1sHn1bVjF6fN4kF8ASxWWTkpqTWZZapG+XwJWx86lzwSf2iudTprM0MO5i62Lk5JAQ MJE4+XgCO4QtJnHh3nqgOBeHkMBSRokJDx8yQjjPGSWaXixkBqkSFsiW2DVpK1iHiICGxMy/ V6CKfjNKrDwxlxnEYRZYwCRx+XsfI0gVm4ChRO9RCJtXQE1izdZPYDaLgKrEnqNHWEBsUYEI iSdzT0LVCEr8mHwPLM4poC2xaNVOpi5GDqCh6hJTpuSChJkF5CU2r3nLPIFRYBaSjlkIVbOQ VC1gZF7FKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERIBX3cwLj1mdYhRgINRiYd3x+r+cCHW xLLiytxDjBIczEoivM8eTQgX4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjtz1/sQIYH0xJLU7NTU gtQimCwTB6dUAyOTwNJlp3YvSF3G7H6N60wC/zSLKhf9huNx0bUevxId5aYIOlsLKSYziknI Fr5+9GruIsvt+1orDv/8FvT039yWgOpTwmXCLb+6Vu9cuP26rENojenKFue/5jvk7vka8DFv FXFt1XthYXZoBR97DP+y5sV3Ik9FTvjVumCqokO/QTj30xPPO5RYijMSDbWYi4oTAbmm3Lp8 AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/21/2016 12:28 PM, Chanwoo Choi wrote: > When I test it, I can get the clock pointer by devm_clk_get() as following: > > diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c > index 9728b3c5927f..5de4fc554aec 100644 > --- a/sound/soc/samsung/tm2_wm5110.c > +++ b/sound/soc/samsung/tm2_wm5110.c > @@ -500,7 +500,7 @@ static int tm2_probe(struct platform_device *pdev) > card->dai_link[i].platform_of_node = cpu_dai_node; > } > > - priv->codec_mclk1 = of_clk_get_by_name(codec_dai_node, "mclk1"); > + priv->codec_mclk1 = devm_clk_get(dev, "mclk1"); I guess you have and old dts where clock/clock-names are in the sound node. Instead the clock/clock-names properties should be specified in the CODEC's node, the related binding's documentation can be found in Documentation/devicetree/bindings/mfd/arizona.txt. Also please see patch 3/4, there is no clock properties in the sound card's DT binding. -- Thanks, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board Date: Thu, 21 Jul 2016 17:12:16 +0200 Message-ID: <5790E650.609@samsung.com> References: <1467738877-31555-1-git-send-email-s.nawrocki@samsung.com> <5788721B.7010602@samsung.com> <578CB261.60507@samsung.com> <5790A3D0.4070500@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <5790A3D0.4070500@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Chanwoo Choi Cc: robh@kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, Krzysztof Kozlowski , linux-kernel@vger.kernel.org, inki.dae@samsung.com, devicetree@vger.kernel.org, broonie@kernel.org, ideal.song@samsung.com List-Id: devicetree@vger.kernel.org On 07/21/2016 12:28 PM, Chanwoo Choi wrote: > When I test it, I can get the clock pointer by devm_clk_get() as following: > > diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c > index 9728b3c5927f..5de4fc554aec 100644 > --- a/sound/soc/samsung/tm2_wm5110.c > +++ b/sound/soc/samsung/tm2_wm5110.c > @@ -500,7 +500,7 @@ static int tm2_probe(struct platform_device *pdev) > card->dai_link[i].platform_of_node = cpu_dai_node; > } > > - priv->codec_mclk1 = of_clk_get_by_name(codec_dai_node, "mclk1"); > + priv->codec_mclk1 = devm_clk_get(dev, "mclk1"); I guess you have and old dts where clock/clock-names are in the sound node. Instead the clock/clock-names properties should be specified in the CODEC's node, the related binding's documentation can be found in Documentation/devicetree/bindings/mfd/arizona.txt. Also please see patch 3/4, there is no clock properties in the sound card's DT binding. -- Thanks, Sylwester