From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id E8BE2E00C80; Thu, 21 Jul 2016 10:01:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [147.11.146.13 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 43B26E00C69 for ; Thu, 21 Jul 2016 10:01:34 -0700 (PDT) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id u6LH1VUm003911 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 21 Jul 2016 10:01:32 -0700 (PDT) Received: from [128.224.56.48] (128.224.56.48) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.248.2; Thu, 21 Jul 2016 10:01:31 -0700 To: Jacob Kroon References: <5790C6F8.3060402@windriver.com> <5790C8ED.5040107@windriver.com> From: Bruce Ashfield Message-ID: <5790FFEA.5000401@windriver.com> Date: Thu, 21 Jul 2016 13:01:30 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Cc: Yocto Project , jason.wessel@windriver.com Subject: Re: kernel menuconfig/ncurses patch in linux-yocto X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 17:01:38 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 2016-07-21 10:24 AM, Jacob Kroon wrote: > On Thu, Jul 21, 2016 at 3:06 PM, Bruce Ashfield > wrote: >> On 2016-07-21 08:58 AM, Bruce Ashfield wrote: >>> >>> On 2016-07-21 02:35 AM, Jacob Kroon wrote: >>>> >>>> On Thu, Jul 21, 2016 at 5:22 AM, Bruce Ashfield >>>> wrote: >>>>> >>>>> On 2016-07-20 4:19 PM, Jacob Kroon wrote: >>>>>> >>>>>> >>>>>> Hi, >>>>>> I'm trying to get the SDK to be able to run the kernel's "make >>>>>> menuconfig" target >>>>>> using nativesdk-ncurses from the SDK. Looking at >>>>>> >>>>>> >>>>>> >>>>>> http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-4.4/commit/scripts/kconfig/lxdialog/check-lxdialog.sh?h=standard/beaglebone&id=badf6fedf455958fe0ff3c060c8e3965ef6d80dc >>>>>> >>>>>> >>>>>> I figured out I could pass CROSS_CURSES_[INC,LIB], but the second chunk >>>>>> in that patch looks weird: >>>>>> >>>>>> elif pkg-config --cflags ncurses 2>/dev/null; then >>>>>> echo '-DCURSES_LOC=""' >>>>>> + if [ x"$CROSS_CURSES_INC" != x ]; then >>>>>> + echo "$CROSS_CURSES_INC" >>>>>> + exit >>>>>> + fi >>>>>> elif [ -f /usr/include/ncursesw/curses.h ]; then >>>>>> echo '-I/usr/include/ncursesw -DCURSES_LOC=""' >>>>>> >>>>>> (I had to do manual indentation with spaces in gmail) >>>>>> Is the indentation or the logic incorrect ? >>>>> >>>>> >>>>> >>>>> In the commit itself, the indentation is fine. >>>>> >>>>> That block of code is just dumping flags that are used in the >>>>> build. So in this case, it is correct. If the variable is >>>>> non empty, it is echoed and then processing exits. >>>> >>>> >>>> The check if CROSS_CURSES_INC is non-empty is only done if the preceeding >>>> "elif"-check is true, and not unconditionally as one would expect >>>> judging by the indentation. >>> >>> >>> Yep, that's the point. It goes to pkgconfig first, and then falls >>> back to that. >>> >>> The indention is fine in the actual repository. >> >> >> oh wait. >> >> I had my coffee and I see now what you mean, I was checking >> older repos, and when this merged into the 4.4 tree it does >> look like the conditional is hosed. >> >> I'll queue up a closer look at this later today. >> >> Bruce >> > > Ah, that explains it. Thank you for looking into it. Yup. The original patch (of 3.14 vintage) had migrated that chunk over time to an invalid location. I fixed the block in the 4.4 kernel, and have refreshed the path so it will be fixed for the next linux-yocto kernel as well. I've pushed the changes to the tree, and will follow up with SRCREV bumps when my next change queue is ready. Bruce > > Jacob >