From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 2/6] drm/i915/guc: refactor guc_init_doorbell_hw() Date: Fri, 22 Jul 2016 11:01:50 +0100 Message-ID: <5791EF0E.9000902@linux.intel.com> References: <1469124942-17943-1-git-send-email-david.s.gordon@intel.com> <1469124942-17943-3-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 3830B6EB1A for ; Fri, 22 Jul 2016 10:01:52 +0000 (UTC) In-Reply-To: <1469124942-17943-3-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIxLzA3LzE2IDE5OjE1LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBXZSBoYXZlIGVzc2VudGlh bGx5IHRoZSBzYW1lIGNvZGUgaW4gZWFjaCBvZiB0d28gZGlmZmVyZW50IGxvb3BzLCBzbyB3ZQo+ IGNhbiByZWZhY3RvciBpdCBpbnRvIGEgbGl0dGxlIGhlbHBlciBmdW5jdGlvbi4KPgo+IFNpZ25l ZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4gLS0tCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgfCA1NCArKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAzMCBpbnNlcnRpb25z KCspLCAyNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19z dWJtaXNzaW9uLmMKPiBpbmRleCA5YzViODFiLi44MTZiZGNhIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IEBAIC02OTgsMzIgKzY5OCw0NyBAQCBz dGF0aWMgdm9pZCBnZW1fcmVsZWFzZV9ndWNfb2JqKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0 ICpvYmopCj4gICAJa2ZyZWUoY2xpZW50KTsKPiAgIH0KPgo+ICsvKiBDaGVjayB0aGF0IGEgZG9v cmJlbGwgcmVnaXN0ZXIgaXMgaW4gdGhlIGV4cGVjdGVkIHN0YXRlICovCj4gK3N0YXRpYyBib29s IGd1Y19kb29yYmVsbF9jaGVjayhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIHVpbnQxNl90IGRiX2lk KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkx NShndWMpOwo+ICsJaTkxNV9yZWdfdCBkcmJyZWcgPSBHRU44X0RSQlJFR0woZGJfaWQpOwo+ICsJ dWludDMyX3QgdmFsdWUgPSBJOTE1X1JFQUQoZHJicmVnKTsKPiArCWJvb2wgZW5hYmxlZCA9ICh2 YWx1ZSAmIEdVQ19ET09SQkVMTF9FTkFCTEVEKSAhPSAwOwo+ICsJYm9vbCBleHBlY3RlZCA9IHRl c3RfYml0KGRiX2lkLCBndWMtPmRvb3JiZWxsX2JpdG1hcCk7Cj4gKwo+ICsJaWYgKGVuYWJsZWQg PT0gZXhwZWN0ZWQpCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwo+ICsJRFJNX0RFQlVHX0RSSVZFUigi RG9vcmJlbGwgJWQgKHJlZyAweCV4KSAweCV4LCBzaG91bGQgYmUgJXNcbiIsCj4gKwkJCSBkYl9p ZCwgZHJicmVnLnJlZywgdmFsdWUsCj4gKwkJCSBleHBlY3RlZCA/ICJhY3RpdmUiIDogImluYWN0 aXZlIik7Cj4gKwo+ICsJcmV0dXJuIGZhbHNlOwo+ICt9Cj4gKwo+ICAgLyoKPiAgICAqIEJvcnJv dyB0aGUgZmlyc3QgY2xpZW50IHRvIHNldCB1cCAmIHRlYXIgZG93biBlYWNoIHVudXNlZCBkb29y YmVsbAo+ICAgICogaW4gdHVybiwgdG8gZW5zdXJlIHRoYXQgYWxsIGRvb3JiZWxsIGgvdyBpcyAo cmUpaW5pdGlhbGlzZWQuCj4gICAgKi8KPiAgIHN0YXRpYyB2b2lkIGd1Y19pbml0X2Rvb3JiZWxs X2h3KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IGd1Y190b19pOTE1KGd1Yyk7Cj4gICAJc3RydWN0IGk5MTVfZ3VjX2Ns aWVudCAqY2xpZW50ID0gZ3VjLT5leGVjYnVmX2NsaWVudDsKPiAtCXVpbnQxNl90IGRiX2lkLCBp Owo+IC0JaW50IGVycjsKPiArCXVpbnQxNl90IGRiX2lkOwo+ICsJaW50IGksIGVycjsKPgo+ICsJ LyogU2F2ZSBjbGllbnQncyBvcmlnaW5hbCBkb29yYmVsbCBzZWxlY3Rpb24gKi8KPiAgIAlkYl9p ZCA9IGNsaWVudC0+ZG9vcmJlbGxfaWQ7Cj4KPiAgIAlmb3IgKGkgPSAwOyBpIDwgR1VDX01BWF9E T09SQkVMTFM7ICsraSkgewo+IC0JCWk5MTVfcmVnX3QgZHJicmVnID0gR0VOOF9EUkJSRUdMKGkp Owo+IC0JCXUzMiB2YWx1ZSA9IEk5MTVfUkVBRChkcmJyZWcpOwo+IC0KPiAtCQlpZiAodGVzdF9i aXQoaSwgZ3VjLT5kb29yYmVsbF9iaXRtYXApKQo+ICsJCS8qIFNraXAgaWYgZG9vcmJlbGwgaXMg T0sgKi8KPiArCQlpZiAoZ3VjX2Rvb3JiZWxsX2NoZWNrKGd1YywgaSkpCj4gICAJCQljb250aW51 ZTsKPgo+ICAgCQllcnIgPSBndWNfdXBkYXRlX2Rvb3JiZWxsX2lkKGd1YywgY2xpZW50LCBpKTsK PiAtCj4gLQkJLyogUmVwb3J0IHVwZGF0ZSBmYWlsdXJlIG9yIHVuZXhwZWN0ZWRseSBhY3RpdmUg ZG9vcmJlbGwgKi8KPiAtCQlpZiAoZXJyIHx8IChpICE9IGRiX2lkICYmICh2YWx1ZSAmIEdVQ19E T09SQkVMTF9FTkFCTEVEKSkpCj4gLQkJCURSTV9ERUJVR19EUklWRVIoIkRvb3JiZWxsICVkIChy ZWcgMHgleCkgd2FzIDB4JXgsIGVyciAlZFxuIiwKPiAtCQkJCQkgIGksIGRyYnJlZy5yZWcsIHZh bHVlLCBlcnIpOwo+ICsJCWlmIChlcnIpCj4gKwkJCURSTV9ERUJVR19EUklWRVIoIkRvb3JiZWxs ICVkIHVwZGF0ZSBmYWlsZWQsIGVyciAlZFxuIiwKPiArCQkJCQlpLCBlcnIpOwo+ICAgCX0KPgo+ ICAgCS8qIFJlc3RvcmUgdG8gb3JpZ2luYWwgdmFsdWUgKi8KPiBAQCAtNzMyLDE4ICs3NDcsOSBA QCBzdGF0aWMgdm9pZCBndWNfaW5pdF9kb29yYmVsbF9odyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMp Cj4gICAJCURSTV9FUlJPUigiRmFpbGVkIHRvIHJlc3RvcmUgZG9vcmJlbGwgdG8gJWQsIGVyciAl ZFxuIiwKPiAgIAkJCWRiX2lkLCBlcnIpOwo+Cj4gLQlmb3IgKGkgPSAwOyBpIDwgR1VDX01BWF9E T09SQkVMTFM7ICsraSkgewo+IC0JCWk5MTVfcmVnX3QgZHJicmVnID0gR0VOOF9EUkJSRUdMKGkp Owo+IC0JCXUzMiB2YWx1ZSA9IEk5MTVfUkVBRChkcmJyZWcpOwo+IC0KPiAtCQlpZiAodGVzdF9i aXQoaSwgZ3VjLT5kb29yYmVsbF9iaXRtYXApKQo+IC0JCQljb250aW51ZTsKPiAtCj4gLQkJaWYg KGkgIT0gZGJfaWQgJiYgKHZhbHVlICYgR1VDX0RPT1JCRUxMX0VOQUJMRUQpKQo+IC0JCQlEUk1f REVCVUdfRFJJVkVSKCJEb29yYmVsbCAlZCAocmVnIDB4JXgpIGZpbmFsbHkgMHgleFxuIiwKPiAt CQkJCQkgIGksIGRyYnJlZy5yZWcsIHZhbHVlKTsKPiAtCj4gLQl9Cj4gKwkvKiBSZWFkIGJhY2sg JiB2ZXJpZnkgYWxsIGRvb3JiZWxsIHJlZ2lzdGVycyAqLwo+ICsJZm9yIChpID0gMDsgaSA8IEdV Q19NQVhfRE9PUkJFTExTOyArK2kpCj4gKwkJKHZvaWQpZ3VjX2Rvb3JiZWxsX2NoZWNrKGd1Yywg aSk7Cj4gICB9Cj4KPiAgIC8qKgo+CgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRr by51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==