All of lore.kernel.org
 help / color / mirror / Atom feed
From: duoming@zju.edu.cn
To: Thomas Osterried <thomas@osterried.de>
Cc: linux-hams@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: Regression in "ax25: Fix UAF bugs in ax25 timers", patch 82e31755e55fbcea6a9dfaae5fe4860ade17cbc0
Date: Mon, 23 May 2022 22:07:03 +0800 (GMT+08:00)	[thread overview]
Message-ID: <57922f90.2c358.180f13e25f0.Coremail.duoming@zju.edu.cn> (raw)
In-Reply-To: <283773C4-71DA-4631-B7B3-19497DA9D77A@osterried.de>

Hello,

On Mon, 23 May 2022 07:46:57 +0200 Thomas wrote:

> Regression due to patch 82e31755e55fbcea6a9dfaae5fe4860ade17cbc0 "ax25: Fix UAF bugs in ax25 timers",
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/net/ax25/af_ax25.c?id=82e31755e55fbcea6a9dfaae5fe4860ade17cbc0
> and discussion about necessarity of
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/net/ax25/ax25_subr.c?id=fc6d01ff9ef03b66d4a3a23b46fc3c3d8cf92009
> (because it addresses the same problem).
> 
> 
> Due to patch 82e31755e55fbcea6a9dfaae5fe4860ade17cbc, any ax25 session is cleaned up anymore on disconnect.
> -> netstat --ax25 shows the ex-connected session it in state "LISTEN". Makes ax25 unusable in a production environment.
> => Regression.

Is there any ways to reproduce this problem? 

> This is my proposal for a fix.
> I'd appreciate you test and give feedback.

I will test this solution and give feedback.

Best regards,
Duoming Zhou

  parent reply	other threads:[~2022-05-23 14:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23  5:46 Regression in "ax25: Fix UAF bugs in ax25 timers", patch 82e31755e55fbcea6a9dfaae5fe4860ade17cbc0 Thomas Osterried
2022-05-23 13:52 ` Dan Carpenter
2022-05-24  9:25   ` Thomas Osterried
2022-05-24 10:47     ` duoming
2022-05-24 21:52       ` Thomas Osterried
2022-05-25  2:34         ` duoming
2022-05-26 22:56           ` Thomas Osterried
2022-05-27  4:48             ` duoming
2022-05-23 14:07 ` duoming [this message]
2022-05-23 16:05   ` Roland Schwarz
2022-05-23 18:53     ` Thomas Osterried
2022-05-23 19:14   ` Thomas Osterried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57922f90.2c358.180f13e25f0.Coremail.duoming@zju.edu.cn \
    --to=duoming@zju.edu.cn \
    --cc=davem@davemloft.net \
    --cc=linux-hams@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=thomas@osterried.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.