From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ziyuan Xu <xzy.xu@rock-chips.com>
Date: Fri, 22 Jul 2016 23:02:53 +0800
Subject: [U-Boot] [PATCH 0/4] Ability to load linux kernel on rock2
	RK3288
In-Reply-To: <CABCGj3Z8ZW6Fq6+EaLF1v3BhcrfTtq6AZAwvdS6qTfWPRevjBQ@mail.gmail.com>
References: <1468258732-8378-1-git-send-email-apatterson@sightlogix.com>
 <CABCGj3adEY9yVJv3CuCXMfJVfpupVce44vRPcC=d1wBnis+LxQ@mail.gmail.com>
 <CAPnjgZ3pPmfZEwtHz6PnLVJ9piTD0qa6_Ts4m3m4hcPD5BOLTg@mail.gmail.com>
 <CABCGj3bPY7bgQY6KFZeXW_Xwp3jKnqxH9b8BRfQwytfNRJO-sQ@mail.gmail.com>
 <CAPnjgZ0cFQ4AtBC-D-r8010gzcLvX3D3CD0cxZXEkWYNwVy+xA@mail.gmail.com>
 <CABCGj3Z8ZW6Fq6+EaLF1v3BhcrfTtq6AZAwvdS6qTfWPRevjBQ@mail.gmail.com>
Message-ID: <5792359D.5040702@rock-chips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

?Alexander Graf

On 2016?07?22? 21:49, Sandy Patterson wrote:
> Ziyuan,
>
> I retested the kernel loading. I'm using 3.14 kernel. I also tested 
> with linux-4.7-rc6. I still require both the cache reverts and 
> disabling efi_loader on u-boot/master and u-boot-rockchip/master. (see 
> below for testing parameters)
>
> Hans,
> I have been unable to boot an RK3288 rock2 square board since v2016.03 
> release. The kernel fails to start.
>
> Before reverting I get this on my console:
>
> Starting kernel ...
>
> ### ERROR ### Please RESET the board ###
>
> Another possibly related problem which has similar effect without the 
> ERROR potion above is a call to invalidate_icache_all() from 
> efi_runtime.c. Commenting out this line or disabled CONFIG_EFI_LOADER 
> seems to allow the kernel to boot.
>
> testing:
> board: radxa rock2 square
> kernel: 3.14 custom, and linux-4.7-rc6 - multi_v7_defconfig zImage 
> rk3288-radxa-rock.dtb
> toolchain: gcc-linaro-5.3-2016.02-x86_64_arm-linux-gnueabi
> loading from sd card - the actual loading seems fine though. I'm not 
> sure how emmc would change anything.
>
> booting command for 4.7 (we use and care about 3.14, but i thought it 
> would be easier to show with 4.7-rc6. I get the same behavior with 3.14):
> setenv bootargs root=/dev/mmcblk0p4
> ext4load mmc 0:3 0x02000000 /zImage; ext4load mmc 0:3 0x01f00000 
> /rk3288-rock2-square.dtb
> bootz 0x02000000 - 0x01f00000
>
> u-boot/master: 95d52733036af7438a5285d729d53844ec48c63e
> CONFIG_EFI_LOADER=n and cache reverts required to load kernel
> *_high changes don't seem to be required anymore
>
> u-boot-rockchip: 1781acd31b01225402167fbdb8fa97157cc269eb
> CONFIG_EFI_LOADER=n and cache reverts required to load kernel
> *_high changes don't seem to be required anymore
>
> Sandy Patterson
>
>
> On Thu, Jul 21, 2016 at 11:21 PM, Simon Glass <sjg@chromium.org 
> <mailto:sjg@chromium.org>> wrote:
>
>     +Hans, Tom
>
>     Hi Sandy,
>
>     On 15 July 2016 at 07:40, Sandy Patterson
>     <apatterson at sightlogix.com <mailto:apatterson@sightlogix.com>> wrote:
>     > Hi Simon,
>     >
>     > I think I screwed up submitting, and didn't cc the maintainers
>     for the
>     > reverts. I can resubmit and get patman to behave. What do you
>     suggest?
>     >
>     > I still think this is the best patch to getting rock2 to load
>     kernels again.
>     >
>     > I just retested with a patch specific to my kernel. I think 3.14
>     linux has
>     > some quirks in how it wants the dram setup, and I get
>     instability without
>     > some changes to the dram init. I don't have enough of a system
>     to test for
>     > this instability using the latest mainline kernel, so I left
>     that patch out.
>     >
>     > Ziyuan had an alternative fix for efi_loader, but it looks like
>     it may break
>     > efi_loader for others, and I don't know how to test the efi
>     functionality,
>     > so I think disabling for RK3288 is best. I think I should move the
>     > CONFIG_EFI_LOADER patch to somehow patching rk3288_common.h
>     instead (can I
>     > #undef config vars in that file?)
>
>     Yes please can you resend and cc the maintainers and original author.
>     Patman -t should do this automatically.
>
>     Also with the revert of Han's ARM patches, please can you describe the
>     problem so it is clear why we need to revert?
>
>     Regards,
>     Simon
>
>     [...]
>
>